OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 1
Total Committers: 73
Last Commit: 17:08
Commits this week: 1
Total Lines of Code (LoC): 68,337
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 05 Dec 2021
4:36 pm

gustafn

modernize code

Options
    • -31
    • +36
    ./tcl/defs-procs.tcl
4:34 pm

gustafn

improve spelling

Options
    • -6
    • +6
    ./catalog/acs-tcl.en_US.ISO-8859-1.xml
Tuesday 30 Nov 2021
8:33 am

antoniop

Close parenthesis in doc

Options
    • -2
    • +2
    ./tcl/utilities-procs.tcl
Monday 29 Nov 2021
5:56 pm

gustafn

fix broken util::word_diff and add regression test

The function was already broken before the change of today,

removing the needed for a pipe open.

Options
    • -2
    • +2
    ./tcl/utilities-procs.tcl
    • -0
    • +48
    ./tcl/test/utilities-procs.tcl
3:37 pm

gustafn

added dropped "cd" command

Options
    • -1
    • +2
    ./tcl/01-database-procs.tcl
3:33 pm

gustafn

reduce cases of tcl pipe open in acs-core

AFIKT, the semantics are the same.

For background, see: https://openacs.org/forums/message-view?message_id=5539060

Options
    • -36
    • +33
    ./tcl/01-database-procs.tcl
    • -14
    • +26
    ./tcl/utilities-procs.tcl
Friday 19 Nov 2021
10:03 am

gustafn

improve german message keys (spelling, comma, spaces, orthogonality)

Options
    • -10
    • +10
    ./catalog/acs-tcl.de_DE.ISO-8859-1.xml
  2. … 3 more files in changeset.
Thursday 18 Nov 2021
8:56 pm

gustafn

reduce further redundancy

Options
    • -0
    • +19
    ./tcl/acs-cache-procs.tcl
    • -25
    • +13
    ./tcl/apm-procs.tcl
8:13 pm

gustafn

reduce frequent small SQL queries and streamline code

Options
    • -7
    • +12
    ./tcl/apm-install-procs.tcl
    • -19
    • +28
    ./tcl/apm-procs.tcl
    • -8
    • +0
    ./tcl/apm-procs.xql
Monday 15 Nov 2021
6:28 pm

antoniop

Make so that upon package deletion, also the leftover site nodes are deleted (if they do no have children nodes)

Options
    • -1
    • +22
    ./tcl/apm-install-procs.tcl
  2. … 1 more file in changeset.
Friday 12 Nov 2021
9:59 am

gustafn

Don't complain when flushing per-thread cache without content

Options
    • -1
    • +1
    ./tcl/acs-cache-procs.tcl
Tuesday 09 Nov 2021
9:05 pm

gustafn

Added per-request-cache for parameter::get similar to parameter handling in xotcl-core

This change improves scalability especially on sites with high numbers

of concurrent requests by reducing the number of required locks in

general. This change keeps the parameter dict in a per-request cache

to reduce potentially high number of nsv locks, when parameters of a

package are queried a often per request. Without this change we see on

some sites > 100 locks on the ad_param-nsv per request. Alone the

request-procesor queries a larger set of parameters from the acs-core

package, which requires now a single lock operation.

Using the per-request cache has the advantave of avoiding locks and

keeping the internal representations of tcl-objs (whereas ns_cache or

nsvs use plain strings).

Options
    • -4
    • +24
    ./tcl/defs-procs.tcl
Thursday 04 Nov 2021
5:11 pm

gustafn

mitigate attacks, where the referer header field is changed to a malicious value

The problem does not exist, when CSP is defined properly.

Many thanks to Frank Bergmann for sharing the pen-test protocol

Options
    • -2
    • +2
    ./tcl/request-processor-procs.tcl
    • -5
    • +5
    ./tcl/tcl-documentation-procs.tcl
    • -1
    • +10
    ./tcl/utilities-procs.tcl
Tuesday 02 Nov 2021
11:29 am

gustafn

Performance improvement: make "apm_version_names_compare" faster by a factor of ~100

The function "apm_version_names_compare" is called relatively often

and issues an SQL query. The function is stable (returns always the

same results for the same input) and called with only a few different

input values. By using acs::per_thread_cache the performance improves

from 265 microseconds to 2 microseconds; by using the per-tread cache

the operation scales better since it is fully lock-free (once cached).

Options
    • -13
    • +11
    ./tcl/apm-install-procs.tcl
Friday 29 Oct 2021
12:35 pm

gustafn

added support for "ns_trim -prefix".

The command is predefined in NaviServer; if not available, a comatibility version is added.

This change also mitigates a potential memory-leak problem in nsv_dict with certain

versions of NaviServer which might lead on busy sites to problems.

Options
    • -2
    • +2
    ./acs-tcl.info
    • -12
    • +39
    ./tcl/00-icanuse-procs.tcl
  3. … 2 more files in changeset.
Wednesday 27 Oct 2021
6:46 pm

gustafn

remove incorrect and misleading comment and simplify code accordingly

Options
    • -15
    • +7
    ./tcl/parameter-procs.tcl
6:42 pm

gustafn

set the global variable ::acs::kernel_id early enough during boostrap of new instances, such it can be used in a uniform way

Options
    • -2
    • +6
    ./tcl/20-memoize-init.tcl
    • -5
    • +5
    ./tcl/server-cluster-procs.tcl
  3. … 1 more file in changeset.
6:34 pm

gustafn

improve comment

Options
    • -3
    • +3
    ./tcl/site-nodes-procs.tcl
Tuesday 19 Oct 2021
11:07 am

gustafn

extend tests for naturalnum

Options
    • -1
    • +1
    ./tcl/test/acs-tcl-test-procs.tcl
Monday 18 Oct 2021
6:31 pm

antoniop

Prefer api to retrieve the acs-kernel id, as this will work also in corercases such as bootstraping of a new OpenACS instance

Options
    • -1
    • +1
    ./tcl/20-memoize-init.tcl
    • -5
    • +5
    ./tcl/server-cluster-procs.tcl
Friday 15 Oct 2021
4:18 pm

gustafn

fix wrong name (not sure, why i have not noticed this earlier)

Options
    • -2
    • +2
    ./tcl/site-nodes-procs.tcl
Wednesday 13 Oct 2021
9:18 pm

gustafn

perform also sitewide flushes for urspace based site-node cache

Options
    • -0
    • +1
    ./tcl/acs-cache-procs.tcl
    • -2
    • +2
    ./tcl/site-nodes-procs.tcl
Tuesday 12 Oct 2021
10:56 am

gustafn

More work on refactoring and streamlining cluster infrastructure

- removed more cases of ad-hoc parsing of IP address and port

- reduced code redundancy

- fixed incorrect comments

- removed obsolete private functions server_cluster_httpget_from_peers

and server_cluster_do_httpget (replaced by acs::clusterwide)

Options
    • -9
    • +12
    ./tcl/cluster-init.tcl
    • -51
    • +43
    ./tcl/server-cluster-procs.tcl
Monday 11 Oct 2021
10:11 pm

gustafn

Refactored and streamlined of cluster infrastructure

- base the API new new cluster infrastructure (including memoize-flush, server_cluster_peer_hosts, etc.)

- improved handling for multiple IP addresses and IPv6

- removed assumptions of local vs. global network drivers

- server_cluster_httpget_from_peers not used anymore

Options
    • -35
    • +1
    ./tcl/20-memoize-init.tcl
    • -19
    • +50
    ./tcl/acs-cache-procs.tcl
    • -19
    • +38
    ./tcl/cluster-init.tcl
    • -1
    • +10
    ./tcl/memoize-procs.tcl
    • -23
    • +13
    ./tcl/server-cluster-procs.tcl
  6. … 1 more file in changeset.
Thursday 07 Oct 2021
5:42 pm

gustafn

Provide a default timeout of 5m to all ns_cache besed caches created via the acs-cache infrastructure

Background: in case, a db entry is to be cached, where the db query

does not finish (e.g. runs into a deadlock), subsequent attempts for

the same value will be blocked as well by the mutex protecting the

entry to be cached. Therefore, later requests to this entry might queue

up in the server. By providing a timeout, this mutex will terminate

latest when the timeout is reached.

The default value for the timeout is set to 5m. In case a certain

cache might issue requests running longer than this, the cache has

to be configured with a larger timeout value.

Options
    • -0
    • +2
    ./tcl/acs-cache-procs.tcl
1:07 pm

gustafn

improve spelling

Options
    • -8
    • +8
    ./tcl/utilities-procs.tcl
Wednesday 06 Oct 2021
2:21 pm

trenner

provide a fork-free implementation of dot rendering

Options
    • -4
    • +5
    ./tcl/utilities-procs.tcl
Monday 04 Oct 2021
11:37 am

gustafn

Improving ad_parameter_cache:

- added handling of cachingmode "none"

- added implementation via "nsv_dict" (cluster aware)

- execute parameter callbacks cluster-wide

- version number bumped to 5.10.1d4

Options
    • -2
    • +2
    ./acs-tcl.info
    • -7
    • +9
    ./tcl/acs-cache-procs.tcl
    • -47
    • +165
    ./tcl/defs-procs.tcl
    • -3
    • +3
    ./tcl/parameter-procs.tcl
11:35 am

gustafn

improve spelling

Options
    • -2
    • +2
    ./tcl/security-procs.tcl
Sunday 03 Oct 2021
8:13 pm

gustafn

added support for SCRYPT (RFC 7914) as password hash function.

The use of scrypt requires NaviServer compiled with OpenSSL 3.0 or newer

Options
    • -2
    • +15
    ./tcl/security-procs.tcl
  2. … 1 more file in changeset.