• last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Added fix to make session_id cookie persistent if you checked remember me

Fix call to content::type::is_content_type. Switch name is object_type not content_type

merge new application_data_link::get_links_to proc from oacs-5-6 branch

add application_data_links::get_links_to proc (there was only get_links_from)

Applied patch from malte which regularizes and escapes newlines in generated

JSON strings.

Typo on proc docu.

Add require_login to admin filter. This was exposed as an issue when someone accidentally granted admin to the public. No administrator action ever needs to be performed when not logged in.

Fix remember me checkbox. Conditionally set login cookie discard_p setting based on value of the remember me checkbox when creating or renewing the login cookie.

fixing bad test. string match glob doesnt work for this scenario, replacing with regexp

adding donb's 1.26 revsion back in.. I accidently overwrote it.

    • -107
    • +112
    ./tcl-documentation-procs.tcl
case fold before checking if column exists

you need to flush the package id to package_key map on update otherwise parameter updates and other things depending on package key fail until server restart. no attempt made to fix teh xotcl-core cached version. also misnamed query fixed

accept pkey, fkey, and key as constraint suffixes since the pg automatic names use them and are good

Removing query text that was moved previosly to its respective xql file.

- Fix for Tcl 8.5: OpenACS did overwrite the Tcl built-in command

"::apply" and broke therefore all scripts/libraries using it.

Changed the name of the OpenACS function to "ad_apply" and altered

the few occurances. The fix works as well with Tcl 8.4. The proper

fix for 8.5 would be to use instead of the function the expand

operator {*}

  1. … 3 more files in changeset.
- Fix for Tcl 8.5: OpenACS did overwrite the Tcl built-in command

"::apply" and broke therefore all scripts/libraries using it.

Changed the name of the OpenACS function to "ad_apply" and altered

the few occurances. The fix works as well with Tcl 8.4. The proper

fix for 8.5 would be to use instead of the function the expand

operator {*}

  1. … 3 more files in changeset.
- fix for Tcl 8.5: OpenACS did overwrite the Tcl built-in command "::apply" and broke therefore all scripts/libraries using it.

Changed the name of the OpenACS function to "ad_apply" and altered the few occurances.

The fix works as well with Tcl 8.4. The proper fix for 8.5 would be to use instead of the function the expand operator {*}

  1. … 3 more files in changeset.
Merged oacs-5-6 to HEAD. HEAD now installs and passes all core tests. There

may still be some lingering problems due to my screwing up the oacs-5-6

branch earlier, I'll be looking into this later.

  1. … 204 more files in changeset.
In NaviServer usage of ns_startcontent is deprecated instead we use ns_headers to specify the content-type which is added to the connection outputheaders ( which are sent to the client when the first ns_write is called, so no need to use ns_write to write headers to the client before serving the content)

SuppressHttpPort parameter is located in acs-tcl and not acs-kernel. This was the reason of misbehavior when service is running behind a proxy.

Enhanced the documentation of [set_encoding]

First step in turning ad_http* and util_http* charset- and encoding aware. I added a new helper proc [set_encoding] which handles charset resolution and mapping between IANA/MIME charset names and Tcl encoding names. Currently, this works for the reply-side in GET and POST requests.

- fix test files__tcl_file_common_errors

- report errors as such in aa-test (wrote warnings into error log, this was ignored since ages)

- fixed naming in acs-tcl, acs-mail-lite and acs-subsite

  1. … 4 more files in changeset.
Force references to an embedded package's admin or sitewide-admin pages to

be referenced (relative to the embedding package's mount point) as

admin/package-key or sitewide-admin/package-key. This nicely arranges

all admin URLs in a composite package under ${mount-point}/admin, which

among other things will cause the request processor to do the expected

permission check. Backdoor access to the admin pages via URLs like

${mount-point}/package-key/admin or ${mount-point}/package-key/sitewide-admin

is blocked, as the request processor won't do the expected permissions check

for URLs of that form.,

When using AOLserver 4.5 with a config file not containing values for maxthreads,

etc, the pools init code would choose default values that are illegal, causing

an error to show up in one's log file. I've set the default values to those

found in our /etc/config.tcl file.

Added my JSON utilities package. Included are procs to parse a JSON string

into a canonical Tcl list representation, to generate a JSON string from

such a representation (round-tripping works, i.e. JSON -> Tcl -> JSON),

pretty-print JSON strings, set/get attributes, create objects and arrays,

etc.

file json-procs.tcl was initially added on branch oacs-5-6.

Removing duplicated -private switch.

Cleaned up APM handling of inherited parameters so that deletion of

a dependency works well now, the parameters page with the APM only shows

parameters specified in the package (rather than include inherited ones),

and the XML file is correclty written.

  1. … 6 more files in changeset.