OpenACS / openacs-4 / packages / acs-tcl / tcl

test

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 26
Last Commit: 31 May
Commits this week: 0
Total Lines of Code (LoC): 13,206
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 18 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 11 Oct 2022
11:04 am

antoniop

Util user message reform: when a message is repeated, do not create a new entry, but just increase a counter, which will be displayed when the message is retrieved

Increase test coverage

Options
    • -0
    • +82
    ./utilities-procs.tcl
  2. … 1 more file in changeset.
Wednesday 14 Sep 2022
12:45 pm

antoniop

Ignore also class definitions in the ignored namespaces

Options
    • -1
    • +1
    ./doc-check-procs.tcl
Tuesday 13 Sep 2022
4:40 pm

antoniop

Ignore the ::nsshell namespace: this is a NaviServer module, hence outside the OpenACS source tree

Options
    • -0
    • +1
    ./doc-check-procs.tcl
Monday 12 Sep 2022
3:45 pm

antoniop

Consider @see annotations as sufficient documentation

Options
    • -1
    • +2
    ./doc-check-procs.tcl
Friday 09 Sep 2022
3:53 pm

antoniop

Make test more precise: some procs have just a newline in their doc instead of meaningful documentation...

Options
    • -1
    • +4
    ./doc-check-procs.tcl
1:32 pm

antoniop

Centralize retrieval of the test URL

Options
    • -9
    • +1
    ./http-client-procs.tcl
    • -13
    • +1
    ./security-procs.tcl
  3. … 4 more files in changeset.
Thursday 08 Sep 2022
10:41 am

antoniop

Increase proc coverage

Options
    • -0
    • +50
    ./navigation-procs.tcl
10:13 am

antoniop

Increase test coverage

Options
    • -0
    • +6
    ./defs-procs.tcl
Wednesday 07 Sep 2022
4:16 pm

antoniop

Test some system information api

The test shows that ad_acs_admin_node has so far returned a boolean, countrary to what the documentation says

Options
    • -0
    • +52
    ./acs-kernel-procs.tcl
4:16 pm

antoniop

file acs-kernel-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./acs-kernel-procs.tcl
3:53 pm

antoniop

Test demoting/promoting of a user + a buch of other api

This test fails now when checking if a demoted user is still an swa, one needs to flush the permissions as well

Options
    • -1
    • +103
    ./community-core-test-procs.tcl
2:51 pm

antoniop

Test acs_user::ScreenName

Options
    • -1
    • +42
    ./community-core-test-procs.tcl
12:27 pm

antoniop

Test acs_object_type_hierarchy

Options
    • -1
    • +76
    ./object-test-case-procs.tcl
Tuesday 06 Sep 2022
2:41 pm

antoniop

Test acs_object_type::get_table_name

Options
    • -1
    • +21
    ./object-test-case-procs.tcl
2:31 pm

antoniop

Test acs_object_name api

Options
    • -1
    • +21
    ./object-test-case-procs.tcl
2:27 pm

antoniop

Test acs_magic_object

Options
    • -1
    • +18
    ./object-test-case-procs.tcl
2:22 pm

antoniop

Test various URL generating procs

Options
    • -0
    • +72
    ./defs-procs.tcl
2:22 pm

antoniop

file defs-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./defs-procs.tcl
9:40 am

antoniop

Deprecate util_commify_number, replace occurrences and translate automated tests

Options
    • -20
    • +20
    ./acs-tcl-test-procs.tcl
  2. … 9 more files in changeset.
Thursday 01 Sep 2022
11:50 am

antoniop

Extend regression test

Options
    • -5
    • +64
    ./http-client-procs.tcl
12:41 am

antoniop

Fix self-inflicted bug: one should indeed be able to specify the same form var multiple time, test the behavior for the future

Options
    • -0
    • +59
    ./http-client-procs.tcl
  2. … 2 more files in changeset.
Monday 29 Aug 2022
1:53 pm

gustafn

Use "ns_parsehtml" for speed and correctness when available

The new NaviServer built-in command "ns_parsehtml" is used on

several occasions in the code when available, namely in

- util_close_html_tags

- escaping disallowed HTML tags in ad_text_to_html

- util_close_html_tags

The command "util_close_html_tags" has a long history of troubles,

since it was implemented originally based on regular expressions. It

was reported in Jan 2009, that the function took on certain forums

entries 6 to 9 hours (e.g. /forums/message-view?message_id=357753) to

finish. Therefore, at this time a quick version based on tdom was

introduced, which reduced at that time the performance to 7.3

seconds. However, the tdom-based version tend to fail on invalid HTML,

so it could cover only a few cases. The new "ns_parsehtml" is more

robust and works very stable on openacs.org with the know problem

cases. Furthermore, this version is also significantly faster than the

tdom version.

Options
    • -6
    • +17
    ./html-conversion-procs.tcl
  2. … 1 more file in changeset.
12:34 pm

gustafn

improve spelling

Options
    • -1
    • +1
    ./acs-db-00-procs.tcl
    • -1
    • +1
    ./apm-install-procs.tcl
    • -10
    • +69
    ./html-conversion-procs.tcl
    • -7
    • +7
    ./object-test-case-procs.tcl
  5. … 3 more files in changeset.
11:47 am

antoniop

Fix typo

Options
    • -1
    • +1
    ./doc-check-procs.tcl
Saturday 27 Aug 2022
10:35 pm

gustafn

use icanuse "ns_parsehtml" and new interface

Options
    • -5
    • +4
    ./doc-check-procs.tcl
Friday 26 Aug 2022
3:00 pm

antoniop

Deprecate ad_parameter_all_values_as_list: it does not provide much value and was also often use improperly

Options
    • -2
    • +0
    ./html-conversion-procs.tcl
  2. … 4 more files in changeset.
2:06 pm

antoniop

tmpfile page contract filter reform:

do not allow acs-subsite TmpDir parameter to define where the tmpfolder is located anymore. This MUST be the one configured in the server-wide configuration. Tmpfiles cannot be in a subfolder of the tmpfolder, they MUST be direct children instead. A tmpfile MUST exist beforehand and be owned, be readable and writable by the user running the nsd process. This complies with the definition of a tmpfile by AolServer/NaviServer when they are created to store content coming from a file upload.

Options
    • -28
    • +0
    ./security-procs.tcl
  2. … 4 more files in changeset.
Thursday 25 Aug 2022
5:37 pm

antoniop

Reimplement ad_page_contract_filter_proc_tmpfile using security::safe_tmpfile_p

Some of the features implemented by this filter have been ported into the api, namely the possibility to fetch the valid temp folders from the subsite TmpDir parameter and the possibility to relax the check and allow also files deeper in the tmpfolder hierachy.

Notably, the hardcoded tmpfolders "/var/tmp" and "/tmp" have NOT been ported. One should configure these values via the many available options. security::safe_tmpfile_p is also more restrictive when a file exists, because it checks for ownership and read and write permissions on the file.

Options
    • -1
    • +30
    ./security-procs.tcl
  2. … 2 more files in changeset.
3:12 pm

antoniop

Declare proc coverage

Options
    • -0
    • +2
    ./http-client-procs.tcl
  2. … 1 more file in changeset.
2:37 pm

antoniop

Add must_exist flag to enforce a safe tmpfile to already exist

Options
    • -1
    • +6
    ./security-procs.tcl
  2. … 2 more files in changeset.