• last updated 36 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Implements TIP #140. Rollout support params are package parameters now (instead of config.tcl ones). ns_sendmail is now deprecated but provided as a wrapper to acs_mail_lite::send for backward compatibility.

  1. … 2 more files in changeset.
Added comment to explain Dcc vs Bcc

Rolling back Victor's change. DCC is correct (BCC wouldn't work as expected).

most likely the author meant BCC instead of DCC.

Added rollout support without using ns_sendmail anymore. Beware that the email message will be print out to the log raw, so if there are attachments, they will be print out too.

remove duplicate procs bounce_prefix and address_domain which live in incoming-mail-procs.tcl and bounce-procs.tcl

TIP#127 Add object_id as optional parameter to acs_mail_lite::send

  1. … 3 more files in changeset.
Envelope sender disappeared during the refactoring of send between 5.3 and 5.4 and therefore was set using the from address. This led messages to be identified as junk by SPF, and bounces to be sent back to the user. This is a fix that puts the correct envelope sender back.

Since acs_mail_lite::send now accepts a multiple TO address, the user_id part of the bounce address it set to 0 if there are multiple recipients.

Envelope sender disappeared during the refactoring of send between 5.3 and 5.4 and therefore was set using the from address. This led messages to be identified as junk by SPF, and bounces to be sent back to the user. This is a fix that puts the correct envelope sender back.

Since acs_mail_lite::send now accepts a multiple TO address, the user_id part of the bounce address it set to 0 if there are multiple recipients.

Merged from 5.4.2

  1. … 283 more files in changeset.
Ooops, forgot to rename a variable

Reodered the steps to build the message parts first, then add the headers using mime::setheaders (except To, From, CC and BCC). Retrieve the message as a string only if delivery mode is not set to default (smtp). Tested successfully with tcllib 1.8 and 1.10 (unless I missed something)

After discussion in the OCT, rolled this back. And leave it rolled back.

Fixed problem with complex send not knowing about the new valid_email_p procedure. additionally made sure that no empty header could be passed, as this breaks smtp::sendmail

  1. … 1 more file in changeset.
Removed these two procs entirely, since a search of packages and contrib shows

that nothing in our tree uses them (and no package outside of acs-mail-lite

should've used them in the first place).

Use DCC header instead of the BCC one in call to ::smtp::sendmessage

Move complex_smtp to smtp. Mark ::sendmail and ::deliver_mail as deprecated

  1. … 1 more file in changeset.
Remove sendmail procs to use smtp only. Remove SendmailBin parameter (not used anymore)

  1. … 4 more files in changeset.
Replace send procs with a refactored version of complex_send, allowing cc, bcc and attachments

  1. … 6 more files in changeset.
Indent code

  1. … 3 more files in changeset.
Merged 5.3 to HEAD

  1. … 60 more files in changeset.
Added checking for valid emails and record bounces when the email is not valid

  1. … 4 more files in changeset.
Fixing minor bugs with regards to parameters and started to split up the code a little bit more to make it readable

  1. … 3 more files in changeset.
Remove duplicated proc with_finally (also exists in acs-tcl/tcl/utilities-procs.tcl) and remove unnecessary with_finally block in the sweeper procs

Catch errors when sweeping the mail queue to avoid notifications to remain unsent until the bad message has been manually removed. With the catch, the bad message remains in the queue and an error message sent to the log, and the sweeper proceeds with the next ones.

Made sure that you are only sending if the to_addr is not empty after working on it

  1. … 1 more file in changeset.
Some cleanup

  1. … 3 more files in changeset.
Upgraded version to reflect it is part of core now. Added incoming_object_email callback as per http://openacs.org/xowiki/incoming_email. Moved incoming e-mail procs to a separate file

  1. … 3 more files in changeset.
Normalizing string comparison operations into tcl 8.4 operations, enabling byte-code compilation for expressions and many conditionals

  1. … 367 more files in changeset.
Support for from_addr in addition sender_id in the complex_send callback. Correctly handle incoming file attachments. Get rid of hard coded subject_encoding

  1. … 3 more files in changeset.