• last updated 23 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Extend test suite to check that also dates in the "short" time format are supported

This test will fail

    • -0
    • +6
    ./tcl/test/acs-lang-localization-procs.tcl
Form widget attributes reform:

- consolidate the logics to merge tag attributes coming from the adp and the tcl definitions of widgets into a private api

- change the previous behavior of having attributes coming from the adp (aka the tag_attributes argument) take over attributes coming from the element

See https://openacs.org/forums/message-view?message_id=5799349

  1. … 6 more files in changeset.
harden page contracts

    • -2
    • +2
    ./www/admin/edit-localized-message.tcl
  1. … 19 more files in changeset.
bumped version numbers to 5.10.1b1

  1. … 85 more files in changeset.
regenerated documentation

  1. … 294 more files in changeset.
Test external command line dependencies

  1. … 1 more file in changeset.
Complete coverage for the package

file lang-widget-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./tcl/test/lang-widget-procs.tcl
Go ahead and reimplement also lc_time_utc_to_local

    • -16
    • +0
    ./tcl/localization-procs-oracle.xql
    • -14
    • +0
    ./tcl/localization-procs-postgresql.xql
Reimplement lc_time_local_to_utc using lc_time_tz_convert

    • -11
    • +0
    ./tcl/localization-procs-oracle.xql
    • -9
    • +0
    ./tcl/localization-procs-postgresql.xql
Improve test for lc_time_local_to_utc, showing that its behavior is inconsitent with respect to invalid input

    • -0
    • +33
    ./tcl/test/acs-lang-localization-procs.tcl
Return the system locale as the user locale also when user preferences are there for the user, but the locale is empty

Replace api outside of the package dependencies

Deprecate Oracle-specific collation api

Although it could be interesting to have OpenACS cross-db support for collation, it is unclear if just using different idioms in xql files would not achieve the same.

Update thead variable them setting the translator mode

Increase coverage

This test will currently fail because the translator mode flag is cached per thread, but the set api won't update this cache.

Increase proc coverage

Increase proc coverage

Re-load also all other enabled locales to avoid test side effects

Increase proc coverage

Wrap test in a transaction

    • -116
    • +118
    ./tcl/test/lang-catalog-procs.tcl
file lang-util-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./tcl/test/lang-util-procs.tcl
Increase proc coverage

Improve coverage

Increase proc coverage

Cleanup private interface lang::system::timezone_support_p: ref-timezones has been made a dependency of acs-lang long ago

    • -83
    • +73
    ./tcl/test/acs-lang-test-procs.tcl
Allow to specify a user for lang::user::language, default to the package default locale when a locale for user+package is not found

Increase proc coverage

This test will fail because of two reasons:

- when using package-level locales and a package default locale is specified, but no user+package locale, the expected behavior should be that the default from the package is used, but this is not the case

- lang::user::language does not allow to specify a user id

file locale-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./tcl/test/locale-procs.tcl
Increase proc coverage

    • -5
    • +104
    ./tcl/test/lang-catalog-procs.tcl