• last updated 22 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Increase proc coverage

Improve coverage

Increase proc coverage

Cleanup private interface lang::system::timezone_support_p: ref-timezones has been made a dependency of acs-lang long ago

  1. … 5 more files in changeset.
Increase proc coverage

This test will fail because of two reasons:

- when using package-level locales and a package default locale is specified, but no user+package locale, the expected behavior should be that the default from the package is used, but this is not the case

- lang::user::language does not allow to specify a user id

file locale-procs.tcl was initially added on branch oacs-5-10.

Increase proc coverage

Increase proc coverage

file lang-catalog-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./lang-catalog-procs.tcl
Cleanup leftover, fix typos

Introduce a thorough test of the lc_time_tz_convert api checking:

- dates in the distant past

- dates in the distant future

- daylight saving for different times of the year across the two timezones

- historical circumstances (e.g. Pre-timezones US)

- Invalid input

The test shows that the current api does not behave consistently in certain circumstances:

- the same time_value is sometimes returned with invalid input

- the empty string is sometimes returned with valid input

- for dates where the ref-timezones package does not provide information, no result is returned

    • -0
    • +118
    ./acs-lang-localization-procs.tcl
improve spelling

  1. … 9 more files in changeset.
Return 0 when looking up the existance of a message key in an unsupported locale instead of failing, test the behavior

  1. … 1 more file in changeset.
Improve test precision: take into account packages defined as <install... in the info file, as e.g. dotlrn does

info files do not contain message keys

Expose a bug in the message key registration:

when a message key is soft-deleted and the server is restarted, upon re-registration the nsv that signals its presence won't be found and an insertion will be attempted. However, as the db entry is there, a primary key constraint will be triggered.

Stick to packages that are enabled

  1. … 1 more file in changeset.
Use the intended table to get packages that are known to the system

  1. … 1 more file in changeset.
Add comment

Make api to retrieve the dependencies of a package public, as we use it in a test in another package, swith to the api that will retrieve the cached value instead of re-computing the result

  1. … 1 more file in changeset.
New test to check that message keys are used consistently with package dependencies

this can only be enforced as a warning because it is possible to have constructs such as "if installed, then use message key" that would be tricky to detect

list called api procs

complete listing of covered procs in test cases

  1. … 14 more files in changeset.
bring test coverage to >50% by adding test cases and marking only locally called functions as private

  1. … 2 more files in changeset.
improve listing of test coverage

  1. … 17 more files in changeset.
make listing of tested procs more complete

  1. … 5 more files in changeset.
make comment more precise

New test to enforce that catalog files are valid XML

Improve sql portability

    • -22
    • +22
    ./acs-lang-localization-procs.tcl
  1. … 6 more files in changeset.
Improve test