OpenACS / openacs-4 / packages / acs-authentication

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 30
Last Commit: 30 Apr
Commits this week: 0
Total Lines of Code (LoC): 8,601
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 16 Jun 2017
7:07 pm

antoniop

Fix typo in previous commit

Options
    • -2
    • +2
    ./authentication-procs.tcl
7:05 pm

antoniop

Don't steal anybody's address nor email, especially if people was banned. Fail and give a message instead.

Options
    • -12
    • +3
    ./authentication-procs.tcl
Friday 09 Jun 2017
3:40 pm

antoniop

simplify idiom

Options
    • -2
    • +2
    ./local-procs.tcl
Wednesday 31 May 2017
1:48 pm

gustafn

Provide more infrastructure support for host-node-maps for more flexible domain handling

- add optional -cookie_domain parameter to the following functions

ad_user_login

ad_user_logout

sec_generate_session_id_cookie

auth::issue_login (wrapper for ad_user_login)

if not specified, the functions are full backward compatible

- add optional parameter -host_node_id to auth::authenticate

which refers to the node_id in the host-node-map

- pass host_node_id from from/to register pages

TODO:

1) probably, sec_generate_session_id_cookie picks up the wrong

session_id via [ad_conn session_id]

2) check interaction with CookieDomain (probably, we need

must not pass host_node_id wheren CookieDomain is non-empty)

Options
    • -6
    • +31
    ./authentication-procs.tcl
    • -2
    • +2
    ./password-procs.tcl
  3. … 6 more files in changeset.
Monday 24 Apr 2017
12:46 pm

gustafn

Increase size of URL, remove default, since it does not match well with required/non-required

Options
    • -2
    • +2
    ./authentication-procs.tcl
Saturday 22 Apr 2017
8:19 pm

gustafn

Fix spelling error

Options
    • -2
    • +2
    ./authentication-procs.tcl
Friday 21 Apr 2017
5:27 pm

gustafn

Fix spelling errors

Options
    • -2
    • +2
    ./authentication-procs.tcl
    • -2
    • +2
    ./password-procs.tcl
  3. … 24 more files in changeset.
Tuesday 07 Mar 2017
8:56 pm

gustafn

White space change: remove tabs and trailing spaces

Options
    • -300
    • +298
    ./authentication-procs.tcl
8:53 pm

gustafn

Improve comment, remove useless parenthesis

Options
    • -6
    • +6
    ./authentication-procs.tcl
Monday 06 Mar 2017
6:08 pm

antoniop

Remove (harmless) inconsistency in local authority service contract (many thanks to Günther Ernst)

Options
    • -3
    • +3
    ./local-procs.tcl
Tuesday 31 Jan 2017
6:51 pm

antoniop

Use "in" idiom instead of lsearch

Options
    • -2
    • +2
    ./authentication-procs.tcl
Monday 12 Sep 2016
1:06 pm

gustafn

- replace deprecated "cc_lookup_email_user ..." by "party::get_by_email -email ..."

Options
    • -2
    • +2
    ./authentication-procs.tcl
    • -3
    • +3
    ./password-procs.tcl
  3. … 1 more file in changeset.
Tuesday 05 Jul 2016
6:39 pm

gustafn

- reduce the dependencies on acs_object_party_privilege_map for PostgreSQL

Options
    • -11
    • +17
    ./authentication-procs.tcl
  2. … 1 more file in changeset.
Saturday 13 Feb 2016
4:22 pm

gustafn

- fix test case

Options
    • -2
    • +3
    ./test/acs-authentication-procs.tcl
Saturday 02 Jan 2016
2:55 pm

gustafn

- prefer empty sql statements over various forms of *SQL*

Options
    • -2
    • +2
    ./authentication-procs.tcl
    • -2
    • +2
    ./local-procs.tcl
Tuesday 20 Oct 2015
10:19 am

gustafn

- no need to use backslash for continuation between curly brackets

- improve readability of code

- modernize tcl

Options
    • -9
    • +20
    ./authentication-procs.tcl
    • -7
    • +15
    ./local-procs.tcl
    • -6
    • +7
    ./password-procs.tcl
    • -7
    • +7
    ./sync-procs.tcl
  5. … 5 more files in changeset.
Thursday 10 Sep 2015
10:21 am

gustafn

- add editor hints to keep spaces/tabs in the furture more consistent

Options
    • -1
    • +7
    ./apm-callback-procs.tcl
    • -1
    • +7
    ./authentication-procs.tcl
    • -1
    • +7
    ./authority-procs.tcl
    • -1
    • +7
    ./driver-procs.tcl
    • -1
    • +7
    ./local-procs.tcl
    • -1
    • +7
    ./password-procs.tcl
    • -1
    • +7
    ./sync-init.tcl
    • -1
    • +7
    ./sync-procs.tcl
    • -1
    • +7
    ./test/acs-authentication-procs.tcl
    • -1
    • +7
    ./test/sync-test-procs.tcl
  11. … 745 more files in changeset.
Tuesday 18 Aug 2015
2:22 pm

gustafn

- remove globals for errorInfo and use namespace qualifiers instead

Options
    • -9
    • +5
    ./authentication-procs.tcl
    • -5
    • +3
    ./authority-procs.tcl
    • -3
    • +2
    ./driver-procs.tcl
    • -9
    • +5
    ./local-procs.tcl
    • -15
    • +8
    ./password-procs.tcl
    • -6
    • +4
    ./sync-procs.tcl
  7. … 10 more files in changeset.
Monday 17 Aug 2015
6:43 pm

gustafn

ad_proc reform:

- use nsf::proc for defining ad_procs, when nsf::proc is available

- nsf::proc is part of the environment of XOTcl2 and provides

an efficient, C-implemented argument parser that can replace

the scripted *__arg_parser of OpenACS.

- The benefits are performance and reduced memory consumption.

* Simple functions (where the calling overhead was a large

part of the execution times can become several times faster

(e.g. db_name is 3x faster, cookie handling is 2x faster),

for functions with much db-activities the percentage will

be less.

* The memory consumption (RSS) of a site like OpenACS.org

is reduced by about 15%.

NEW (with nsf::proc)

::ad_get_cookie x: 10.93 microseconds per iteration

::ad_get_cookie ad_session_id: 21.95 microseconds per iteration

::dt_systime: 24.89 microseconds per iteration

::db_name: 8.70 microseconds per iteration

::db_string dbqd.null.g "select version() from dual": 316.66 microseconds per iteration

::ad_convert_to_html "hello world": 102.29 microseconds per iteration

OLD (without nsf::proc)

::ad_get_cookie x: 19.42 microseconds per iteration

::ad_get_cookie ad_session_id: 30.10 microseconds per iteration

::dt_systime: 27.55 microseconds per iteration

::db_name: 32.28 microseconds per iteration

::db_string dbqd.null.g "select version() from dual": 366.69 microseconds per iteration

::ad_convert_to_html "hello world": 160.51 microseconds per iteration

======================================================================

proc mtime cmd {set c 5000

set t [time [list time $cmd $c]];

regexp {^(-?[0-9]+) +} $t _ mS1;

set ms [expr {$mS1*1.0/$c}];

return "[format %6.2f $ms] microseconds per iteration"

}

set tests {

{::ad_get_cookie x} {::ad_get_cookie ad_session_id} {::dt_systime}

{::db_name} {::db_string dbqd.null.g "select version() from dual"}

{::ad_convert_to_html "hello world"}

}

foreach t $tests {append ::_ $t ": " [mtime $t] \n}

set ::_

======================================================================

Options
    • -18
    • +10
    ./test/acs-authentication-procs.tcl
    • -3
    • +1
    ./test/sync-test-procs.tcl
  3. … 8 more files in changeset.
Tuesday 16 Jun 2015
9:13 am

gustafn

- fix for bug #3251 from Andrew Helsley

Options
    • -2
    • +2
    ./authentication-procs.tcl
    • -2
    • +2
    ./local-procs.tcl
  3. … 5 more files in changeset.
Monday 27 Apr 2015
5:28 pm

victorg

Merging back to HEAD all changes that happened in branch oacs-5-8 between tags: vg-merge-oacs-5-8-from-20141027 and vg-merge-oacs-5-8-from-20150427

Options
    • -3
    • +3
    ./test/acs-authentication-procs.tcl
  2. … 520 more files in changeset.
Monday 16 Feb 2015
12:44 am

gustafn

- fix for bug #3241 (as commited by jwlynch in https://github.com/jwlynch/openacs-core/commit/154c6ecca79c182af73ff875a691a593acede082)

Options
    • -4
    • +4
    ./test/acs-authentication-procs.tcl
Monday 27 Oct 2014
5:38 pm

victorg

Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

Options
    • -0
    • +30
    ./authentication-procs-oracle.xql
    • -0
    • +28
    ./authentication-procs-postgresql.xql
    • -40
    • +126
    ./authentication-procs.tcl
    • -0
    • +15
    ./authentication-procs.xql
    • -8
    • +8
    ./authority-procs.tcl
    • -2
    • +2
    ./local-procs.tcl
    • -10
    • +9
    ./password-procs.tcl
    • -5
    • +8
    ./sync-procs.tcl
    • -19
    • +23
    ./test/acs-authentication-procs.tcl
    • -14
    • +15
    ./test/sync-test-procs.tcl
  11. … 2538 more files in changeset.
Monday 18 Aug 2014
11:18 am

gustafn

- simplify code

Options
    • -3
    • +3
    ./authentication-procs.tcl
    • -2
    • +2
    ./test/acs-authentication-procs.tcl
  3. … 2 more files in changeset.
Tuesday 05 Aug 2014
11:58 am

gustafn

- use util::http::get instead of deprecated proc

Options
    • -2
    • +3
    ./sync-procs.tcl
Thursday 17 Oct 2013
10:51 am

gustafn

- use $::acs::rootdir rather than [acs_root_dir] or [get_server_root]

Options
    • -2
    • +2
    ./authority-procs.tcl
    • -2
    • +2
    ./test/sync-test-procs.tcl
  3. … 12 more files in changeset.
Saturday 12 Oct 2013
4:23 pm

gustafn

- reduce number of remaining "string equal" operations

Options
    • -2
    • +2
    ./authentication-procs.tcl
    • -3
    • +3
    ./sync-procs.tcl
  3. … 2 more files in changeset.
4:05 pm

gustafn

- flatten nested "lindex" structures

- use numeric comparison operator for truth value comparisons

Options
    • -2
    • +2
    ./authentication-procs.tcl
  2. … 1 more file in changeset.
Wednesday 02 Oct 2013
10:56 am

gustafn

- brace expressions to allow for tcl compilation

- use "in" or not in (ni) operator instead of lsearch (for readability and performance)

Options
    • -2
    • +2
    ./test/acs-authentication-procs.tcl
  2. … 10 more files in changeset.
10:29 am

gustafn

- use "in" or not in (ni) operator instead of lsearch (for readability and performance)

Options
    • -3
    • +3
    ./test/acs-authentication-procs.tcl
  2. … 2 more files in changeset.