• last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
improve comments

  1. … 10 more files in changeset.
Removed obsolete @arch-tag

  1. … 29 more files in changeset.
improve spelling

  1. … 8 more files in changeset.
Ehm.. revert previous commit: search would use service contract to get the search form, so we should no assume local-search to be used...

  1. … 4 more files in changeset.
Removal of obsolete user search includes

Rationale:

- no mention to these pages anywhere in upstream packages

- local-search fails files__page_contracts automated test

- weird code in local-search (where is authority_id used to filter users?...)

- acs-admin/users/complex-search is a working replacement and duplicates their intended features

- as for TIP#125, in case complex-search was not reusable, probably a minor rework would do

  1. … 4 more files in changeset.
improve rowcount expressions

  1. … 71 more files in changeset.
Remove superflous parentheses

  1. … 29 more files in changeset.
Fix typos

  1. … 11 more files in changeset.
improve spelling

  1. … 27 more files in changeset.
apm reloading reform (part 2)

adjust version-reload and align version numbers

  1. … 1 more file in changeset.
Fix proc and contract doc elements, so they are properly parsed by apidoc::api_*_documentation.

- @cvs_id -> @cvs-id

- @version -> @cvs-id

- @creation_date -> @creation-date

- @date -> @creation-date

- Different variations of $Id$

- Remove wrong @param entry

- Fix typos

  1. … 366 more files in changeset.
Prefer on-spot api for user-only info

Prefer on-spot api as it is quicker

acs_user::get will not fail anymore with non-existing user

Prefer person-only api to generic user one as is quicker and now properly cached

Prefer on-spot api rather than full-blown acs_user::get

Fix after regression by putting subsite url retrieval... ehm... before its usage

revert to previous version, since "Administration" links were plain wrong (not pointing to SUBSITE/admin but to a constant url)

permission check reform (part 1): provide API for permission cache

  1. … 16 more files in changeset.
Remove leftover xql files

    • -23
    • +0
    ./users/modify-admin-privileges-oracle.xql
    • -23
    • +0
    ./users/modify-admin-privileges-postgresql.xql
Simplify code: set defaults for proc parameters, which are de facto optional, avoiding unnecesary existence checks.

  1. … 2 more files in changeset.
Use api to remove difference between oracle and postgres code and replace array with dict idioms

Remove leftover xql files

remove outdated file, maintained version of the code is in the function apm_build_repository

Make all sql in this page portable and inline

remove unreferences and broken files depending on data model changed more than 10 years ago

Fix regression when checking member state

removing uncalled pages based on non-existing tables and on deprecated calls

Use more api

Exploit cached api to simplify and remove queries. Note that user attributes this page manipulates won't come from the cache to avoid nasty side effects. Reduce divergency between oracle and postgres codebase

    • -13
    • +0
    ./users/member-state-change-oracle.xql
    • -16
    • +0
    ./users/member-state-change-postgresql.xql