OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 19
Total Committers: 146
Last Commit: 10:13
Commits this week: 19
Total Lines of Code (LoC): 7,560,948
Net change in LoC this week: 127

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 23 Jun 2022
10:29 am

gustafn

switched to Bootstrap 5 idioms

Options
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/resources/forms/form-horizontal.adp
    • -2
    • +2
    /openacs-4/packages/openacs-bootstrap5-theme/resources/lists/table-2third.adp
    • -2
    • +2
    /openacs-4/packages/openacs-bootstrap5-theme/resources/lists/table.adp
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/resources/masters/plain-master.adp
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/resources/templates/packages/search/lib/navbar.adp
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/resources/widgets/login.adp
9:39 am

gustafn

Adapted standard form template to Bootstrap5 CSS classes (many thanks to Monika Andergassen)

Options
    • -2
    • +2
    /openacs-4/packages/openacs-bootstrap5-theme/resources/forms/form-horizontal.adp
    • -16
    • +17
    /openacs-4/packages/openacs-bootstrap5-theme/resources/forms/standard.adp
Wednesday 22 Jun 2022
7:49 pm

gustafn

Make page_template foreign key deferrable

This solves the problem of deleting implicitly child-items, which

depend on each other when deleting an item. When deleting an item, the

deletion of child-items in the content repository happens in an

arbitrary order, which could raise fk constraints. Since the deletion

happens in a transaction, the deferring checking of the constraints

helps, since then the constraint violating item is also already

deleted.

There is no update script necessary, since reload alters the

constraint.

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
7:48 pm

gustafn

undo recent change, which is not sufficiently general (and solve the issue by db means, next commit)

Options
    • -4
    • +1
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -57
    • +1
    /openacs-4/packages/xowiki/tcl/xowiki-callback-procs.tcl
3:56 pm

antoniop

Address the cornercase of form pages having their template stored in the same folder: when deleting items containing such a setup, cleanup these formpages first

Addresses a consequence of https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Agustafn%3A20220613165033

Options
    • -1
    • +5
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -1
    • +58
    /openacs-4/packages/xowiki/tcl/xowiki-callback-procs.tcl
10:42 am

antoniop

Constrain captcha width to 100% of its parent's size

Options
    • -1
    • +1
    /openacs-4/packages/acs-templating/tcl/captcha-procs.tcl
Tuesday 21 Jun 2022
7:25 pm

gustafn

Added navbar-dark style to header nav, remove obsolete CSS defs (many thanks to Monika Andergassen)

Options
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/resources/widgets/header-bar.adp
    • -41
    • +16
    /openacs-4/packages/openacs-bootstrap5-theme/www/resources/css/main.css
7:24 pm

gustafn

Make login and logout urls subsite specific (many thanks to Monika Andergassen)

Options
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/resources/widgets/header-bar.adp
    • -2
    • +2
    /openacs-4/packages/openacs-bootstrap5-theme/resources/widgets/login.adp
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/resources/widgets/login.tcl
7:23 pm

gustafn

cleanup of subsite_link and subsite_url variables and reduce to subsite_url (many thanks to Monika Andergassen)

Options
    • -5
    • +2
    /openacs-4/packages/openacs-bootstrap5-theme/resources/masters/plain-master.tcl
    • -5
    • +2
    /openacs-4/packages/openacs-bootstrap5-theme/resources/masters/plain-streaming-head.tcl
    • -1
    • +0
    /openacs-4/packages/openacs-bootstrap5-theme/resources/masters/tabbed-master-turquois.adp
    • -3
    • +0
    /openacs-4/packages/openacs-bootstrap5-theme/resources/masters/tabbed-master-turquois.tcl
    • -1
    • +0
    /openacs-4/packages/openacs-bootstrap5-theme/resources/masters/tabbed-streaming-head-turquois.adp
    • -4
    • +0
    /openacs-4/packages/openacs-bootstrap5-theme/resources/masters/tabbed-streaming-head-turquois.tcl
    • -4
    • +0
    /openacs-4/packages/openacs-bootstrap5-theme/resources/masters/tabbed-streaming-head.tcl
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/resources/templates/packages/acs-subsite/lib/login.tcl
    • -2
    • +2
    /openacs-4/packages/openacs-bootstrap5-theme/resources/widgets/header-bar.adp
7:21 pm

gustafn

adapt markup for navbar and dropdown elements to bootstrap5 notation (many thanks to Monika Andergassen)

Options
    • -7
    • +7
    /openacs-4/packages/openacs-bootstrap5-theme/resources/widgets/login.adp
    • -3
    • +3
    /openacs-4/packages/openacs-bootstrap5-theme/resources/widgets/navigation.adp
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/resources/widgets/navigation.tcl
    • -0
    • +13
    /openacs-4/packages/openacs-bootstrap5-theme/www/resources/css/main.css
12:50 pm

gustafn

Added dynamic cluster configuration checking

- handle cases, where not all cluster nodes are available at startup

time (this is a problem for docker, since the IP addresses will not

be available as well)

- handle dynamic changing of configuration variables

- refactored code

- new methods "acs::Cluster register_nodes" and

"acs::Cluster refresh_blueprint" (called regulary via scheduled

procedure, running every minute)

Options
    • -188
    • +1
    /openacs-4/packages/acs-tcl/tcl/acs-cache-procs.tcl
    • -22
    • +8
    /openacs-4/packages/acs-tcl/tcl/cluster-init.tcl
    • -0
    • +294
    /openacs-4/packages/acs-tcl/tcl/cluster-procs.tcl
12:50 pm

gustafn

file cluster-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/cluster-procs.tcl
Sunday 19 Jun 2022
5:33 pm

gustafn

remove traces of md5::md5, since ns_md5 is emulated also for AOLserver

Options
    • -6
    • +1
    /openacs-4/packages/openacs-bootstrap3-theme/resources/widgets/login.tcl
    • -6
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/resources/widgets/login.tcl
    • -7
    • +2
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
Wednesday 15 Jun 2022
8:54 pm

gustafn

whitespace changes

Options
    • -8
    • +8
    /openacs-4/packages/acs-templating/tcl/parse-procs.tcl
8:48 pm

gustafn

reduce useless warnings for template::adp_parse_tags

The problem was that template::adp_compile_chunk produces no output, when the parsed chunk contains only whitespace,

causing an error message in this case. The changed method shortcuts the behavior.

Options
    • -4
    • +7
    /openacs-4/packages/acs-templating/tcl/parse-procs.tcl
Tuesday 14 Jun 2022
7:59 pm

gustafn

Support the usage of HTTP locations in kernel parameter ClusterPeerIP

The change extends the values specified in ClusterPeerIP in two respects

- one can now specify the protocol (defaults to http)

- while ClusterPeerIP required an IP address, it is now possible to specify an DNS name

The DNS name is resolved for the time being at the start time of the OpenACS instance.

Options
    • -4
    • +4
    /openacs-4/packages/acs-tcl/tcl/acs-cache-procs.tcl
    • -0
    • +1
    /openacs-4/packages/acs-tcl/tcl/cluster-init.tcl
    • -9
    • +22
    /openacs-4/packages/acs-tcl/tcl/server-cluster-procs.tcl
Monday 13 Jun 2022
6:50 pm

gustafn

Drop "ON DELETE CASCADE" on page_template, since this might lead to crippled entries in the database.

When someone delets via operations in the database a form, protentially existing

form pages refering to this item might be left in a crippled state.

The cascade operation deletes the revision (xowiki_page_instance), but leaves

the half-crippled item. The problem does not exist over the web interface,

since it does not allow such items to be deleted while form pages exist.

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
    • -1
    • +19
    /openacs-4/packages/xowiki/tcl/upgrade/upgrade.tcl
6:45 pm

gustafn

Add support for menu-entries, where simply a "-link" is provided

Options
    • -1
    • +3
    /openacs-4/packages/xowiki/tcl/menu-procs.tcl
5:30 pm

antoniop

Prefer util::which to retrieve the unzip executable

Options
    • -3
    • +3
    /openacs-4/packages/search/tcl/search-convert-procs.tcl
4:11 pm

antoniop

Complain in the logfile whenever the insertion of the null character is attempted in the syndication table

Options
    • -3
    • +14
    /openacs-4/packages/search/tcl/syndicate-procs.tcl
3:45 pm

antoniop

Implement a conversion from MS pptx to plaintext:

first slides are extracted from the presentation, then everything that is not the content of a text tag is removed.

Options
    • -1
    • +35
    /openacs-4/packages/search/tcl/search-convert-procs.tcl
Wednesday 08 Jun 2022
4:08 pm

antoniop

More targeted sanityzing only on the variables that have a chance to contain the null character

Options
    • -2
    • +8
    /openacs-4/packages/search/tcl/syndicate-procs.tcl
4:02 pm

antoniop

Translate potential null characters in the syndication content with the empty string, so that we do not risk to try (and fail) to insert them in the database

Options
    • -2
    • +2
    /openacs-4/packages/search/tcl/syndicate-procs.tcl
Tuesday 07 Jun 2022
10:18 am

gustafn

flipping of session_id apparently works without keeping track of the old session_id, so there is no need of keeping track of it

Options
    • -7
    • +3
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
Friday 03 Jun 2022
4:46 pm

trenner

provide stub for wf-specific in none shared workflows

Options
    • -0
    • +4
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
Thursday 02 Jun 2022
12:00 pm

gustafn

Provide a fix for "dom parse -html ..." for adp tags.

"dom parse -html" has two problems with ADP tags like "<adp:icon ...>":

a) If the tag name contains a colon or underscore, the tag is

treated like plain text, i.e. "<" and ">" are converted into

HTML entities.

b) These tags have to be closed "<adp:icon ...>" is invalid.

Several existomg ADP tags have not closing tag.

Therefore, we resolve the ADP tags before parsing the text by

tdom. There should be some future framework support to do this in

general, but until we have this, resolve this problem here locally.

Options
    • -4
    • +17
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
11:28 am

gustafn

improve message key

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -1
    • +1
    /openacs-4/packages/xowiki/catalog/xowiki.de_DE.ISO-8859-1.xml
11:25 am

gustafn

New method "marshall_all_to_file"

This method is similar to "marshall_all", but exports the objects

directly to a file. This can save memory when exporting a large

collection of objects, since the plain "marshall_all" appends to

string, which can get very large, especially due to Tcl's

"double the size when space is needed" policy during "append"

operations.

Options
    • -1
    • +31
    /openacs-4/packages/xowiki/tcl/import-procs.tcl
11:18 am

gustafn

New feature for shared workflow definitions: define workflow specific methods

Workflows support since a long time "object-specific" code, which is code

to be executed, when a workflow instance is initialized. Now, in symmetry

to this, one can define "wf-specific" code (e.g. registering methods to

be called directly on the workflow object.

Similar to the call of ":object-specific {...some code...}", one define

additionally ":wf-specific {...some code...}". This comes handy

when e.g. definiing methods directly executed on workflowss, such as e.g.

".../someworkflow.wf?m=summary".

The methods are defined on the WorkflowContainer class, which is only available

on for shared workflows.

Options
    • -15
    • +92
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
Sunday 29 May 2022
9:16 pm

gustafn

improved comments

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl