• last updated 15 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
improve acs-admin//apm/packages-install

- use usual user interaction for select/unselect all

- add proper handling of no upgrades

- improve HTML markup

- improve code orthogonality

Implement a new type of "Moderator" notification type for forums

This notification will be triggered also by unapproved messages. The UI will show the subscription link only to forum moderators, using a different color (customizable via css, vanilla color is red). Message content will always be hidden for such notifications, so user will need to have access to new message.

    • -2
    • +2
    /openacs-4/packages/forums/forums.info
    • -1
    • +8
    /openacs-4/packages/forums/www/message-view.adp
    • -1
    • +8
    /openacs-4/packages/forums/www/message-view.tcl
Provide an include flag to hide the list of subscribers

move ad_get_host_node_map and security-locations-host-names from db_cache_pool to partitioned cache

    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
no need to provide separate hash method, which hinders actually for the hashkey partitioned cache

Provide a css class hook to customize styling according to notification type

fix for issue #3437, extend regression test

move code pieces around to centralize concerns

improve wording

Make clear where paragraph ends

Step in the direction of implementing a new kind of "moderator notification": move current notification behavior in a private api, remove dependency on message approval in message::new (also avoids a query)

Fix typo

Comment unused computations

Small refactoring

address issue #3423: Move is_package_root_folder up in class hierarchy to CrItem

follow user wish

    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -12
    • +13
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
remove legacy code

    • -123
    • +75
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
use {} instead of [list] command

improve spelling

white-space changes

add as well support for schema name to util__table_column_exists and util__view_exists

address issue #3436: support for schema name in util__table_exists

TODO: Oracle version is missing

file upgrade-5.10.0d29-5.10.0d29.sql was initially added on branch oacs-5-10.

fix for issue #3438

make monitor URLs easier configurable

don't use request-blocking on embedded items

- added name validator for site-wide pages

- updated site-wide pages

widen field width for numeric values

fix CSS formatting with bootstrap for validation errors

whitespace changes

fix for issue #3440: problem with SQL queries in db_transactions after some db_multirows

the was a problem with with db_handle management in complex setups,

where a db_multirow iterating over more than one tuple causes

some other queries in the transaction to fail. See as well

the new test case added to the regression test.

Many thanks to Keith Paskett for reporting and the good test case!

https://openacs.org/bugtracker/openacs/bug?format=table&bug_number=3440

    • -131
    • +152
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
file db-proc-test-procs.tcl was initially added on branch oacs-5-10.