Activity OpenACS/

6:06 pm

gernst

Bring the implementation of the "Search" operation of the "auth_search" service contract in line with the operation's definition by correcting the returned value ("username" instead of "user_id") and restricting the search to the local authority.

- -8
- +10
/openacs-4/packages/acs-authentication/tcl/local-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/local-procs.tcl

11:05 am

antoniop

Fix typo

- -2
- +2
/openacs-4/packages/forums/tcl/forums-callback-procs.tcl
- History
- Source
- Diff
/openacs-4/.../forums-callback-procs.tcl

4:03 pm

antoniop

Handle correctly the indexing of moderated messages in fulltext search:

so far the fulltext search would also include unapproved messages and threads. With this reform we address this by:

- making sure unapproved threads are deleted from the index

- making sure new threads are added to the index only when the are approved

- making sure we unindex or reindex a thread whenever the approval state changes

- not fetching unapproved messages in the datasource callback, hence excluding them from the index

Note that Oracle has not been targeted by the reform. However, the situation improves for Oracle as well, because we won't render unmoderated messages in the datasource callback anymore.

- -2
- +2
/openacs-4/packages/forums/forums.info
- History
- Source
- Diff
/openacs-4/packages/forums/forums.info
- -6
- +59
/openacs-4/packages/forums/sql/postgresql/forums-sc-create.sql
- History
- Source
- Diff
/openacs-4/packages/.../forums-sc-create.sql
- -0
- +124
/openacs-4/packages/forums/sql/postgresql/upgrade/upgrade-1.4.0d3-1.4.0d4.sql
- History
- Source
- Diff
/openacs-4/.../upgrade-1.4.0d3-1.4.0d4.sql
- -1
- +4
/openacs-4/packages/forums/tcl/forums-callback-procs.tcl
- History
- Source
- Diff
/openacs-4/.../forums-callback-procs.tcl

4:03 pm

antoniop

More
MAIN:antoniop:20210429140342
deleted 1 file
MAIN

file upgrade-1.4.0d3-1.4.0d4.sql was initially added on branch oacs-5-10.

- -0
- +0
/openacs-4/packages/forums/sql/postgresql/upgrade/upgrade-1.4.0d3-1.4.0d4.sql
- History
- Source
/openacs-4/.../upgrade-1.4.0d3-1.4.0d4.sql

12:14 pm

gustafn

improve spelling

- -1
- +1
/openacs-4/packages/proctoring-support/tcl/proctoring-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../proctoring-procs.tcl
- -3
- +3
/openacs-4/packages/proctoring-support/www/resources/proctoring.js
- History
- Source
- Diff
/openacs-4/packages/.../proctoring.js

9:14 am

antoniop

Streamline idiom: we are only interested in the user ids

- -9
- +11
/openacs-4/packages/acs-authentication/tcl/local-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/local-procs.tcl
- -14
- +0
/openacs-4/packages/acs-authentication/tcl/local-procs.xql
- History
- Source
- Diff
/openacs-4/packages/.../tcl/local-procs.xql

7:00 pm

antoniop

Fix typo in comment

- -2
- +2
/openacs-4/packages/notifications/tcl/notification-email-procs.tcl
- History
- Source
- Diff
/openacs-4/.../notification-email-procs.tcl

6:59 pm

antoniop

When sending a notification on behalf of a person, if the system is not configured to process replies to notification, do not set the reply-to address to anything different than the sender

- -4
- +17
/openacs-4/packages/notifications/tcl/notification-email-procs.tcl
- History
- Source
- Diff
/openacs-4/.../notification-email-procs.tcl

6:20 pm

antoniop

Prefer api to hardcoded urls

- -2
- +7
/openacs-4/packages/news/lib/item.tcl
- History
- Source
- Diff
/openacs-4/packages/news/lib/item.tcl

6:00 pm

antoniop

Address long standing todo: view news_items_live_or_submitted is defined for oracle exactly as the "workaround query" was doing, that is, from cr_revisions.content column

- -13
- +0
/openacs-4/packages/news/lib/item-oracle.xql
- History
- Source
- Diff
/openacs-4/packages/.../lib/item-oracle.xql
- -15
- +1
/openacs-4/packages/news/lib/item.tcl
- History
- Source
- Diff
/openacs-4/packages/news/lib/item.tcl

5:46 pm

antoniop

Whitespace changes

- -25
- +1
/openacs-4/packages/news/lib/item.tcl
- History
- Source
- Diff
/openacs-4/packages/news/lib/item.tcl

3:57 pm

antoniop

Don't display an empty list element when comment_url is empty

- -1
- +3
/openacs-4/packages/news/lib/item.adp
- History
- Source
- Diff
/openacs-4/packages/news/lib/item.adp

3:55 pm

antoniop

Whitespace cleanup

- -6
- +6
/openacs-4/packages/news/lib/item.tcl
- History
- Source
- Diff
/openacs-4/packages/news/lib/item.tcl

4:28 pm

antoniop

Now that the proctoring display UI has been ported, notify by default new proctoring events via websockets

- -2
- +0
/openacs-4/packages/proctoring-support/lib/proctoring-upload.tcl
- History
- Source
- Diff
/openacs-4/packages/.../proctoring-upload.tcl
- -1
- +2
/openacs-4/packages/proctoring-support/www/upload.adp
- History
- Source
- Diff
/openacs-4/packages/.../www/upload.adp
- -0
- +1
/openacs-4/packages/proctoring-support/www/upload.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/upload.tcl

12:30 pm

antoniop

Do not handle 400 responses in any special way: cases found in practice were always the result of a client-side timeout

- -16
- +3
/openacs-4/packages/proctoring-support/www/resources/proctored-page.js
- History
- Source
- Diff
/openacs-4/packages/.../proctored-page.js

6:18 pm

antoniop

Hide timing information from the user

- -1
- +1
/openacs-4/packages/proctoring-support/www/resources/proctored-page.js
- History
- Source
- Diff
/openacs-4/packages/.../proctored-page.js

6:15 pm

antoniop

Streamline proctoring upload:

- do not hardcode a timeout, requests will either complete or eventually fail

- use a single event handler at the end of the request to decide if and how to reschedule the upload. This prevents the possibility that the same error event triggers multiple uploads via different handlers

- improve documentation