OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 22
Total Committers: 146
Last Commit: 26 Nov
Commits this week: 22
Total Lines of Code (LoC): 7,560,945
Net change in LoC this week: 124

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 20 Sep 2018
3:03 pm

antoniop

Unquote single quote from JSON before appending messages to chat

Options
    • -2
    • +3
    /openacs-4/packages/xowiki/www/ajax/scripted-streaming-chat.js
    • -2
    • +3
    /openacs-4/packages/xowiki/www/ajax/streaming-chat.js
Wednesday 19 Sep 2018
7:11 pm

antoniop

Fix quoting of single quotes in JSON

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/chat-procs.tcl
7:01 pm

antoniop

Remove leftover alert

Options
    • -2
    • +1
    /openacs-4/packages/xowiki/www/ajax/streaming-chat.js
6:19 pm

antoniop

Avoid javascript eval idiom as CSP will refuse to execute when unsafe-eval is disabled

This requires moving to a more approprate JSON parser... which is also pickier regarding single quotes, so I had to rework JSON encoding to please it.

Options
    • -4
    • +4
    /openacs-4/packages/xotcl-core/tcl/chat-procs.tcl
    • -2
    • +3
    /openacs-4/packages/xowiki/www/ajax/streaming-chat.js
3:32 pm

antoniop

Make ad_sanitize_html not hardly dependant on a connection being there (thanks to Markus moser for the report)

Also, update documentation and make idioms less awkward.

(this passes automated tests)

Options
    • -33
    • +45
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
3:22 pm

hectorr

Add editor hints + Whitespace changes

Options
    • -34
    • +40
    /openacs-4/packages/chat/tcl/chat-ajax-procs.tcl
    • -1
    • +7
    /openacs-4/packages/chat/tcl/chat-init.tcl
    • -1
    • +7
    /openacs-4/packages/chat/tcl/chat-procs.tcl
9:05 am

gustafn

Make util_current_location robust such it does not raise an exception when not connected. In these cases, the configured ad_url is returned. This is not perfect either, since it would not work with host-node mapped subsites, and maybe, there are cases, where one wants just information based on the actual connection. so, maybe, one should provide either a higher level API and/or parameterize util_current_location in the future.

Options
    • -3
    • +14
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
3:02 am

gustafn

extend list of embedded content types

Options
    • -3
    • +3
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
2:55 am

gustafn

improve comments

Options
    • -8
    • +8
    /openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl
    • -7
    • +7
    /openacs-4/packages/acs-tcl/tcl/parameter-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
    • -6
    • +6
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
    • -3
    • +4
    /openacs-4/packages/acs-tcl/tcl/site-node-apm-integration-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
    • -11
    • +11
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/xml-0-sgml-procs.tcl
    • -5
    • +5
    /openacs-4/packages/acs-admin/www/test/signed-cookies-test.tcl
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/www/package-view.tcl
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
2:38 am

gustafn

improve capitalization and wording in comments

Options
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/date-procs.tcl
    • -11
    • +11
    /openacs-4/packages/acs-templating/tcl/head-procs.tcl
    • -13
    • +16
    /openacs-4/packages/acs-templating/tcl/list-procs.tcl
    • -3
    • +2
    /openacs-4/packages/acs-templating/tcl/wizard-procs.tcl
    • -4
    • +4
    /openacs-4/packages/acs-templating/www/doc/demo/list6/index.tcl
    • -2
    • +2
    /openacs-4/packages/acs-templating/www/scripts/xinha/attach-file.tcl
    • -2
    • +2
    /openacs-4/packages/acs-templating/www/scripts/xinha/attach-image.tcl
1:39 am

hectorr

Fix typo

Options
    • -1
    • +1
    /openacs-4/packages/forums/www/load-message-content.tcl
1:38 am

hectorr

Whitespace changes

Options
    • -18
    • +17
    /openacs-4/packages/acs-subsite/www/admin/site-map/allow-for-view.tcl
    • -10
    • +6
    /openacs-4/packages/assessment/tcl/as-action-proc.tcl
    • -16
    • +14
    /openacs-4/packages/assessment/www/admin/asm-action-new.tcl
    • -62
    • +17
    /openacs-4/packages/assessment/www/admin/set-reg-assessment.tcl
    • -2
    • +1
    /openacs-4/packages/forums/www/load-message-content.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/generic-procs.tcl
    • -4
    • +4
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
1:24 am

hectorr

Fix typos

Options
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -4
    • +4
    /openacs-4/packages/acs-subsite/www/admin/site-map/allow-for-view.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/generic-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
Tuesday 18 Sep 2018
8:50 pm

hectorr

Whitespace changes

Options
    • -1
    • +1
    /openacs-4/packages/acs-lang/www/admin/message-conflict-revert.tcl
    • -50
    • +49
    /openacs-4/packages/categories/tcl/category-trees-procs.tcl
8:28 pm

hectorr

Fix typos

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/content-item-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-lang/www/admin/message-conflict-revert.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/widgets-procs.tcl
    • -3
    • +3
    /openacs-4/packages/categories/tcl/categories-procs.tcl
    • -3
    • +3
    /openacs-4/packages/categories/tcl/category-trees-procs.tcl
7:27 pm

gernst

dotlrn cache reform: move caching from util_memoize into three seperate caches to reduce stress on util_memoize.

These caches are:

- ::dotlrn::dotlrn_cache

Default general purpose cache for dotlrn-wide value (e.g. available applets, etc)

- ::dotlrn::dotlrn_user_cache

Partitioned cache for values specific to a user (e.g. personal_portal_id, theme_id, etc)

- ::dotlrn::dotlrn_community_cache

Partitioned cache for values specific to a community (e.g name, roles, portal_id, etc)

Options
    • -2
    • +2
    /openacs-4/packages/dotlrn/dotlrn.info
    • -2
    • +6
    /openacs-4/packages/dotlrn/tcl/applets-procs.tcl
    • -63
    • +100
    /openacs-4/packages/dotlrn/tcl/community-procs.tcl
    • -2
    • +9
    /openacs-4/packages/dotlrn/tcl/community-procs.xql
    • -3
    • +32
    /openacs-4/packages/dotlrn/tcl/dotlrn-init.tcl
    • -7
    • +22
    /openacs-4/packages/dotlrn/tcl/dotlrn-procs.tcl
    • -0
    • +8
    /openacs-4/packages/dotlrn/tcl/dotlrn-procs.xql
    • -2
    • +2
    /openacs-4/packages/dotlrn/tcl/dotlrn-security-procs.tcl
    • -2
    • +4
    /openacs-4/packages/dotlrn/tcl/user-type-procs.tcl
    • -3
    • +1
    /openacs-4/packages/dotlrn/www/member-add-3.tcl
    • -4
    • +1
    /openacs-4/packages/dotlrn/www/spam-policy-toggle.tcl
    • -2
    • +2
    /openacs-4/packages/dotlrn/www/admin/add-edit-site-template.tcl
5:27 pm

hectorr

Trailing space cleanup

Options
    • -23
    • +23
    /openacs-4/packages/acs-tcl/tcl/whos-online-procs.tcl
5:21 pm

hectorr

Whitespace changes

Options
    • -206
    • +206
    /openacs-4/packages/acs-tcl/tcl/widgets-procs.tcl
5:19 pm

hectorr

Fix typos in proc doc

Options
    • -5
    • +5
    /openacs-4/packages/acs-tcl/tcl/widgets-procs.tcl
    • -4
    • +4
    /openacs-4/packages/acs-tcl/tcl/whos-online-procs.tcl
5:08 pm

antoniop

Better separate data from formatting

Options
    • -1
    • +6
    /openacs-4/packages/chat/www/ajax/chat.adp
    • -9
    • +1
    /openacs-4/packages/chat/www/ajax/chat.tcl
5:01 pm

hectorr

Provide tests for public procs: min and max

Options
    • -0
    • +25
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
4:46 pm

antoniop

Normalize indentation

Options
    • -19
    • +19
    /openacs-4/packages/chat/tcl/chat-ajax-procs.tcl
4:44 pm

antoniop

Decouple a bit formatting from data

Options
    • -0
    • +48
    /openacs-4/packages/chat/www/ajax/chat.adp
    • -26
    • +6
    /openacs-4/packages/chat/www/ajax/chat.tcl
4:42 pm

antoniop

Give templating a chance

move all hardcoded styling to the adp template, which might be styled by the theme. Also, biring some order in the login proc, e.g. don't open and read a file to include a javascript all the time.

Options
    • -64
    • +59
    /openacs-4/packages/chat/tcl/chat-ajax-procs.tcl
    • -0
    • +17
    /openacs-4/packages/chat/www/ajax-chat-script.adp
4:27 pm

hectorr

Provide tests for public procs: util_escape_quotes_for_csv

Options
    • -0
    • +17
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
4:16 pm

hectorr

Provide tests for public procs: util_commify_number

Options
    • -1
    • +30
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
3:42 pm

hectorr

Whitespace changes

Options
    • -134
    • +134
    /openacs-4/packages/faq-portlet/tcl/test/faq-portlet-procs.tcl
    • -177
    • +176
    /openacs-4/packages/faq-portlet/tcl/test/tclwebtest-procs.tcl
3:38 pm

hectorr

Fix typos

Options
    • -2
    • +2
    /openacs-4/packages/faq-portlet/tcl/test/faq-portlet-procs.tcl
    • -9
    • +9
    /openacs-4/packages/faq-portlet/tcl/test/tclwebtest-procs.tcl
3:35 pm

antoniop

Modernize XoTcl idioms

Options
    • -5
    • +5
    /openacs-4/packages/chat/tcl/chat-ajax-procs.tcl
Monday 17 Sep 2018
8:30 pm

hectorr

Refactor test case for util_absolute_path_p

Options
    • -6
    • +14
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl