OpenACS / openacs-4 / packages

xotcl-core

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 25 Dec
Commits this week: 0
Total Lines of Code (LoC): 20,316
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 22 Oct
10:48 am

gustafn

improved source code documentation

Options
    • -1
    • +4
    ./www/show-object.tcl
10:46 am

gustafn

make sure, the provided user_id is an integer

Options
    • -2
    • +2
    ./tcl/policy-procs.tcl
Thursday 17 Oct
3:01 pm

antoniop

Fix typo

Options
    • -2
    • +1
    ./www/show-object.tcl
Wednesday 16 Oct
11:21 am

gustafn

Added code to skip suspicious looking query variables

On openacs.org, we are experiencing numerous requests with

multiply very long and strange query variables like in the example

below. So far, it is not clear, whether these requests are the

consequence of a double encoding or a deliberate attack. Many (most)

of the requests contain the query variable names containing the

(decoded) pattern "*amp;*".

This is a relatively new phenomenon. I cannot exclude that this is a

bug introduced lately in OpenACS, or a bug in an external bot, or

whatever. The problem with these query variables is that OpenACS

propagates these further, e.g., when updating query variables in

ad_dimensional, via export_vars, or return_urls.

Since OpenACS never uses these query-variables, these can be safely

skipped, without loosing functionality in OpenACS. It is possible to

construct examples, where skipping such variables can change the

semantics. Therefore, the change introduces a single function

util::suspicious_query_variable where in case of problems, the

skipping feature can be deactivated.

GET /api-doc/proc-browse?amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3borderby=name&type=All&amp%3btype=All&amp%3bamp%3btype=All&amp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3borderby=name&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=Private&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3borderby=name&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All HTTP/1.1" 200 62378 "" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/605.1.15 (KHTML, like Gecko; compatible; FriendlyCrawler/1.0) Chrome/120.0.6099.216 Safari/605.1.15" "1729029614.331581 0.109805 0.000434 0.004026 0.215927

Options
    • -3
    • +3
    ./xotcl-core.info
    • -6
    • +12
    ./tcl/context-procs.tcl
    • -1
    • +11
    ./www/show-object.tcl
  4. … 4 more files in changeset.
Tuesday 08 Oct
5:04 pm

antoniop

Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -1
    • +1
    ./tcl/01-debug-procs.tcl
    • -2
    • +2
    ./tcl/context-procs.tcl
    • -3
    • +3
    ./tcl/cr-procs.tcl
    • -2
    • +2
    ./www/show-object.tcl
  5. … 4 more files in changeset.
Tuesday 01 Oct
2:40 pm

gustafn

tcl9 change: "... -encoding binary ..." not valid in tcl9

Options
    • -2
    • +2
    ./tcl/utilities-procs.tcl
Wednesday 11 Sep
8:11 am

gustafn

merge with missing files

Options
    • -0
    • +0
    ./lib/revisions.tcl
    • -0
    • +0
    ./tcl/03-doc-procs.tcl
    • -0
    • +0
    ./tcl/04-library-procs.tcl
    • -0
    • +0
    ./tcl/05-db-procs.tcl
    • -0
    • +0
    ./tcl/06-package-procs.tcl
    • -0
    • +0
    ./tcl/10-recreation-procs.tcl
    • -0
    • +0
    ./tcl/20-Ordered-Composite-procs.tcl
    • -0
    • +0
    ./tcl/30-widget-procs.tcl
    • -0
    • +0
    ./tcl/40-thread-mod-procs.tcl
    • -0
    • +0
    ./tcl/bgdelivery-procs.tcl
    • -0
    • +0
    ./tcl/cluster-procs.tcl
    • -0
    • +0
    ./tcl/context-procs.tcl
    • -0
    • +0
    ./tcl/cr-procs.tcl
    • -0
    • +0
    ./tcl/doc-procs.tcl
    • -0
    • +0
    ./tcl/generic-procs.tcl
  16. … 1450 more files in changeset.
Tuesday 03 Sep
5:37 pm

gustafn

merge from oacs-5-10

Options
    • -29
    • +30
    ./xotcl-core.info
    • -2
    • +12
    ./catalog/xotcl-core.de_DE.ISO-8859-1.xml
    • -2
    • +12
    ./catalog/xotcl-core.en_US.ISO-8859-1.xml
    • -0
    • +10
    ./catalog/xotcl-core.es_ES.ISO-8859-1.xml
    • -0
    • +10
    ./catalog/xotcl-core.it_IT.ISO-8859-1.xml
    • -0
    • +21
    ./catalog/xotcl-core.tr_TR.utf-8.xml
    • -3
    • +3
    ./lib/revisions-postgresql.xql
    • -19
    • +11
    ./lib/revisions.tcl
    • -125
    • +302
    ./tcl/01-debug-procs.tcl
    • -62
    • +92
    ./tcl/03-doc-procs.tcl
    • -12
    • +14
    ./tcl/04-library-procs.tcl
    • -312
    • +701
    ./tcl/05-db-procs.tcl
    • -114
    • +694
    ./tcl/06-package-procs.tcl
    • -119
    • +243
    ./tcl/06-param-procs.tcl
    • -36
    • +36
    ./tcl/10-recreation-procs.tcl
  16. … 8085 more files in changeset.
Monday 02 Sep
2:54 pm

gustafn

bumped version number from development version to release version

Options
    • -10
    • +10
    ./xotcl-core.info
  2. … 93 more files in changeset.
Friday 30 Aug
9:47 am

gustafn

improved spelling

Options
    • -2
    • +2
    ./tcl/06-package-procs.tcl
  2. … 15 more files in changeset.
Tuesday 27 Aug
12:06 pm

gustafn

whitespace changes

Options
    • -3
    • +3
    ./tcl/03-doc-procs.tcl
    • -4
    • +4
    ./tcl/06-package-procs.tcl
    • -3
    • +3
    ./tcl/06-param-procs.tcl
    • -3
    • +3
    ./tcl/bgdelivery-procs.tcl
    • -2
    • +2
    ./tcl/cluster-procs.tcl
    • -2
    • +2
    ./tcl/context-procs.tcl
    • -4
    • +4
    ./tcl/generic-procs.tcl
    • -2
    • +2
    ./tcl/test/context-test-procs.tcl
    • -1
    • +1
    ./tcl/test/xotcl-core-db-tutorial-procs.tcl
    • -2
    • +2
    ./www/show-class-graph.tcl
  11. … 6 more files in changeset.
Monday 26 Aug
4:24 pm

gustafn

Removed dependency on file-storage

- there was a "silent" dependency of xotcl core to the file-storage, since it

used many message keys from there. User-experience of xo* was bad when

no file-storage was installed.

- The message keys went to acs-content-repository and acs-kernel

- bumped version to 5.10.1b6

Options
    • -4
    • +4
    ./xotcl-core.info
    • -8
    • +8
    ./lib/revisions.tcl
    • -6
    • +6
    ./tcl/cr-procs.tcl
Sunday 25 Aug
7:05 pm

gustafn

never cache package_id, when acs_admin::require_site_wide_package returns empty.

Options
    • -7
    • +14
    ./tcl/06-package-procs.tcl
Tuesday 20 Aug
7:50 pm

gustafn

reduce verbosity

Options
    • -2
    • +2
    ./tcl/cr-procs.tcl
11:28 am

gustafn

moved functionality to automated testing

Options
    • -28
    • +0
    ./tcl/test/xotcl-test-procs.tcl
    • -23
    • +0
    ./tcl/test/zz-final-procs.tcl
Monday 19 Aug
7:07 pm

gustafn

Removed memory leaks in the regression test

- new function ::xo::aa_check_leftovers to detect leaks a soon as possible

- made ::xo::stats better reusable by returning a dict

- extended regression test

- bumped xotcl-core to 5.10.1b5

Options
    • -2
    • +2
    ./xotcl-core.info
    • -6
    • +7
    ./tcl/01-debug-procs.tcl
    • -23
    • +39
    ./tcl/test/xotcl-test-procs.tcl
    • -0
    • +23
    ./tcl/test/zz-final-procs.tcl
7:07 pm

gustafn

file zz-final-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/test/zz-final-procs.tcl
4:40 pm

gustafn

Removed warning during startup

Removed reason for protentially confusing warning during startup

Warning: nsf: method <::nx::Class> <-per-object> <init> does not exist

Options
    • -3
    • +3
    ./tcl/03-doc-procs.tcl
Friday 16 Aug
3:55 pm

gustafn

prefer recommended path over deprecated path

Options
    • -2
    • +2
    ./tcl/06-package-procs.tcl
Wednesday 07 Aug
3:51 pm

gustafn

require login for version numbers, since this reveals internal information

Options
    • -0
    • +2
    ./www/version-numbers.tcl
Monday 15 Jul
1:41 pm

gustafn

improved spelling

Options
    • -2
    • +2
    ./tcl/05-db-procs.tcl
    • -2
    • +2
    ./tcl/bgdelivery-procs.tcl
Friday 05 Apr
10:39 am

gustafn

improved spelling

Options
    • -3
    • +3
    ./tcl/03-doc-procs.tcl
    • -3
    • +3
    ./tcl/http-client-procs.tcl
  3. … 2 more files in changeset.
10:28 am

gustafn

Improved readability of configuration parameter "parameterSecret"

- Switched to camelCase for better readabilty and uniformity

- NaviServer configuration parameters are case insensitive, so no danger for backward compatibility

Options
    • -1
    • +1
    ./tcl/01-debug-procs.tcl
  2. … 5 more files in changeset.
Wednesday 06 Mar
7:02 pm

gustafn

reduce verbosity

Options
    • -4
    • +4
    ./tcl/05-db-procs.tcl
Thursday 29 Feb
1:04 pm

gernst

Quote error message to better protect against XSS attacks

Options
    • -2
    • +2
    ./tcl/context-procs.tcl
12:04 pm

gustafn

Added parameter to define a default dbn to a database connection

By this change, one can now define a default dbn at the creation time

of a database connection object. Before, it was necessary to pass

the "-dbn" value to every single command. The parameter can still be

used for particular queries as before to overrule the default.

Example for defining a connection context to a pool named "legacy"

using the PostgreSQL database interface

::xo::db::DB-postgresql create ::xo::dc1 -dialect postgresql -dbn legacy

lappend _ [::xo::dc1 get_value . {select count(*) from acs_objects}]

lappend _ [::xo::dc get_value . {select count(*) from acs_objects}]

#> 660 51606

Options
    • -10
    • +15
    ./tcl/05-db-procs.tcl
Friday 23 Feb
1:58 pm

antoniop

Fix method signature

Options
    • -1
    • +1
    ./tcl/01-debug-procs.tcl
Thursday 15 Feb
6:36 pm

gustafn

Fixed implementation of value checker dbtext

The old version was not persistent in the blueprints.

Furthermore, the new version is more than 2x faster by

avoiding regular expressions.

Options
    • -8
    • +9
    ./tcl/01-debug-procs.tcl
1:27 pm

antoniop

Provide facilities to validate against invalid SQL strings

We introduce a new page contract filter and nsf validator called "dbtext". They implement enforcing of a value to be useable in an SQL query. Currently, this means that the value should not contain the NUL character, but the definition may change in the future or become database-specific.

The html contract filter has also be extended to reject the NUL character.

The test suite has been updated/extended to reflect the changes.

Options
    • -0
    • +18
    ./tcl/01-debug-procs.tcl
  2. … 2 more files in changeset.
Saturday 03 Feb
9:29 am

gustafn

reduced verbosity

Options
    • -2
    • +2
    ./tcl/cr-procs.tcl