OpenACS / openacs-4 / packages

chat

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 14 Nov
Commits this week: 0
Total Lines of Code (LoC): 7,173
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 17 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 06 Jun 2023
2:07 pm

antoniop

Make sure only one tuple per room is returned

Options
    • -7
    • +10
    ./www/index-postgresql.xql
Wednesday 17 May 2023
11:09 am

trenner

room_id is required

Options
    • -2
    • +2
    ./www/chat.tcl
Tuesday 02 May 2023
10:00 am

gustafn

Improved SQL query significantly by using "acs_permission.permission_p_recursive_array"

Before, a sample query used 300K buffers, now it is down to 2.6 buffers.

Under bad conditions, the old query used 2s or more.

Options
    • -0
    • +22
    ./www/index-oracle.xql
    • -0
    • +18
    ./www/index-postgresql.xql
    • -14
    • +2
    ./www/index.tcl
9:56 am

gustafn

Fixed broken oracle.xql file (broken since 5 years)

Options
    • -1
    • +0
    ./www/room-oracle.xql
Thursday 30 Mar 2023
4:24 pm

antoniop

Handle persisting messages from outside of a connection, e.g. in the chat sweeper

Options
    • -2
    • +13
    ./tcl/chat-ajax-procs.tcl
2:01 pm

antoniop

Also cleanup acs_attribute

Options
    • -2
    • +2
    ./chat.info
    • -0
    • +7
    ./tcl/apm-callback-procs.tcl
Wednesday 29 Mar 2023
5:33 pm

antoniop

Cleanup the vestigial moderated_p flag

Options
    • -3
    • +3
    ./chat.info
    • -0
    • +5
    ./tcl/apm-callback-procs.tcl
    • -5
    • +5
    ./tcl/chat-procs.tcl
    • -2
    • +0
    ./tcl/xotcl-chat-procs.tcl
    • -1
    • +0
    ./tcl/test/chat-test-procs.tcl
    • -2
    • +1
    ./www/index.tcl
    • -6
    • +0
    ./www/room-edit.tcl
    • -4
    • +1
    ./www/room.tcl
  9. … 2 more files in changeset.
5:15 pm

antoniop

Get rid of the intermediate "room-enter" page and enforce all of the relevant permission in place in the "chat" page, cleanup variables and update automated tests

Options
    • -1
    • +0
    ./tcl/test/chat-test-procs.tcl
    • -9
    • +2
    ./tcl/test/webtest-procs.tcl
    • -24
    • +9
    ./www/chat.tcl
    • -2
    • +2
    ./www/index.tcl
    • -36
    • +0
    ./www/room-enter.tcl
  6. … 1 more file in changeset.
Tuesday 14 Mar 2023
2:39 pm

antoniop

Use better message key

Options
    • -2
    • +2
    ./www/room.adp
Monday 13 Mar 2023
3:59 pm

antoniop

Basic webtest of chat room creation

Options
    • -0
    • +48
    ./tcl/test/chat-test-procs.tcl
    • -0
    • +92
    ./tcl/test/webtest-procs.tcl
3:59 pm

antoniop

file webtest-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/test/webtest-procs.tcl
3:04 pm

antoniop

Follow-up for https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Agustafn%3A20230313120323

- make sure the anonymous users nsv is created when the chat is instantiated

- make sure xo::cc is available when the anonymous identifier is generated

- handle in the Chat package, that the uid may not be a user, but an IP address

- adapt other chat skins to the new anonymous user logics

Options
    • -6
    • +27
    ./tcl/chat-ajax-procs.tcl
  2. … 5 more files in changeset.
Wednesday 08 Mar 2023
4:51 pm

antoniop

Don't hardcode login requirement (to be continued)

Options
    • -2
    • +1
    ./www/chat.tcl
1:57 pm

antoniop

Do not add additional style around the chat includelet, regardless if this is a "chat_room" or a "chat"

Options
    • -6
    • +2
    ./tcl/chat-ajax-procs.tcl
  2. … 3 more files in changeset.
Tuesday 07 Mar 2023
3:41 pm

antoniop

Allow to pass down the skin configuration to the chat_room includelet

Options
    • -3
    • +6
    ./tcl/chat-ajax-procs.tcl
Thursday 23 Feb 2023
2:38 pm

antoniop

Complete coverage for the package

Options
    • -5
    • +166
    ./tcl/test/chat-test-procs.tcl
1:48 pm

antoniop

Fix syntax for proc coverage

Options
    • -2
    • +2
    ./tcl/test/chat-test-procs.tcl
1:46 pm

antoniop

Expect arbitrary arguments on inherited methods, detect instance variables that should be passed to the object creation in save_new

Options
    • -4
    • +21
    ./tcl/xotcl-chat-procs.tcl
1:45 pm

antoniop

Test chat room creation

This test now fails because certain acs_object metadata are not taken from instance variables, but from the context

Options
    • -0
    • +65
    ./tcl/test/chat-test-procs.tcl
1:45 pm

antoniop

file chat-test-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/test/chat-test-procs.tcl
Monday 24 Oct 2022
1:21 pm

gustafn

prefer adp:icon over old-style .gif images

Options
    • -1
    • +1
    ./lib/transcripts.tcl
  2. … 13 more files in changeset.
Saturday 15 Oct 2022
7:08 pm

gustafn

improve Oracle compatibility

Options
    • -1
    • +1
    ./tcl/xotcl-chat-procs.tcl
Tuesday 06 Sep 2022
1:17 pm

antoniop

Deprecate export_entire_form_as_url_vars and replace occurrences, add a new -formvars flag to export vars to implement the behavior of the proc, that is, export a subset of the variables coming from the current request

Options
    • -1
    • +1
    ./www/search-2.tcl
  2. … 5 more files in changeset.
11:44 am

antoniop

Deprecate export_ns_set_vars and extend export_vars to be able to export also a custom ns_set, which was the real added value provided by this api

Options
    • -1
    • +1
    ./www/search-2.tcl
  2. … 11 more files in changeset.
9:40 am

antoniop

Deprecate util_commify_number, replace occurrences and translate automated tests

Options
    • -1
    • +1
    ./www/search.tcl
  2. … 9 more files in changeset.
Friday 15 Jul 2022
3:35 pm

antoniop

Harden page contracts using new features in acs-tcl

Options
    • -3
    • +3
    ./chat.info
    • -1
    • +1
    ./lib/current-messages.tcl
    • -1
    • +1
    ./lib/transcripts.tcl
    • -10
    • +7
    ./www/chat-transcript.tcl
    • -11
    • +3
    ./www/chat.tcl
    • -9
    • +4
    ./www/message-delete-2.tcl
    • -2
    • +2
    ./www/message-delete.tcl
    • -18
    • +4
    ./www/room-delete-2.tcl
    • -10
    • +2
    ./www/room-delete.tcl
    • -1
    • +1
    ./www/room-edit.tcl
    • -11
    • +5
    ./www/room-enter.tcl
    • -2
    • +2
    ./www/room-exit.tcl
    • -2
    • +2
    ./www/room.tcl
    • -2
    • +2
    ./www/search.tcl
    • -1
    • +1
    ./www/toggle-active.tcl
  16. … 8 more files in changeset.
Wednesday 27 Apr 2022
6:41 pm

gustafn

passing properties consistently with @....;literal@

Options
    • -1
    • +1
    ./www/chat-transcript.adp
    • -1
    • +1
    ./www/chat-transcripts.adp
  3. … 11 more files in changeset.
Friday 25 Feb 2022
1:56 pm

gustafn

switch from xo::db::sql to acs::dc interface

Options
    • -2
    • +3
    ./chat.info
    • -3
    • +2
    ./tcl/chat-procs.tcl
    • -1
    • +1
    ./tcl/xotcl-chat-procs.tcl
  4. … 10 more files in changeset.
Saturday 12 Feb 2022
9:11 pm

gustafn

improving Oracle upgrade scripts

Oracle has no "ALTER TABLE ADD COLUMN ...."

Oracle has no "ALTER TABLE ADD COLUMN if exists .."

Options
    • -1
    • +1
    ./sql/oracle/upgrade/upgrade-5.0.1d6-5.0.1d7.sql
  2. … 8 more files in changeset.
Saturday 15 Jan 2022
5:16 pm

gustafn

get rid of legacy message key "menu-Clipboard-Copy"; "menu-Clipboard-Use-Copy" is used since several years instead

Options
    • -2
    • +2
    ./www/room.adp
  2. … 6 more files in changeset.