OpenACS / openacs-4 / packages / acs-templating

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 3
Total Committers: 46
Last Commit: 28 Dec
Commits this week: 3
Total Lines of Code (LoC): 24,955
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 31 Mar 2022
6:33 pm

antoniop

Replace the lame template::util::get_opts with some homemade utility that will parse arguments reliably, adjust the one upstream use case where arguments other than those documented might be passed to the element creation, introduce a warning when this happens somewhere else

Options
    • -2
    • +82
    ./element-procs.tcl
  2. … 1 more file in changeset.
6:23 pm

antoniop

Fix test, the proc behaves as documented (and IMO, it should go away at some point)

Options
    • -2
    • +7
    ./test/util-procs.tcl
2:59 pm

antoniop

New test for template::util::get_opts

This will expose a bug when an argument in an even position is specified that starts with a "-" character

Options
    • -1
    • +32
    ./test/util-procs.tcl
Wednesday 30 Mar 2022
10:34 am

trenner

not necessary to check if format is a list

Options
    • -1
    • +1
    ./richtext-procs.tcl
9:59 am

trenner

move the check for the provided format on richtext level

Options
    • -0
    • +4
    ./richtext-procs.tcl
    • -4
    • +2
    ./widget-procs.tcl
Tuesday 29 Mar 2022
1:01 pm

trenner

increase robustness

Options
    • -2
    • +4
    ./widget-procs.tcl
Monday 07 Feb 2022
5:12 pm

antoniop

Be stricter when validating widgets with restricted options: when no options are specified, treat it as automatic failure

Options
    • -5
    • +11
    ./data-procs.tcl
Monday 31 Jan 2022
12:13 pm

antoniop

Compute amplitude and wavelength explicitly in pixels and make it stable with respect to the captcha size, introduce a random offset for the wave instead

Fixes acs-templating.tesseract_cannot_crack_catpcha automated test

Options
    • -3
    • +8
    ./captcha-procs.tcl
Sunday 30 Jan 2022
3:38 pm

gustafn

Minor modernization

- use atomic stack operations to reduce locks and avoid race conditions

- improve spelling

- break overlong lines

- better align comments with actual code

Options
    • -3
    • +3
    ./date-procs.tcl
    • -36
    • +61
    ./parse-procs.tcl
    • -1
    • +1
    ./test/captcha-procs.tcl
Friday 28 Jan 2022
10:28 am

antoniop

Drop the pointsize parameter, use size instead, yielding more predictable results across Imagemagik versions and more controllable in general, make the wavelength randomized in the distortion

Options
    • -10
    • +12
    ./captcha-procs.tcl
    • -3
    • +13
    ./test/captcha-procs.tcl
Thursday 27 Jan 2022
10:23 am

antoniop

Deprecate template::util::tcl_to_sql_list, completely replaced by ns_dbquotelist, a native NaviServer command

Options
    • -1
    • +23
    ./deprecated-procs.tcl
    • -24
    • +1
    ./util-procs.tcl
    • -32
    • +1
    ./test/parse-test-procs.tcl
  4. … 15 more files in changeset.
9:22 am

antoniop

Improve test portability

Options
    • -1
    • +1
    ./test/captcha-procs.tcl
9:20 am

antoniop

Baseline test of captcha robustness: challenge the captcha using tesseract, also applying basic normalizations

Options
    • -0
    • +48
    ./test/captcha-procs.tcl
9:18 am

antoniop

Fail when no value is specified

Options
    • -4
    • +3
    ./captcha-procs.tcl
9:12 am

antoniop

Fix tests according to new behavior

Options
    • -6
    • +15
    ./test/captcha-procs.tcl
8:26 am

antoniop

Improve behavior: invalidate the captcha when the check fails, cleanup expired captcha also when a new one is generated

Options
    • -10
    • +22
    ./captcha-procs.tcl
Wednesday 26 Jan 2022
6:28 pm

antoniop

Test newly introduced api

Options
    • -0
    • +94
    ./test/captcha-procs.tcl
6:28 pm

antoniop

file captcha-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./test/captcha-procs.tcl
5:06 pm

antoniop

A simple image captcha implementation:

a random text is converted to a distorted image, its checksum, together with the expected text are stored in a lookup table. Upon validation, the text input by the user is matched against the checksum to determine if the captcha is correct.

Plan is to use it downstream on certain publicly available contact forms.

Options
    • -0
    • +207
    ./captcha-procs.tcl
  2. … 8 more files in changeset.
5:06 pm

antoniop

file captcha-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./captcha-procs.tcl
3:45 pm

antoniop

Make sure widget variable exists for the element

Options
    • -2
    • +3
    ./data-procs.tcl
Tuesday 25 Jan 2022
3:45 pm

antoniop

Add multiselect to the widgets we check

Options
    • -2
    • +3
    ./data-procs.tcl
3:27 pm

antoniop

Restrict new widget validation of options to select and radio, not every widget must restrict the values to the options property

Options
    • -2
    • +3
    ./data-procs.tcl
2:38 pm

antoniop

Implement a hook for widget-specific validation and use it to enforce that widgets that specify a list of options must return a value that belongs to those options

Options
    • -2
    • +38
    ./data-procs.tcl
Monday 24 Jan 2022
5:35 pm

antoniop

Inform widget: do not render any input element alongside the form value

Options
    • -8
    • +4
    ./widget-procs.tcl
Sunday 16 Jan 2022
4:34 pm

gustafn

improve spelling

Options
    • -3
    • +3
    ./date-procs.tcl
    • -1
    • +1
    ./head-procs.tcl
    • -2
    • +2
    ./list-procs.tcl
4:31 pm

gustafn

validate format of richtext field always

Options
    • -2
    • +2
    ./richtext-procs.tcl
Thursday 30 Dec 2021
3:45 pm

antoniop

Smartify idioms

Options
    • -15
    • +16
    ./tag-init.tcl
2:49 pm

antoniop

Fix typo

Options
    • -3
    • +7
    ./tag-init.tcl
Wednesday 29 Dec 2021
4:33 pm

gustafn

simplify idioms

Options
    • -6
    • +3
    ./tag-init.tcl