• last updated 19 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Document public api

  1. … 1 more file in changeset.
Centralize retrieval of the test URL

  1. … 4 more files in changeset.
Fix reference in doc

Deprecate export_ns_set_vars and extend export_vars to be able to export also a custom ns_set, which was the real added value provided by this api

  1. … 11 more files in changeset.
Small improvements:

- use "string is space" instead of trimming the string and checking if empty, at least 2x faster on development, wherever we don't need the trimmed value

- modernize leftover foreach trick with lassign

  1. … 5 more files in changeset.
Claim additional coverage

Count already exisring handlers before introducing new ones

Improve acs::test::form_reply so that when the attributes of a file upload (*.tmpfile or *.content-type) are part of the update argument, it will switch automatically to a multipart request and implement a "real" file upload

This is important on newer NaviServer versions that will reject any *.tmpfile parameter in a request that was not produced internally after a file upload

  1. … 1 more file in changeset.
Test also nonce rendering

Make test more precise

Test a bunch more api

Test template::adp_level, fix test coverage declaration

Test template::adp_parse_string

Deprecate template::adp_levels, found nowhere in the upstream codebase and superseded by template::adp_level

Increase proc coverage

State additional proc coverage, improve documentation

Make template::head::prepare_multirows a private interface: its stated purpose is to be used inside of the blank-master and it has no practical use otherwise

Make adp_parse_ad_conn_file a private interface: its stated purpose is to be registered via rp_register_extension_handler in acs-templating/tcl/acs-integration-init.tcl and it has no practical use otherwise

Test ad_return_template

Test ad_return_exception_template

file acs-integration-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./test/acs-integration-procs.tcl
Test ad_dimensional_sql

Test ad_dimensional

file dimensional-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./test/dimensional-procs.tcl
Fix typo

template::element validation reform: do not run custom user-defined validation on fields that are not formally correct

Rationale: user-defined validation often assumes some basic consistency of the submitted value. When this is not formally correct, users might have to reimplement the whole formal validation in their custom fields in order to prevent exceptions. By preventing their custom blocks from being executed, users can rely on their custom fields to be run only against sane values.

Restore formatting in procs doc

Normalize indentation according to editor hints

Test template::util::list_to_lookup

Deprecate template::util::nvl