• last updated 22 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
sharpen test case to reduced dependencies on previously enabled locales

The test is also more parameterized, such one can choose between two locales (de_DE and es_ES)

in the test case.

improved spelling

  1. … 15 more files in changeset.
Improved regression test

- make string match with message keys more exact

- avoid substitution errors when fetching arbitrary message keys from the DB

- reduced verbosity

    • -10
    • +21
    ./tcl/test/acs-lang-localization-procs.tcl
New API call: aa_silence_log_entries

The new function silences expected messages in the system log. The

proc deactivates the specified severity levels during the code in the

last arguemnt is executed. After it has finished, the severity levels

are reset to their previous values.

The purpose of this function is to make test system log clean from

error messages and the like during the regression test, such it

contains only errors which have to be looked at.

  1. … 5 more files in changeset.
silence expected error messages in the log file during regression test

fixed resource leaks

dom trees were not deleted

added after-mount callback to restrict default permissions

- Modify default permissions after mount to restrict read access to

the package from public read to read access for registered users.

- The change affects only fresh installed, existing permission settings

are not touched.

- fixed typos

- bumped version number to 5.10.1b3

spell "site-wide" consistently with a dash

  1. … 32 more files in changeset.
regenreated documentation (with non-finished release notes)

  1. … 146 more files in changeset.
Always use "--" in "dom parse" when document is interpolated

This is a safety measure to make sure that the document parsed is

never confused with an option, when the document starts with a "-". In

the best case, the error message provided by "dom parse" might be

misleading. This might be a problem for user contributed documents

(passed as variables, or return values from functions).

The double dash is supported in tdom since version 0.9.0.

  1. … 18 more files in changeset.
load catalog when enabling a locale

reduce verbosity

  1. … 2 more files in changeset.
improved spelling

  1. … 13 more files in changeset.
improvement for ACS clusters

Incorporated changes as suggested by Jonathan Kelley

For details, see https://openacs.org/forums/message-post?parent_id=5814308

  1. … 1 more file in changeset.

Use GNU grep when available

GNU grep is now used for the lookup of message keys using the

"--include=" parameter. This improves the speed of the command

significantly and reduces the number of external dependencies (no

"find", or "xargs" needed).

    • -4
    • +29
    ./www/admin/message-usage-include.tcl
  1. … 1 more file in changeset.
Removed obsolete files www/admin/lookups-include.tcl

The file www/admin/lookups-include.tcl was replaced some time ago by

www/admin/message-usage-include.tcl but as it looks, not removed from

the repository.

Flush the whole key pattern, now that the key can end either in true or false

Fixes locale__test_lang_conn_browser_locale automated test

Fixed unreviewed commit, which might lead to hard-to-spot errors

The last change assumed that "nls_language" can be hard-wired to

contain most 5 characters. While this not backed by the OpenACS data

model, the standard (RFC 5646) explicitly states that there is no

upper limit on the size of language tags. The tree letter language

codes have been standard since 2001 (RFC 4646).

The change accepts now all defined locales. When the specified locale

is not enabled, it provides a log notice, when the locale is not

defined at all, it provides a warning and falls back to "en_US".

  1. … 2 more files in changeset.
removed the previous half finished change, the update of the timezone data helps

    • -8
    • +0
    ./tcl/test/acs-lang-localization-procs.tcl
fix regression test to cope with time zone

Since OpenACS timezone data is now newer as in many tcl versions, some time zones

might not be available in tcl. Therefore, tcl-based conversions with these

time zones will fail.

This change skips these timezones (on my system, 2 cases). But this

is just a part of the fix. The "DB-based conversion" in "lc_time_tz_convert"

seems to be broken for these cases as well, otherwise the regression

test would not have stopped working.

    • -0
    • +8
    ./tcl/test/acs-lang-localization-procs.tcl
Adapt test to current timezones

    • -7
    • +0
    ./tcl/test/acs-lang-localization-procs.tcl
Bring the logics to parse a datetime from lc_time_fmt into an own private utility lc_datetime_to_clock and reuse it also when we convert from one timezone to another

Allow also dates in the "short" time format, as they may be supplied to the api in such form e.g. by the calendar package

Fixes lang_test__lc_procs automated test

Extend test suite to check that also dates in the "short" time format are supported

This test will fail

    • -0
    • +6
    ./tcl/test/acs-lang-localization-procs.tcl
Form widget attributes reform:

- consolidate the logics to merge tag attributes coming from the adp and the tcl definitions of widgets into a private api

- change the previous behavior of having attributes coming from the adp (aka the tag_attributes argument) take over attributes coming from the element

See https://openacs.org/forums/message-view?message_id=5799349

  1. … 6 more files in changeset.
harden page contracts

    • -2
    • +2
    ./www/admin/edit-localized-message.tcl
  1. … 19 more files in changeset.
bumped version numbers to 5.10.1b1

  1. … 85 more files in changeset.
regenerated documentation

  1. … 294 more files in changeset.
Test external command line dependencies

  1. … 1 more file in changeset.
Complete coverage for the package