OpenACS / openacs-4 / packages

acs-lang

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 41
Last Commit: 14 Nov
Commits this week: 0
Total Lines of Code (LoC): 20,563
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 22 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 28 Jul
7:00 pm

gustafn

Always use "--" in "dom parse" when document is interpolated

This is a safety measure to make sure that the document parsed is

never confused with an option, when the document starts with a "-". In

the best case, the error message provided by "dom parse" might be

misleading. This might be a problem for user contributed documents

(passed as variables, or return values from functions).

The double dash is supported in tdom since version 0.9.0.

Options
    • -1
    • +1
    ./tcl/test/acs-lang-test-procs.tcl
  2. … 18 more files in changeset.
Friday 19 Jul
12:57 pm

gustafn

load catalog when enabling a locale

Options
    • -1
    • +2
    ./tcl/lang-install-procs.tcl
Thursday 18 Jul
4:38 pm

gustafn

reduce verbosity

Options
    • -3
    • +3
    ./tcl/localization-procs.tcl
  2. … 2 more files in changeset.
Monday 15 Jul
2:04 pm

gustafn

improved spelling

Options
    • -2
    • +2
    ./tcl/lang-message-procs.tcl
    • -2
    • +2
    ./tcl/locale-procs.tcl
  3. … 13 more files in changeset.
Friday 17 May
7:01 pm

gustafn

improvement for ACS clusters

Incorporated changes as suggested by Jonathan Kelley

For details, see https://openacs.org/forums/message-post?parent_id=5814308

Options
    • -8
    • +6
    ./tcl/lang-message-procs.tcl
  2. … 1 more file in changeset.
Sunday 25 Feb
4:46 pm

gustafn

Use GNU grep when available

GNU grep is now used for the lookup of message keys using the

"--include=" parameter. This improves the speed of the command

significantly and reduces the number of external dependencies (no

"find", or "xargs" needed).

Options
    • -4
    • +29
    ./www/admin/message-usage-include.tcl
  2. … 1 more file in changeset.
4:43 pm

gustafn

Removed obsolete files www/admin/lookups-include.tcl

The file www/admin/lookups-include.tcl was replaced some time ago by

www/admin/message-usage-include.tcl but as it looks, not removed from

the repository.

Options
    • -23
    • +0
    ./www/admin/lookups-include.tcl
Friday 16 Feb
5:46 pm

antoniop

Flush the whole key pattern, now that the key can end either in true or false

Fixes locale__test_lang_conn_browser_locale automated test

Options
    • -2
    • +2
    ./tcl/locale-procs.tcl
11:31 am

gustafn

Fixed unreviewed commit, which might lead to hard-to-spot errors

The last change assumed that "nls_language" can be hard-wired to

contain most 5 characters. While this not backed by the OpenACS data

model, the standard (RFC 5646) explicitly states that there is no

upper limit on the size of language tags. The tree letter language

codes have been standard since 2001 (RFC 4646).

The change accepts now all defined locales. When the specified locale

is not enabled, it provides a log notice, when the locale is not

defined at all, it provides a warning and falls back to "en_US".

Options
    • -2
    • +2
    ./acs-lang.info
    • -10
    • +19
    ./tcl/locale-procs.tcl
  3. … 2 more files in changeset.
Thursday 08 Feb
7:42 pm

gustafn

removed the previous half finished change, the update of the timezone data helps

Options
    • -8
    • +0
    ./tcl/test/acs-lang-localization-procs.tcl
1:49 pm

gustafn

fix regression test to cope with time zone

Since OpenACS timezone data is now newer as in many tcl versions, some time zones

might not be available in tcl. Therefore, tcl-based conversions with these

time zones will fail.

This change skips these timezones (on my system, 2 cases). But this

is just a part of the fix. The "DB-based conversion" in "lc_time_tz_convert"

seems to be broken for these cases as well, otherwise the regression

test would not have stopped working.

Options
    • -0
    • +8
    ./tcl/test/acs-lang-localization-procs.tcl
Wednesday 07 Feb
10:27 am

hectorr

Adapt test to current timezones

Options
    • -7
    • +0
    ./tcl/test/acs-lang-localization-procs.tcl
Tuesday 30 Jan
4:57 pm

antoniop

Bring the logics to parse a datetime from lc_time_fmt into an own private utility lc_datetime_to_clock and reuse it also when we convert from one timezone to another

Options
    • -40
    • +47
    ./tcl/localization-procs.tcl
3:21 pm

antoniop

Allow also dates in the "short" time format, as they may be supplied to the api in such form e.g. by the calendar package

Fixes lang_test__lc_procs automated test

Options
    • -10
    • +18
    ./tcl/localization-procs.tcl
3:19 pm

antoniop

Extend test suite to check that also dates in the "short" time format are supported

This test will fail

Options
    • -0
    • +6
    ./tcl/test/acs-lang-localization-procs.tcl
Thursday 30 Nov 2023
4:13 pm

antoniop

Form widget attributes reform:

- consolidate the logics to merge tag attributes coming from the adp and the tcl definitions of widgets into a private api

- change the previous behavior of having attributes coming from the adp (aka the tag_attributes argument) take over attributes coming from the element

See https://openacs.org/forums/message-view?message_id=5799349

Options
    • -5
    • +4
    ./tcl/lang-widget-procs.tcl
  2. … 6 more files in changeset.
Friday 06 Oct 2023
2:31 pm

gustafn

harden page contracts

Options
    • -2
    • +2
    ./www/admin/edit-localized-message.tcl
    • -11
    • +3
    ./www/admin/locale-delete.tcl
    • -1
    • +1
    ./www/admin/locale-set-enabled-p.tcl
    • -5
    • +3
    ./www/admin/message-delete.tcl
    • -4
    • +2
    ./www/admin/message-undelete.tcl
    • -4
    • +2
    ./www/admin/message-unregister.tcl
  7. … 19 more files in changeset.
Thursday 13 Jul 2023
3:09 pm

gustafn

bumped version numbers to 5.10.1b1

Options
    • -7
    • +7
    ./acs-lang.info
  2. … 85 more files in changeset.
2:43 pm

gustafn

regenerated documentation

Options
    • -5
    • +10
    ./www/doc/i18n-design.adp
    • -0
    • +0
    ./www/doc/i18n-requirements.adp
  3. … 294 more files in changeset.
Thursday 20 Apr 2023
3:57 pm

antoniop

Test external command line dependencies

Options
    • -0
    • +14
    ./tcl/test/acs-lang-test-procs.tcl
  2. … 1 more file in changeset.
Friday 24 Mar 2023
4:51 pm

antoniop

Complete coverage for the package

Options
    • -0
    • +60
    ./tcl/test/lang-widget-procs.tcl
4:51 pm

antoniop

file lang-widget-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/test/lang-widget-procs.tcl
Tuesday 21 Mar 2023
2:44 pm

antoniop

Go ahead and reimplement also lc_time_utc_to_local

Options
    • -16
    • +0
    ./tcl/localization-procs-oracle.xql
    • -14
    • +0
    ./tcl/localization-procs-postgresql.xql
    • -10
    • +7
    ./tcl/localization-procs.tcl
2:34 pm

antoniop

Reimplement lc_time_local_to_utc using lc_time_tz_convert

Options
    • -11
    • +0
    ./tcl/localization-procs-oracle.xql
    • -9
    • +0
    ./tcl/localization-procs-postgresql.xql
    • -10
    • +9
    ./tcl/localization-procs.tcl
2:31 pm

antoniop

Improve test for lc_time_local_to_utc, showing that its behavior is inconsitent with respect to invalid input

Options
    • -0
    • +33
    ./tcl/test/acs-lang-localization-procs.tcl
Friday 10 Feb 2023
4:48 pm

antoniop

Return the system locale as the user locale also when user preferences are there for the user, but the locale is empty

Options
    • -10
    • +10
    ./tcl/locale-procs.tcl
4:34 pm

antoniop

Replace api outside of the package dependencies

Options
    • -1
    • +1
    ./tcl/test/lang-catalog-procs.tcl
1:01 pm

antoniop

Deprecate Oracle-specific collation api

Although it could be interesting to have OpenACS cross-db support for collation, it is unclear if just using different idioms in xql files would not achieve the same.

Options
    • -2
    • +10
    ./tcl/lang-util-procs.tcl
Thursday 09 Feb 2023
3:10 pm

antoniop

Update thead variable them setting the translator mode

Options
    • -1
    • +2
    ./tcl/lang-util-procs.tcl
3:07 pm

antoniop

Increase coverage

This test will currently fail because the translator mode flag is cached per thread, but the set api won't update this cache.

Options
    • -0
    • +25
    ./tcl/test/lang-util-procs.tcl