OpenACS / openacs-4 / packages / acs-lang

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 25
Last Commit: 19 Dec
Commits this week: 0
Total Lines of Code (LoC): 8,193
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 08 Feb 2023
4:25 pm

antoniop

Cleanup private interface lang::system::timezone_support_p: ref-timezones has been made a dependency of acs-lang long ago

Options
    • -33
    • +2
    ./locale-procs.tcl
    • -83
    • +73
    ./test/acs-lang-test-procs.tcl
  3. … 4 more files in changeset.
4:09 pm

antoniop

Allow to specify a user for lang::user::language, default to the package default locale when a locale for user+package is not found

Options
    • -3
    • +4
    ./locale-procs.tcl
    • -4
    • +10
    ./locale-procs.xql
4:08 pm

antoniop

Increase proc coverage

This test will fail because of two reasons:

- when using package-level locales and a package default locale is specified, but no user+package locale, the expected behavior should be that the default from the package is used, but this is not the case

- lang::user::language does not allow to specify a user id

Options
    • -0
    • +101
    ./test/locale-procs.tcl
4:08 pm

antoniop

file locale-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./test/locale-procs.tcl
2:49 pm

antoniop

Increase proc coverage

Options
    • -5
    • +104
    ./test/lang-catalog-procs.tcl
1:54 pm

antoniop

Increase proc coverage

Options
    • -0
    • +46
    ./test/lang-catalog-procs.tcl
1:54 pm

antoniop

file lang-catalog-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./test/lang-catalog-procs.tcl
Thursday 26 Jan 2023
5:30 pm

antoniop

Cleanup leftover, fix typos

Options
    • -5
    • +2
    ./test/acs-lang-localization-procs.tcl
5:24 pm

antoniop

lc_time_tz_convert reform:

- enforce that only dates in the ISO format "%Y-%m-%d %H:%M:%S" are accepted

- apply clock api normalization to seemingly out of range time_values, as per https://www.tcl.tk/man/tcl/TclCmd/clock.html#M25

- return the empty string every time input is invalid or a conversion cannot be determined

- return a value, as ISO date, only when conversion is successful

- prefer the clock api to perform the conversion, but fall back to the ref-timezones datamodel when the timezone is not supported by Tcl

Options
    • -15
    • +0
    ./localization-procs-oracle.xql
    • -12
    • +0
    ./localization-procs-postgresql.xql
    • -11
    • +73
    ./localization-procs.tcl
5:20 pm

antoniop

Introduce a thorough test of the lc_time_tz_convert api checking:

- dates in the distant past

- dates in the distant future

- daylight saving for different times of the year across the two timezones

- historical circumstances (e.g. Pre-timezones US)

- Invalid input

The test shows that the current api does not behave consistently in certain circumstances:

- the same time_value is sometimes returned with invalid input

- the empty string is sometimes returned with valid input

- for dates where the ref-timezones package does not provide information, no result is returned

Options
    • -0
    • +118
    ./test/acs-lang-localization-procs.tcl
Sunday 27 Nov 2022
6:55 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./lang-util-procs.tcl
    • -1
    • +1
    ./test/acs-lang-localization-procs.tcl
  3. … 8 more files in changeset.
Monday 24 Oct 2022
7:35 pm

gustafn

break overlong lines

Options
    • -4
    • +7
    ./lang-message-procs.tcl
Tuesday 20 Sep 2022
2:07 pm

trenner

produce error message in the error log, if the parameter value_array_list is not well formed

Options
    • -1
    • +5
    ./lang-message-procs.tcl
Monday 12 Sep 2022
5:54 pm

antoniop

Document public api

Options
    • -1
    • +9
    ./lang-util-procs.tcl
5:43 pm

antoniop

Document public api

Options
    • -1
    • +3
    ./lang-message-procs.tcl
  2. … 1 more file in changeset.
Monday 05 Sep 2022
5:07 pm

antoniop

Small improvements:

- use "string is space" instead of trimming the string and checking if empty, at least 2x faster on development, wherever we don't need the trimmed value

- modernize leftover foreach trick with lassign

Options
    • -2
    • +2
    ./lang-message-procs.tcl
  2. … 6 more files in changeset.
Monday 29 Aug 2022
4:17 pm

antoniop

Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

Options
    • -2
    • +2
    ./lang-catalog-procs.tcl
    • -3
    • +3
    ./lang-message-procs.tcl
  3. … 32 more files in changeset.
Tuesday 23 Aug 2022
8:44 pm

gustafn

Properly escape "<" and ">" in api-doc documentation.

Since all documentation is rendered via HTML, the characters

"<" and ">" have to be HTML-quoted, otherwise strange things

(omission, unintended renderings) might occur.

E.g. the sentence

Define an interface between a page and an

ADP <include> similar to the page_contract.

was rendered as

Define an interface between a page and an

ADP similar to the page_contract.

which is incorrect.

Options
    • -7
    • +7
    ./lang-util-procs.tcl
  2. … 13 more files in changeset.
Friday 19 Aug 2022
4:23 pm

antoniop

Return 0 when looking up the existance of a message key in an unsupported locale instead of failing, test the behavior

Options
    • -2
    • +6
    ./lang-message-procs.tcl
    • -0
    • +56
    ./test/acs-lang-localization-procs.tcl
3:15 pm

antoniop

Improve test precision: take into account packages defined as <install... in the info file, as e.g. dotlrn does

Options
    • -6
    • +42
    ./test/acs-lang-test-procs.tcl
Thursday 18 Aug 2022
4:58 pm

antoniop

Fallback here as well to en_US when no supported locale is found

Options
    • -1
    • +11
    ./locale-procs.tcl
Wednesday 17 Aug 2022
1:32 pm

antoniop

info files do not contain message keys

Options
    • -1
    • +1
    ./test/acs-lang-test-procs.tcl
Sunday 26 Jun 2022
9:38 pm

gustafn

use cookie namespace also for stored locales

Options
    • -4
    • +6
    ./locale-procs.tcl
  2. … 1 more file in changeset.
Monday 28 Feb 2022
6:41 pm

antoniop

Constrain the language we return for the connection to the ones we support: could happen on system that have supposted a language in the past and still have users set it as their preferred language

Options
    • -4
    • +4
    ./locale-procs.tcl
Tuesday 15 Feb 2022
10:01 pm

gustafn

Fixes for Oracle 19c: (temporary?) fix for message catalogs

This change fixes the problem that after a fresh installation, all (!)

messages keys are empty. I am not sure what the source of the problem

is, why this has supposedly worked some years before, and whether

there are undesired side-effects of this change. Without this change,

the openacs installation leads to fully broken state.

Options
    • -1
    • +1
    ./lang-message-procs-oracle.xql
5:51 pm

gustafn

improved error message

Options
    • -2
    • +3
    ./localization-procs.tcl
5:50 pm

gustafn

Fixes for Oracle 19c boolean types in query

This fixes the following bug for Oracle:

: SQL:

: select locale

: from ad_locales l

: where language = :language

: and enabled_p

: !>>>!and (default_p or not exists (select 1 from ad_locales

: where language = :language

: and locale <> l.locale))

:

Options
    • -5
    • +6
    ./lang-util-procs.tcl
Tuesday 01 Feb 2022
2:23 pm

antoniop

Reduce need for xql

Options
    • -6
    • +4
    ./lang-message-procs.tcl
    • -12
    • +0
    ./lang-message-procs.xql
2:17 pm

antoniop

Cleanup hacks addressing #2011927 bug in Oracle: this has been supposedly addressed in version 9i, already EOL

See http://oracle-docs.dartmouth.edu/dba-docs/patchset_9.2.0.4.htm

Options
    • -19
    • +5
    ./lang-message-procs.tcl
    • -16
    • +0
    ./lang-message-procs.xql
Monday 31 Jan 2022
5:33 pm

antoniop

Fix acs-lang.test_message_register automated test:

when checking if a message should be created or updated, do not trust the nsv, which won't be there for messages that have been soft-deleted and go to the db instead. When a message is soft deleted, cleanup the nsv cache.

Options
    • -4
    • +14
    ./lang-message-procs.tcl