Activity OpenACS/openacs-4/packages/acs-lang/tcl

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	24
Last Commit:
Commits this week:	0
Total Lines of Code (LoC):	6,657
Net change in LoC this week:	0

Commit Activity

last updated 17 hours ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

End Date:

Monday 30 Sep

9:06 pm

gustafn

improve handling of invalid (hacked) ad_locale cookies.

Previously, invalid ad_locale cookies lead to an error, which in turn

prevented all communication with OpenACS. So, a user had to delete the

cookie manually. Now, we just produce a warning, ignore and delete such

broken cookies.

- -8
- +19
./locale-procs.tcl
- History
- Source
- Diff
./locale-procs.tcl
- -1
- +1
./test/acs-lang-test-procs.tcl
- History
- Source
- Diff
./test/acs-lang-test-procs.tcl

Friday 06 Sep

5:58 pm

hectorr

Use 'ns_log Error' for error logging, instead of 'ns_log Notice: Error...'

- -2
- +2
./lang-catalog-procs.tcl
- History
- Source
- Diff
./lang-catalog-procs.tcl
… 4 more files in changeset.

Thursday 05 Sep

10:57 am

antoniop

Fix typo

- -1
- +0
./test/acs-lang-test-procs.tcl
- History
- Source
- Diff
./test/acs-lang-test-procs.tcl

Wednesday 04 Sep

5:32 pm

antoniop

Do not rely on error trapping for file retrieval, introduce a test for this proc

- -9
- +4
./lang-catalog-procs.tcl
- History
- Source
- Diff
./lang-catalog-procs.tcl
- -0
- +23
./test/acs-lang-test-procs.tcl
- History
- Source
- Diff
./test/acs-lang-test-procs.tcl

Saturday 10 Aug

5:10 pm

gustafn

improve spelling

- -2
- +2
./lang-catalog-procs.tcl
- History
- Source
- Diff
./lang-catalog-procs.tcl
- -2
- +2
./lang-message-procs.tcl
- History
- Source
- Diff
./lang-message-procs.tcl
- -3
- +3
./localization-procs.tcl
- History
- Source
- Diff
./localization-procs.tcl
… 9 more files in changeset.

Monday 01 Jul

6:55 pm

hectorr

Prefer '==' over 'eq' on numeric comparison

- -5
- +5
./lang-util-procs.tcl
- History
- Source
- Diff
./lang-util-procs.tcl
… 3 more files in changeset.

6:43 pm

hectorr

Prefer '==' over 'eq' on numeric comparison

- -2
- +2
./localization-procs.tcl
- History
- Source
- Diff
./localization-procs.tcl

6:26 pm

hectorr

lc_content_size_pretty: go the extra mile and return a localized 'byte' when the result is just 1 byte. Bump acs-lang version to reload message keys.

- -4
- +19
./localization-procs.tcl
- History
- Source
- Diff
./localization-procs.tcl
- -1
- +7
./test/acs-lang-localization-procs.tcl
- History
- Source
- Diff
./test/acs-lang-localization-procs.tcl
… 33 more files in changeset.

4:47 pm

hectorr

Move 'util::content_size_pretty' into 'acs-lang' and rename it to 'lc_content_size_pretty', localicing 'bytes' and adapting automated tests. Bump 'acs-lang' version.

- -1
- +74
./localization-procs.tcl
- History
- Source
- Diff
./localization-procs.tcl
- -0
- +60
./test/acs-lang-localization-procs.tcl
- History
- Source
- Diff
./test/acs-lang-localization-procs.tcl
… 40 more files in changeset.

Wednesday 19 Jun

8:10 pm

gustafn

Fix for issue #3409

- -7
- +15
./locale-procs.tcl
- History
- Source
- Diff
./locale-procs.tcl

Sunday 16 Jun

3:12 pm

gustafn

improve spelling

- -1
- +1
./test/acs-lang-test-procs.tcl
- History
- Source
- Diff
./test/acs-lang-test-procs.tcl

Friday 12 Apr

11:19 pm

gustafn

improve spelling

- -2
- +2
./lang-catalog-procs.tcl
- History
- Source
- Diff
./lang-catalog-procs.tcl
… 17 more files in changeset.

Monday 08 Apr

3:24 pm

Add 'message-undelete' page to make use of the new '::message::undelete' proc for undeleting messages, a couple of icons, the undelete option in 'message-list' and the undelete action in automated tests

- -0
- +12
./test/acs-lang-test-procs.tcl
- History
- Source
- Diff
./test/acs-lang-test-procs.tcl
… 6 more files in changeset.

Friday 05 Apr

2:50 pm

hectorr

Add 'lang::message::undelete', in order to provide an API for undeletion of messages deleted via 'lang::message::delete', and modify 'lang::message::edit' accordingly. Next step would be to provide a user interface for it.

- -36
- +66
./lang-message-procs.tcl
- History
- Source
- Diff
./lang-message-procs.tcl

Monday 25 Mar

3:16 pm

antoniop

Exclude locales that are not enabled from test

- -1
- +3
./test/acs-lang-test-procs.tcl
- History
- Source
- Diff
./test/acs-lang-test-procs.tcl

3:06 pm

antoniop

Do not test deleted keys

- -4
- +4
./test/acs-lang-test-procs.tcl
- History
- Source
- Diff
./test/acs-lang-test-procs.tcl

1:08 pm

antoniop

Display error message when the test fails

- -2
- +3
./test/acs-lang-test-procs.tcl
- History
- Source
- Diff
./test/acs-lang-test-procs.tcl

Thursday 14 Mar

3:26 pm

antoniop

Update test case for lang::util::default_locale_from_lang

- -16
- +10
./test/acs-lang-test-procs.tcl
- History
- Source
- Diff
./test/acs-lang-test-procs.tcl

11:23 am

antoniop

Redefine ad_locales.language table column as varchar to avoid Oracle idiosyncrasies when comparing a char(n) with other string datatypes when using bind variables (following insightful LARS's remark)

char(n) in Oracle are automatically padded to be n characters long. Apparently, comparing char(n) -> char(n) is "blanks insensitive", while comparing char(n) -> varchar2(n) will account for such automatically inserted blanks. When using bind variables, one should carefully specify the type to use to avoid surprises with char(n) (for this we should touch the oracle driver), normalize the value via trim/pad all the time or replace every char(n) datatype with varchar2. ...are there other places where this is happening?