• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
list called api procs

Mark 'lang::message::cache' as public, as it is used in 'acs-admin'

Mark 'lang::catalog::package_catalog_dir' as public, as it is used in 'acs-admin'

Mark 'lang::util::get_hash_indices' as public, as it is used in 'acs-admin'

complete listing of covered procs in test cases

  1. … 14 more files in changeset.
Make api public, complies with acs-api-browser.graph__bad_calls automated test

  1. … 4 more files in changeset.
remove protection "private", since function has to be called from other packages

  1. … 6 more files in changeset.
bring test coverage to >50% by adding test cases and marking only locally called functions as private

    • -0
    • +29
    ./test/acs-lang-localization-procs.tcl
mark unused function "_mr" as deprecated

improve listing of test coverage

  1. … 17 more files in changeset.
use per_thread_cache for flusing rather than raw variables

make listing of tested procs more complete

    • -2
    • +5
    ./test/acs-lang-localization-procs.tcl
  1. … 5 more files in changeset.
make comment more precise

New test to enforce that catalog files are valid XML

Define arguments so that documentation__check_parameters automated test does find -varname flag correctly

Pass missing object_id flag

Improve sql portability

    • -22
    • +22
    ./test/acs-lang-localization-procs.tcl
  1. … 6 more files in changeset.
Improve test

    • -8
    • +13
    ./test/acs-lang-localization-procs.tcl
New test for lang::util::convert_to_i18n pinpointing some expected behaviors of this proc

    • -0
    • +67
    ./test/acs-lang-localization-procs.tcl
Fix typo

acs-lang reform:

when calling lang::util::convert_to_i18n, do not always register a en_US translation, which will be otherwise always overridden. Instead, let lang::message::register make sure that a en_US message exists and create it only when needed as a fallback. Before, lang::message::register would return an error when e.g. a new message keys was registered for de_DE and no en_US was there. Now the en_US will be just created on the fly.

This does not break current automated tests

acs-lang reform

Provide an optional object_id which can be used to register message keys that will be bound to the lifecycle of an acs-object. When the object is deleted, so will the message key.

This is useful for groups that automatically define a message key for their pretty name. Tcl api was already aware of this and would cleanup such message keys, but other idioms e.g. stored procedures used to delete groups would leave leftovers behind. These can become relatively numerous on group-intensive systems such as LEARN.

Other future usages for this new feature might be the automatic localization of xowiki FormPage properties.

  1. … 7 more files in changeset.
improve spelling

  1. … 4 more files in changeset.
Keep using ad_conn in lang::conn::timezone as set_get_timezone needs to simulate lack of connection and ad_conn allows to override the "real" value

Refactor 'locale_language_fallback' testcase, using 'aa_run_with_teardown' and preventing errors when the 'en_GB' locale is not enabled

prefer "ns_conn isconnected" over "ad_conn isconnected", since the latter might not notice changes in the connect state

  1. … 15 more files in changeset.
mprove spelling: move closer to the linux documentation recommendations

  1. … 19 more files in changeset.
improve error message

provide a more friendly error message for broken configurations

avoid repeated lookup for the same locale