OpenACS / openacs-4 / packages / acs-authentication

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 30
Last Commit: 20 Dec
Commits this week: 0
Total Lines of Code (LoC): 10,422
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 09 Oct
11:42 am

antoniop

Rework array idioms into dict idioms hwre appropriate, e.g.:

- when the return value of a proc is already a dict in itself

- when the return value of a proc should be completely overwritten in later tests

This avoids array "unwrapping" operations and unsets

Options
    • -259
    • +230
    ./test/acs-authentication-procs.tcl
    • -29
    • +27
    ./test/sync-test-procs.tcl
Tuesday 08 Oct
3:11 pm

antoniop

Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -2
    • +2
    ./sync-procs.tcl
  2. … 3 more files in changeset.
Wednesday 11 Sep
8:11 am

gustafn

merge with missing files

Options
    • -0
    • +0
    ./apm-callback-procs.tcl
    • -0
    • +0
    ./authentication-procs-aolserver.tcl
    • -0
    • +0
    ./authentication-procs-naviserver.tcl
    • -0
    • +0
    ./authentication-procs.tcl
    • -0
    • +0
    ./authority-procs.tcl
    • -0
    • +0
    ./driver-procs.tcl
    • -0
    • +0
    ./local-procs.tcl
    • -0
    • +0
    ./password-procs.tcl
    • -0
    • +0
    ./sync-procs.tcl
    • -0
    • +0
    ./test/acs-authentication-procs.tcl
    • -0
    • +0
    ./test/sync-test-procs.tcl
  12. … 1454 more files in changeset.
Tuesday 03 Sep
5:37 pm

gustafn

merge from oacs-5-10

Options
    • -11
    • +11
    ./apm-callback-procs.tcl
    • -2
    • +3
    ./authentication-procs-aolserver.tcl
    • -8
    • +10
    ./authentication-procs-naviserver.tcl
    • -91
    • +146
    ./authentication-procs.tcl
    • -28
    • +40
    ./authority-procs.tcl
    • -2
    • +6
    ./driver-procs.tcl
    • -43
    • +39
    ./local-procs.tcl
    • -14
    • +0
    ./local-procs.xql
    • -3
    • +3
    ./password-procs.tcl
    • -8
    • +12
    ./sync-procs.tcl
    • -0
    • +133
    ./test-authority-procs.tcl
    • -28
    • +0
    ./test/acs-authentication-procs-oracle.xql
    • -29
    • +0
    ./test/acs-authentication-procs-postgresql.xql
    • -129
    • +370
    ./test/acs-authentication-procs.tcl
    • -0
    • +659
    ./test/authentication-procs.tcl
  16. … 8085 more files in changeset.
Friday 30 Aug
9:47 am

gustafn

improved spelling

Options
    • -3
    • +3
    ./test/acs-authentication-procs.tcl
    • -2
    • +2
    ./test/authentication-procs.tcl
  3. … 14 more files in changeset.
Wednesday 28 Aug
12:06 pm

gustafn

silence test cases

Options
    • -2
    • +6
    ./authentication-procs.tcl
    • -17
    • +30
    ./test/acs-authentication-procs.tcl
    • -4
    • +14
    ./test/authentication-procs.tcl
    • -8
    • +8
    ./test/sync-test-procs.tcl
Tuesday 20 Aug
10:58 am

gustafn

fixed leaked dom trees

Options
    • -2
    • +6
    ./sync-procs.tcl
Wednesday 17 Jul
3:56 pm

gustafn

skip hopeless tests, where mail server is not configured

Options
    • -6
    • +6
    ./authentication-procs.tcl
    • -4
    • +15
    ./test/acs-authentication-procs.tcl
3:55 pm

gustafn

fixed regression test to use [::acs::test::url] instead of [ad_url] during regression test

Options
    • -2
    • +2
    ./test/sync-test-procs.tcl
Monday 15 Jul
2:04 pm

gustafn

improved spelling

Options
    • -2
    • +2
    ./sync-procs.tcl
  2. … 14 more files in changeset.
Wednesday 11 Oct 2023
6:58 pm

antoniop

Don't pollute the cache for other tests

Fixes acs-tcl.parameter__check_procs test when run after this one

Options
    • -0
    • +12
    ./test/authentication-procs.tcl
Wednesday 27 Sep 2023
4:53 pm

antoniop

Prefer the test authority: downstream local authorities may depend on other systems to perform additional checks, which may fail on a test user

Options
    • -6
    • +8
    ./test/sync-test-procs.tcl
Friday 15 Sep 2023
10:53 am

trenner

In case the user used an external_registry for login, we have to allow the redirect to a complete url

Options
    • -2
    • +4
    ./authentication-procs.tcl
Sunday 14 May 2023
1:09 pm

gustafn

External identity provider reform (part 2)

Use the external identity provider for refresh of logins. When a user

is logged in via an external identity provider, use the same identity

provider for a refresh when it expires. The expiration time is

controlled via the classical OpenACS parameters.

Note that in general, the same user might be authenticated via a

classical OpenACS authority (e.g. local authority) and/or via an

external one (e.g. Microsoft Identity Platform (Azure) or GitHub).

For single-sign-ons, when the token is still valid, the redirect to

the external identity provider does not mean necessarily that the use

is shown the external identity provider's login page.

Options
    • -14
    • +34
    ./authentication-procs.tcl
  2. … 3 more files in changeset.
Sunday 27 Nov 2022
7:08 pm

gustafn

improve spelling

Options
    • -3
    • +3
    ./authentication-procs.tcl
    • -1
    • +1
    ./test/authentication-procs.tcl
    • -4
    • +4
    ./test/local-procs.tcl
  4. … 2 more files in changeset.
Friday 30 Sep 2022
6:51 pm

antoniop

Handle acs-mail-lite conf regarding the recipient in the test

Options
    • -2
    • +11
    ./test/local-procs.tcl
3:31 pm

antoniop

Make sure test email is fine even when usernames are emails

Options
    • -3
    • +5
    ./test/sync-test-procs.tcl
3:19 pm

antoniop

Use lowercase letter to append to the fake username, so that if it should be an email, it will still be valid

Options
    • -2
    • +2
    ./test/sync-test-procs.tcl
Tuesday 20 Sep 2022
8:40 am

antoniop

Fix typo in test

Options
    • -1
    • +1
    ./test/local-procs.tcl
Monday 19 Sep 2022
6:44 pm

antoniop

Complete coverage for the ACS Service Contract 'auth_user_info'

Options
    • -0
    • +47
    ./test/local-procs.tcl
6:29 pm

antoniop

Complete coverage of ACS Service Contract 'auth_sync_retrieve' implementations

Options
    • -2
    • +35
    ./test/sync-test-procs.tcl
6:14 pm

antoniop

Test IMS_Enterprise_v_1p1 implementation of the auth_sync_process Service Contract

Options
    • -1
    • +213
    ./test/sync-test-procs.tcl
3:24 pm

antoniop

Rework parameter check:

the way the if was construed would allow e.g.:

1. a value for EmailRegistrationConfirmationToUserP = 'nottrue' to pass the first if, but fail the second.

2. a value EmailRegistrationConfirmationToUserP = 'false' to be "true" in the first if, but not in the second

In fact, if EmailRegistrationConfirmationToUserP should be a boolean, there is no need to further check the other parameters and variables in the second if. This change is not 100% equivalent to the previous code, but makes it clear that EmailRegistrationConfirmationToUserP should be interpreted as a boolean and fixes these inconsistencies.

Options
    • -26
    • +18
    ./local-procs.tcl
2:57 pm

antoniop

Make clear that parameters come from the same subsite

Options
    • -7
    • +12
    ./local-procs.tcl
2:55 pm

antoniop

Test implementations of ACS Service Contract 'auth_registration'

This exposes a bug in auth::local::registration::Register where the acs-subsite parameter NotifyAdminOfNewRegistrationsP is fetched from the ad_conn package_id, rather than the subsite_id

Options
    • -0
    • +296
    ./test/local-procs.tcl
Friday 16 Sep 2022
5:16 pm

antoniop

Fix signature of service contract implementation, that is defined with 3 and not 4 arguments, complete coverage of the auth_password contract local implementation

Options
    • -7
    • +2
    ./local-procs.tcl
    • -0
    • +98
    ./test/local-procs.tcl
4:31 pm

antoniop

Complete coverage of the auth_authentication contract 'local' implementation

Options
    • -0
    • +48
    ./test/local-procs.tcl
4:31 pm

antoniop

file local-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./test/local-procs.tcl
Monday 29 Aug 2022
4:17 pm

antoniop

Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

Options
    • -2
    • +2
    ./authority-procs.tcl
    • -2
    • +2
    ./sync-procs.tcl
    • -5
    • +5
    ./test/sync-test-procs.tcl
  4. … 31 more files in changeset.
Wednesday 20 Apr 2022
10:00 am

antoniop

Specify the empty value correctly in the authentication form fields

Options
    • -2
    • +2
    ./authentication-procs.tcl