• last updated 19 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Use the test machinery to simulate a cookie authentication

Inline sec_login_read_cookie, as it is a private api and would upset the bad calls test

Test auth::verify_account_status and complete coverage of acs-authentication

Test auth::update_local_account

Add auth::sync::job::get_authority_id to an existing test

Test auth::self_registration

Test auth::refresh_login

Cleanup code pasted twice by mistake

Bring more stuff into an existing test

    • -4
    • +13
    ./test/acs-authentication-procs.tcl
Test for auth::get_user_id and the whole login attempts api

Document actual behavior

Test auth::get_user_id

Test auth::get_register_authority proc

Fix test name

Test auth::get_all_registration_elements

Test more public api

Test auth::can_admin_system_without_authority_p public api

file authentication-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./test/authentication-procs.tcl
Test auth::authority::get_sc_impl_columns public api

file authority-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./test/authority-procs.tcl
Reduce divergency between oracle and postgres codebase

    • -19
    • +0
    ./test/acs-authentication-procs-oracle.xql
    • -19
    • +0
    ./test/acs-authentication-procs-postgresql.xql
    • -2
    • +11
    ./test/acs-authentication-procs.tcl
  1. … 6 more files in changeset.
improve spelling

  1. … 42 more files in changeset.
Bring the implementation of the "Search" operation of the "auth_search" service contract in line with the operation's definition by correcting the returned value ("username" instead of "user_id") and restricting the search to the local authority.

Streamline idiom: we are only interested in the user ids

Comment deprecated proc, which was before defined as private, because of a false positive in acs-api-browser.callgraph__bad_library_calls: the "Authenticate" operation in the spec of auth::authentication::create_contract is mistakenly interpreted as the deprecated proc

Make proc public, as was intended

Deprecated trivial private ad_user_login wrapper, which is already a public api

Promote logics in auth::authentication::Authenticate to a public api, which unfortunately cannot be the same due to the inconsistent naming, hence we have to create a new alias

Rationale:

- the proc provides some value to the user by choosing the right contract implementation depending on the authority

- we found occurrences in other packages downstream, and as internally this proc is calling only public api, one could just duplicate the whole thing and be compliant with our standards, which is not an improvement IMO

- the proc was already tested and documented

  1. … 1 more file in changeset.
Mark 'auth::can_admin_system_without_authority_p' as public, as it is used in 'acs-admin'

Mark 'auth::authority::get_sc_impl_columns' as public, as it is used in 'acs-admin'