• last updated 54 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- Rework acs-api-browser.callgraph__bad_calls automated test so that acs-service-contract calling contract implementation is considered OK

- Reinstate authentication service contracts as private

- Move test authority implementation to acs-authentication to remove intra-package dependency

acs-api-browser.callgraph__bad_call still fails because proc acs-tcl.install::xml::action::create-user calls private acs-authentication.auth::local::registration::Register... to be continued

  1. … 2 more files in changeset.
file test-authority-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./test-authority-procs.tcl
Make api public, complies with acs-api-browser.graph__bad_calls automated test

  1. … 1 more file in changeset.
Make service contract implementation public

Complies with acs-api-browser.callgraph__bad_calls

improve listing of test coverage

    • -1
    • +27
    ./test/acs-authentication-procs.tcl
  1. … 16 more files in changeset.
make listing of tested procs more complete

    • -12
    • +30
    ./test/acs-authentication-procs.tcl
  1. … 17 more files in changeset.
whitespace changes

set default value only in case of failure

Care about the parameter cache after test case

Set a bunch of test cases to 'production_safe'

Merge 'auth_authority_api' and 'auth_authority_delete' test cases, covering almost the same api

    • -195
    • +122
    ./test/acs-authentication-procs.tcl
Fix typo

don't rely on uppercase header field names

  1. … 10 more files in changeset.
prefer db_0or1row +"where exists" over db_string + "select case"

  1. … 3 more files in changeset.
Improve sql portability: oracle cannot select a boolean directly using exists

Reduce divergencies between oracle and postgres codebase

    • -9
    • +0
    ./test/acs-authentication-procs-oracle.xql
    • -10
    • +0
    ./test/acs-authentication-procs-postgresql.xql
prefer "ns_conn isconnected" over "ad_conn isconnected", since the latter might not notice changes in the connect state

  1. … 18 more files in changeset.
mprove spelling: move closer to the linux documentation recommendations

  1. … 17 more files in changeset.
Fallback to + #

Add missing authority_id on the 'auth_authenticate' testcase

Replace deprecated idiom

break overlong lines

Replace deprecated idiom

Improve documentation

Deprecate duplicated and untested proc auth::driver::GetParameters

Fix reported api, extend test

    • -3
    • +57
    ./test/acs-authentication-procs.tcl
Extend test to cover more api

    • -4
    • +37
    ./test/acs-authentication-procs.tcl
New test for auth::authority::edit and auth::authority::get_element

    • -1
    • +87
    ./test/acs-authentication-procs.tcl
Use existing api

Create new test for auth::authority::delete, make sure lookup cache is flushed in the (unlikely) case that an authority is deleted

    • -1
    • +41
    ./test/acs-authentication-procs.tcl