OpenACS / openacs-4 / packages / xowiki / tcl

form-field-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 9
Last Commit: 27 Dec 24
Commits this week: 0
Total Lines of Code (LoC): 2,945
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 06 Aug 2024
11:43 am

gustafn

spell "site-wide" consistently with a dash

Options
    • -2
    • +2
    ./form-field-procs.tcl
  2. … 34 more files in changeset.
Sunday 28 Jul 2024
7:00 pm

gustafn

Always use "--" in "dom parse" when document is interpolated

This is a safety measure to make sure that the document parsed is

never confused with an option, when the document starts with a "-". In

the best case, the error message provided by "dom parse" might be

misleading. This might be a problem for user contributed documents

(passed as variables, or return values from functions).

The double dash is supported in tdom since version 0.9.0.

Options
    • -2
    • +2
    ./form-field-procs.tcl
  2. … 18 more files in changeset.
Thursday 18 Jul 2024
12:02 pm

antoniop

Adjust TinyMCE behavior for the cornercase of a nested compound field with inline editor

Options
    • -2
    • +13
    ./form-field-procs.tcl
9:56 am

antoniop

Unset the "required" HTML5 attribute after the superclass initialization, because the textarea superclass will set it back again otherwise

Options
    • -2
    • +2
    ./form-field-procs.tcl
Monday 15 Jul 2024
2:04 pm

gustafn

improved spelling

Options
    • -3
    • +3
    ./form-field-procs.tcl
  2. … 14 more files in changeset.
Friday 21 Jun 2024
4:17 pm

antoniop

Make "standard" the default preset we apply to richtext editors

This is needed to have consistent site-wide default settings coming from the tcl level, such as connection context information and more.

Options
    • -2
    • +8
    ./form-field-procs.tcl
  2. … 1 more file in changeset.
1:25 pm

antoniop

Render richtext as div reform

Some richtext editors, such as TinyMCE in inline mode, do not expect

to enhance a textarea, but a div.

We could already override the rendering in the richtext editor

subclass, but this has the consequence that inheritance would be

interrupted. This prevents from plugging behavior in subclasses of the

richtext formfield.

This reform refactors render_richtext_as_div from the richtext

formfield into render_as_div on the textarea class. It also supports a

flag for subclasses to instruct the superclass that they should render

the field as div AFTER the whole inheritance chain was applied.

Options
    • -23
    • +41
    ./form-field-procs.tcl
12:47 pm

antoniop

Do not assume the repeated field will be attached as a direct child of the observed element

This is not the case in some downstream implementations

Options
    • -4
    • +4
    ./form-field-procs.tcl
11:35 am

antoniop

Include the attribute to identify a repeated field also when we render richtext as div

Options
    • -2
    • +2
    ./form-field-procs.tcl
Friday 14 Jun 2024
2:28 pm

antoniop

Port of downstream fix by Markus Moser on live since 2022-09-21

Fix regression after disabled formfield reform

Options
    • -3
    • +5
    ./form-field-procs.tcl
Friday 31 May 2024
1:34 pm

gustafn

improved spelling

Options
    • -2
    • +2
    ./form-field-procs.tcl
  2. … 1 more file in changeset.
Wednesday 08 May 2024
2:31 pm

antoniop

Provide a reference to the current object when configuring tinymce

Options
    • -1
    • +7
    ./form-field-procs.tcl
11:00 am

antoniop

Allow to completely override the imageSelectorDialog URL downstream

Options
    • -2
    • +12
    ./form-field-procs.tcl
Monday 06 May 2024
4:47 pm

antoniop

Introduce for richtext editors the concept of "preset"

A preset is an abstract set configurations designed to address a specific use case.

An example could be a preset for a "minimal" richtext editor, used in those forms where we want to limit the features a user should have access to. Other presets could address specific usages or applications.

Downstream developers can provide a set of ::richtext::$editor::preset::$preset procs, returning an options dict. This set of options will be merged other local configurations.

The same approach works in ad_forms and xowiki forms.

This also enables the use-case of switching to a different editor maintaining the existing application-specific configurations consistent.

Options
    • -2
    • +34
    ./form-field-procs.tcl
  2. … 1 more file in changeset.
Thursday 02 May 2024
4:06 pm

antoniop

TinyMCE XoWiki formfield integration

We introduce a new richtext mixin richtext::tinymce, requiring the richtext-tinymce package, currently integrating TinyMCE editor 7.0.1.

This implementation has been tested with regular, repeat, compound and repeatedcompound fields.

Downstream implementations based on this formfield can customize the editor configuration further, e.g. provide custom plugins via the api parameters.

Options
    • -1
    • +207
    ./form-field-procs.tcl
  2. … 1 more file in changeset.
2:47 pm

antoniop

Move back richtext formfield implementations in form-field-procs

Moving to a different file may affect dependencies defined on form-field-procs that also expect the richtext editor to be loaded. As breaking changes are not desirable now, we revert this reform.

Options
    • -1
    • +527
    ./form-field-procs.tcl
  2. … 1 more file in changeset.
Monday 29 Apr 2024
6:05 pm

antoniop

Move the specific richtext-editor implementations into an own file

Options
    • -527
    • +1
    ./form-field-procs.tcl
  2. … 1 more file in changeset.
Friday 05 Apr 2024
10:28 am

gustafn

Improved readability of configuration parameter "parameterSecret"

- Switched to camelCase for better readabilty and uniformity

- NaviServer configuration parameters are case insensitive, so no danger for backward compatibility

Options
    • -3
    • +3
    ./form-field-procs.tcl
  2. … 5 more files in changeset.
Thursday 29 Feb 2024
1:58 pm

antoniop

Introduce server-side validation for HTML5 date and time formfields

A "formats" parameter can be specified on the formfields indicating one or more formats that we want to enforce. The syntax for any of such format is that of the Tcl clock command.

Default values have been set according to the expected behavior of each form field type.

Empty values are always considered valid. If a field is required, this will be enforced in its own validator.

Options
    • -11
    • +69
    ./form-field-procs.tcl
  2. … 3 more files in changeset.
Thursday 14 Sep 2023
12:26 am

gustafn

move "-destroy_on_cleanup" towards the end of the parameter list

This change improves protection about ambiguous user input

Options
    • -8
    • +12
    ./form-field-procs.tcl
  2. … 8 more files in changeset.
Thursday 03 Aug 2023
12:31 pm

gustafn

fix indentation

Options
    • -2
    • +2
    ./form-field-procs.tcl
Tuesday 25 Jul 2023
11:54 am

gustafn

minor change in comment

Options
    • -2
    • +2
    ./form-field-procs.tcl
Friday 19 May 2023
7:46 pm

gustafn

fix for short-text-questions

for short-text-questions, correct when is empty (an empty

list) when multiple subquestions exists. The old code

did not handle this case and checked just for the existance

of the variable.

many thanks to markus moser for the fix.

Options
    • -8
    • +15
    ./form-field-procs.tcl
Wednesday 19 Apr 2023
7:31 pm

gustafn

improved parameter checking

Options
    • -2
    • +2
    ./form-field-procs.tcl
  2. … 3 more files in changeset.
Saturday 11 Mar 2023
11:56 am

gustafn

revert escaped change

Options
    • -2
    • +2
    ./form-field-procs.tcl
Monday 27 Feb 2023
7:42 pm

gustafn

rename helper form-field to avoid potential confusion with value checkers

Options
    • -5
    • +5
    ./form-field-procs.tcl
Wednesday 22 Feb 2023
1:57 pm

gustafn

increased value checking for paramter that might be influenced by user input

Options
    • -6
    • +6
    ./form-field-procs.tcl
  2. … 8 more files in changeset.
Tuesday 24 Jan 2023
12:28 pm

antoniop

Protect against malicious inputs, where the value won't be a list

Options
    • -3
    • +3
    ./form-field-procs.tcl
Thursday 22 Dec 2022
3:51 am

gustafn

improve strictness of tests

Options
    • -3
    • +5
    ./form-field-procs.tcl
  2. … 8 more files in changeset.
Thursday 15 Dec 2022
2:17 pm

gustafn

improve field validation

Options
    • -2
    • +2
    ./form-field-procs.tcl
  2. … 3 more files in changeset.