OpenACS / openacs-4 / packages / xowiki / tcl

folder-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 7
Last Commit: 27 Dec
Commits this week: 0
Total Lines of Code (LoC): 74
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 02 Feb
1:35 pm

gustafn

Improved consistency of appearance, when multiple CSS toolkits are in use

- This change makes sure that consistently [::xowiki::CSS toolkit] is

used instead of accessing the package parameter

"PreferredCSSToolkit" directly. This change is necessary for

handling e.g. of the parameter setting "default"

consistently. Previously, a "default" value could result in loading

the obsolete YUI .js and .css files.

- When "menu_entries" have multiple "config" entries, use the last one.

Options
    • -5
    • +11
    ./folder-procs.tcl
  2. … 1 more file in changeset.
Thursday 15 Dec 2022
8:30 pm

gustafn

improved checking of parameter values, which might be influenced via query parameters

Options
    • -4
    • +4
    ./folder-procs.tcl
  2. … 6 more files in changeset.
Tuesday 08 Nov 2022
2:24 pm

gustafn

Added support for passing parameter_name:value_constraint to xowiki::Package->get_parameter

- The get_parameter method can get values from query-parameters, therefore

we have to validate these.

- Use the new feature at several places (especially for boolean values)

- Still, more places should be checked

- bumped xowiki to 5.10.1d37

- bumped xotcl-core to 5.10.1d14

Options
    • -1
    • +1
    ./folder-procs.tcl
  2. … 10 more files in changeset.
Wednesday 24 Aug 2022
6:00 pm

gustafn

improved error message

make clear, what the name and what the item_id in the message are

Options
    • -2
    • +2
    ./folder-procs.tcl
Friday 01 Apr 2022
3:47 pm

gustafn

Alignments for Bootstrap 5

Also, use form.form for creating forms from the menubar instead of

old-strle ::xowiki::Forms. Aligned as well regression test to use

form.form.

Bump version number to 5.10.1d24

Options
    • -0
    • +1
    ./folder-procs.tcl
  2. … 9 more files in changeset.
Sunday 20 Feb 2022
6:06 pm

gustafn

Fixes for Oracle 19c: boolean and timestamp handling

- a clause "true" is invalid in Oracle SQL (using "1=1" is fine).

- function "now()" does not exist, use "CURRENT_TIMESTAMP" instead

- addressing all attributes in a join via "*" is not allowed, when other

attributes are used as well. Using e.g., "bt.*" is OK.

Options
    • -2
    • +3
    ./folder-procs.tcl
  2. … 1 more file in changeset.
Saturday 25 Dec 2021
5:10 pm

gustafn

Added archiving of items, reduced usage of images for icons

When an item is archived, it is not shown to plain users. Internally,

when an item is archived, the publish status is changed to "expired"

and removed from search/syndication. When an item is archived, it can

be brought via "toggle-publish-status" to state "production" again.

Future versions might rename the item in such conditions, but

currently, it is NOT renamed, so one cannot create one more item in

the same folder with the same name.

For realizing this functionality, the includelet "form-usages" accepts

now an additional optional value for "-buttons" named "archive". The

publish status toggle can be used now for switching from

"production"->"ready", "ready"->"production" and

"expired"->"production".

Additionally, the usage of .png images as icons was reduced by CSS

elements for easier styling (e.g., for different themes) and for

reducing less server requests and better responsiveness. In particular

the images for active.png and inactive.png are not necessary any more

and were removed.

Bumped version number to 5.10.1d8 to enforce loading of the message

keys.

Options
    • -13
    • +20
    ./folder-procs.tcl
  2. … 13 more files in changeset.
Saturday 13 Nov 2021
5:22 pm

gustafn

ease usage of "folder" includelet functions in other code by provide defaults

Options
    • -18
    • +24
    ./folder-procs.tcl
Thursday 28 Oct 2021
6:09 pm

gustafn

add publish status to default list of columns in child-resources

Options
    • -1
    • +4
    ./folder-procs.tcl
Thursday 16 Sep 2021
11:50 am

gustafn

reduce verbosity

Options
    • -1
    • +1
    ./folder-procs.tcl
Monday 09 Aug 2021
11:55 am

gustafn

more cleanup for setting of potentially unencoded return_url

Options
    • -2
    • +1
    ./folder-procs.tcl
  2. … 3 more files in changeset.
Thursday 29 Jul 2021
5:44 pm

gustafn

improve query variable checking

Options
    • -1
    • +1
    ./folder-procs.tcl
Sunday 25 Apr 2021
7:33 pm

gustafn

intensify argument checking

Options
    • -3
    • +3
    ./folder-procs.tcl
  2. … 2 more files in changeset.
Thursday 08 Apr 2021
10:15 pm

gustafn

made includelet "categories" folder aware (on can pass "parent" in form of a page-ref to the includelet)

refactored some of the code to increase reusability

Options
    • -30
    • +1
    ./folder-procs.tcl
  2. … 1 more file in changeset.
Thursday 05 Nov 2020
2:53 pm

antoniop

Reinstate retrieval of the package_id from the connection context in child-resources, the problem was that, when we required a connection context in create_form_page_instance, we did with no information whatsoever, which was then retrieved by e.g. ns_conn, sometimes wrongly (e.g. when one is running under the test package)

Options
    • -0
    • +1
    ./folder-procs.tcl
  2. … 1 more file in changeset.
Wednesday 04 Nov 2020
7:21 pm

antoniop

child-resources has already a package_id, getting it from the connection context makes the includelet susceptible to e.g. package initializations from the outside (see e.g. xowiki link_tests automated test)

Options
    • -1
    • +0
    ./folder-procs.tcl
Wednesday 09 Sep 2020
12:23 pm

gustafn

resolve message keys in titles

Options
    • -0
    • +3
    ./folder-procs.tcl
Wednesday 26 Aug 2020
8:34 pm

gustafn

make "instantiate_forms" a method of packages

this reads better than the previous variant based on the Weblog class.

Options
    • -7
    • +6
    ./folder-procs.tcl
  2. … 14 more files in changeset.
1:16 pm

gustafn

MenuBar reform

- MenuBars are now easier programmatically extensible (easier to maintain)

- refactored code, reduced scatted definitions (all configurations

at the same place)

- unified templating:

use body property @body.folderHTML@ instead of @folderhtml@

From the former API calls only "update_items" has changed,

all existing configurations (i.e. via folders or package parameter)

should continue to work.

== Changes:

One can now extend menubars via menu entry definition

{config -use YOURCONFIG -class YOURCLASS}

in two directions:

a) subclassing

define your own menubar class YOURCLASS, which should

be a subclass of ::xowiki::MenuBar

b) provide your own configuration method to provide

a more tailored configuration. This is performed

by defining a method "config=YOURCONFIG" for ::xowiki::MenuBar

The latter method is used for test-items, which can define a

test item folder by using

-- extra_menu_entries ---

{config -use test-items}

instead of

-- extra_menu_entries ---

{entry -name New.Item.TextInteraction -form en:edit-interaction.wf -query p.item_type=Text}

{entry -name New.Item.ShortTextInteraction -form en:edit-interaction.wf -query p.item_type=ShortText}

{entry -name New.Item.SCInteraction -form en:edit-interaction.wf -query p.item_type=SC}

{entry -name New.Item.MCInteraction -form en:edit-interaction.wf -query p.item_type=MC}

{entry -name New.Item.ReorderInteraction -form en:edit-interaction.wf -query p.item_type=Reorder}

{entry -name New.Item.UploadInteraction -form en:edit-interaction.wf -query p.item_type=Upload}

{entry -name New.App.OnlineExam -form en:online-exam.wf}

{entry -name New.App.InclassQuiz -form en:inclass-quiz.wf}

{entry -name New.App.InclassExam -form en:inclass-exam.wf}

See below for the definition of the "test-items" configuration method,

which is based on the default definitions. In general, the definition

in this method can be performed via menu-entries (same syntax as in

other menu entries) or via the MenuBar API (e.g. calling

":add_menu_item ...").

All configurations follow the following definition order

where later entries can refine earlier entries:

- package level: package parameter ExtraMenuEntries

- configuration method: use standard or tailored confguration methods

- per-folder definition: content of the extra_menu_entries

Note that the menu entry definition language supports as well

adding/clearing menus, etc., so almost everything can be refined.

I've noticed that the tlf* code has several scattered menu

definitions, which are as well done in every case differently.

By these definition one can define e.g. a learning-app folder (where

"New" can be used to define new app folders), and the app folders can

provide their own "New" entries, e.g. for clickers and

others. E.g. For "clickers" there is already on non-oo definition to

achieve similar things (which should be altered to the new method),

but on other places, there are some hard-coded definitions for root

folders, etc. The menubars of the learning-apps should be made this

way more consistent with the rest (e.g. using "New", supporting "table

of contents" for clipboard interactions, etc.)

namespace eval ::xowiki {

::xowiki::MenuBar instproc config=test-items {

{-bind_vars {}}

-current_page:required

-package_id:required

-folder_link:required

-return_url

} {

:config=default \

-bind_vars $bind_vars \

-current_page $current_page \

-package_id $package_id \

-folder_link $folder_link \

-return_url $return_url

return {

{clear_menu -menu New}

{entry -name New.Item.TextInteraction -form en:edit-interaction.wf -query p.item_type=Text}

{entry -name New.Item.ShortTextInteraction -form en:edit-interaction.wf -query p.item_type=ShortText}

{entry -name New.Item.SCInteraction -form en:edit-interaction.wf -query p.item_type=SC}

{entry -name New.Item.MCInteraction -form en:edit-interaction.wf -query p.item_type=MC}

{entry -name New.Item.ReorderInteraction -form en:edit-interaction.wf -query p.item_type=Reorder}

{entry -name New.Item.UploadInteraction -form en:edit-interaction.wf -query p.item_type=Upload}

{entry -name New.App.OnlineExam -form en:online-exam.wf}

{entry -name New.App.InclassQuiz -form en:inclass-quiz.wf}

{entry -name New.App.InclassExam -form en:inclass-exam.wf}

}

}

}

Options
    • -137
    • +122
    ./folder-procs.tcl
  2. … 16 more files in changeset.
Monday 24 Aug 2020
1:56 pm

gustafn

accept as page_ref for an object as well an item_id

This change simplify resolving items. raw ids seem

fine, since the listing are not persisted or moved between

OpenACS instances.

Options
    • -1
    • +2
    ./folder-procs.tcl
  2. … 1 more file in changeset.
Thursday 20 Aug 2020
7:03 pm

gustafn

Use full URL paths for bulk actions.

This change allows one to mark items from multiple child-resources

displayed on one page and add these to the clipboard. Use the same

logic for bluk-delete and bulk adding to the clipboard.

Options
    • -2
    • +4
    ./folder-procs.tcl
  2. … 2 more files in changeset.
Wednesday 29 Jul 2020
12:51 pm

gustafn

added/improved debugging hooks

Options
    • -1
    • +4
    ./folder-procs.tcl
Friday 17 Jul 2020
3:55 pm

gustafn

move comments around and improve it

Options
    • -7
    • +1
    ./folder-procs.tcl
  2. … 1 more file in changeset.
3:49 pm

gustafn

generalize handling of langstrings

this change updates yesterday's change with ml_title. It generalizes

the code by introducing an instproc named "update_langstring_property" that

generalizes setting of arbitrary "properties" based on a property "langstring"

that contains a dict of attributes in multiple languages (which are part

of the page, make it suitable also when the enduser cannot enter

message keys).

Options
    • -19
    • +10
    ./folder-procs.tcl
  2. … 1 more file in changeset.
Thursday 16 Jul 2020
7:11 pm

gustafn

added the flag "-language_specific" to child-resources to support differnt content per folder for user with different language settings

Options
    • -3
    • +35
    ./folder-procs.tcl
  2. … 1 more file in changeset.
Tuesday 12 May 2020
10:28 am

gustafn

address issue #3423: Move is_package_root_folder up in class hierarchy to CrItem

follow user wish

Options
    • -12
    • +13
    ./folder-procs.tcl
  2. … 3 more files in changeset.
Thursday 05 Mar 2020
12:31 pm

gustafn

fix typos and whitespace changes

Options
    • -1
    • +1
    ./folder-procs.tcl
  2. … 1 more file in changeset.
Tuesday 18 Feb 2020
7:51 pm

gustafn

revert change, since this breaks applications

if the distinction is needed, a better change is required,

either via configuration of a prefix, or via subclassing.

Options
    • -1
    • +1
    ./folder-procs.tcl
  2. … 1 more file in changeset.
2:59 pm

antoniop

Fix memory leak

Options
    • -1
    • +1
    ./folder-procs.tcl
Friday 14 Feb 2020
3:48 pm

antoniop

Name the child resources object consistently in order to differentiate it from other includelets

Options
    • -1
    • +1
    ./folder-procs.tcl