OpenACS / openacs-4 / packages / xowiki / tcl

chat-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 5
Last Commit: 27 Dec
Commits this week: 0
Total Lines of Code (LoC): 19
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 02 Sep
1:07 pm

antoniop

Copy all chat-relevant message keys into the xowiki package, so that the feature does not depend on the chat package and keys are local to the feature

Improves outcome of acs-lang lang_message_dependencies_are_fine automated test

Options
    • -5
    • +5
    ./chat-procs.tcl
  2. … 8 more files in changeset.
Friday 22 Mar
4:06 pm

antoniop

Use a simpler approach to achieve the intended result, which does not rely on events

Options
    • -19
    • +8
    ./chat-procs.tcl
Wednesday 20 Mar
12:25 pm

antoniop

Keep comments on the server side

Options
    • -7
    • +10
    ./chat-procs.tcl
11:24 am

antoniop

Ensure chat javascript is executed only when the chat itself is actually a part of the DOM

This may not be the case at the time of rendering, e.g. because the chat is rendered inside of a <template> tag and appended to the document at a later moment.

Options
    • -2
    • +19
    ./chat-procs.tcl
Tuesday 30 Jan
10:35 am

antoniop

Cleanup leftover library: latest javascript assumes XMLHttpRequest is supported

Options
    • -3
    • +1
    ./chat-procs.tcl
Friday 26 Jan
5:37 pm

antoniop

Chat reform

The goal of these changes is to reduce the "mode" specific javascript code in the chat implementation and reduce server-side guessing of browser capabilities.

- In the MessageRelay class from xotcl-core, we rework the javascript code sent to the connection when doing scripted streaming to make less assumptions about the functions defined in the parent scope

- In the chat code from xowiki, we move most of the logics to guess the mode into javascript, where we can test the actual capabilities of the browser without relying on the user agent

- The previously 4 javascript files dependant on the chat mode have been made into one

Options
    • -112
    • +17
    ./chat-procs.tcl
  2. … 7 more files in changeset.
2:14 pm

antoniop

When the mode is "streaming", use Server Sent Events instead of a "plain" endless request

This has the advantage of a clearer, less hacky api, which, for instance, does not require manual parsing of the partial response.

Options
    • -10
    • +9
    ./chat-procs.tcl
  2. … 4 more files in changeset.
11:30 am

antoniop

Cleanup leftover method: its logics were moved to the MessageRelay class

Options
    • -15
    • +1
    ./chat-procs.tcl
Friday 03 Nov 2023
6:52 pm

antoniop

Ensure scripts and internal use information are not rendered together with the content, in particular for dumber HTML renderer

Options
    • -7
    • +4
    ./chat-procs.tcl
Thursday 14 Sep 2023
12:26 am

gustafn

move "-destroy_on_cleanup" towards the end of the parameter list

This change improves protection about ambiguous user input

Options
    • -3
    • +3
    ./chat-procs.tcl
  2. … 8 more files in changeset.
Tuesday 30 May 2023
11:46 am

gustafn

improved spelling

Options
    • -20
    • +20
    ./chat-procs.tcl
  2. … 2 more files in changeset.
Tuesday 14 Mar 2023
4:08 pm

antoniop

Don't provide the url here, the require proc will takwe it from the connection, if any, and fallback otherwise

Options
    • -2
    • +2
    ./chat-procs.tcl
Monday 13 Mar 2023
3:04 pm

antoniop

Follow-up for https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Agustafn%3A20230313120323

- make sure the anonymous users nsv is created when the chat is instantiated

- make sure xo::cc is available when the anonymous identifier is generated

- handle in the Chat package, that the uid may not be a user, but an IP address

- adapt other chat skins to the new anonymous user logics

Options
    • -9
    • +14
    ./chat-procs.tcl
  2. … 5 more files in changeset.
1:03 pm

gustafn

Added support for anonymous users in chat class

Previous version of the chat class required a login for participating

in the chat. The new version also supports a mixed mode, with

authenticated and non-authenticated users can participate. For

unauthenticated users, the disambiguation is performed over the peer

IP address, similar to the xotcl-request-monitor. Instead of the raw

IP address, an artificial username is displayed for such users (like

e.g. userXXX).

For unauthenticated users, some differences apply:

- one cannot provide a link to the private page

- unauthenticated users cannot access the user-portrait

of authenticated users.

The GUI changes are only made on chat-skins/chat-classic.js, not on

the other skins.

Options
    • -13
    • +102
    ./chat-procs.tcl
  2. … 1 more file in changeset.
Tuesday 11 Jan 2022
4:52 pm

antoniop

Make sure configuration is applied consistently to all of the multiple instances of the chat class (add message, subscription, login...) that are involved in a conversation

This fixes certain options such as login and logout message not being applied correctly

Options
    • -4
    • +9
    ./chat-procs.tcl
Sunday 05 Dec 2021
6:11 pm

gustafn

reduce cache hits on nsv "::chat::Chat" and on "::chat::Chat-ID-options"

Options
    • -10
    • +19
    ./chat-procs.tcl
Tuesday 16 Nov 2021
12:04 pm

antoniop

Fully qualify the parameter command to not conflict with the class having the same name in the ::xo namespace

Options
    • -3
    • +3
    ./chat-procs.tcl
Monday 15 Nov 2021
6:23 pm

gustafn

prefer standard OpenACS API for accessing parameters

Options
    • -2
    • +2
    ./chat-procs.tcl
  2. … 4 more files in changeset.
Sunday 03 Oct 2021
7:38 pm

gustafn

use acs::clusterwide instead of xo::clusterwide

Options
    • -23
    • +23
    ./chat-procs.tcl
  2. … 5 more files in changeset.
Monday 28 Sep 2020
11:04 pm

gustafn

don't rely on uppercase header field names

Options
    • -2
    • +2
    ./chat-procs.tcl
  2. … 10 more files in changeset.
Wednesday 09 Sep 2020
12:22 pm

gustafn

factor out script wrappers

Options
    • -26
    • +18
    ./chat-procs.tcl
Friday 14 Aug 2020
9:12 pm

gustafn

reduce number of locks when NaviServer is used

Options
    • -12
    • +33
    ./chat-procs.tcl
Monday 13 Jan 2020
5:44 pm

antoniop

Prefer api to retrieve csp nonce, as it performs useful existance checks

Options
    • -8
    • +8
    ./chat-procs.tcl
Wednesday 14 Aug 2019
9:31 am

gustafn

improve spelling

Options
    • -2
    • +2
    ./chat-procs.tcl
  2. … 33 more files in changeset.
Tuesday 23 Jul 2019
4:14 pm

gustafn

prefer "nsf::is object" over ":isobject" or "info commands", since it is faster, more generic and can be used in all contexts

Options
    • -2
    • +2
    ./chat-procs.tcl
  2. … 15 more files in changeset.
Thursday 04 Jul 2019
7:51 pm

gustafn

modernize code: use resolver variables rather than method calls

Options
    • -2
    • +2
    ./chat-procs.tcl
  2. … 14 more files in changeset.
Wednesday 03 Jul 2019
10:33 pm

gustafn

reduce XOTcl 1.* idioms

Options
    • -2
    • +2
    ./chat-procs.tcl
  2. … 1 more file in changeset.
Wednesday 08 May 2019
4:33 pm

gustafn

- modernize code (remove "my")

- prefer fully qualified commands based on IDs

Options
    • -4
    • +4
    ./chat-procs.tcl
  2. … 33 more files in changeset.
Wednesday 10 Apr 2019
3:20 pm

antoniop

Prefer connchan message relay implementation (we check whether it is available anyway)

Options
    • -2
    • +2
    ./chat-procs.tcl
Thursday 28 Mar 2019
2:35 pm

antoniop

Make chat_id required, as path to the chat.tcl script is now immutable and all the potentially expensive package_id retrieval was only due to defaulting the chat_id. Use cases around already define their chat_id independently

Options
    • -21
    • +5
    ./chat-procs.tcl