OpenACS / openacs-4 / packages / notifications / tcl

sweep-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 27 Dec 24
Commits this week: 0
Total Lines of Code (LoC): 72
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 16 Feb 2022
2:19 pm

gustafn

Fixes for Oracle 19c: make query portable to Oracle by replacing USING by explicit ON joins

This fixed the following problem, where the problem is not easy to spot on first sight:

[16/Feb/2022:13:26:09][12845.7efd2d3e1700][-sched:0:41:22-] Error: nsoracle.c:1367:OracleSelect: error in `OCIStmtExecute ()': ORA-00904: "NOTIFICATION_REQUESTS"."USER_ID": invalid identifier

: SQL:

: select notification_id,

: notif_subject,

: notif_text,

: notif_html,

: file_ids,

: user_id,

: request_id,

: type_id,

: delivery_method_id,

: response_id,

: notif_date,

: notif_user,

: acs_permission.permission_p(notification_requests.object_id, !>>>!notification_requests.user_id, 'read') as still_valid_p

: from notifications inner join notification_requests using (type_id, object_id)

: inner join acs_objects on (notification_requests.request_id = acs_objects.object_id)

: left outer join notification_user_map using (notification_id, user_id)

: where sent_date is null

: and creation_date <= notif_date

: and (notif_date is null or notif_date < current_timestamp)

: and interval_id = :interval_id

Options
    • -7
    • +10
    ./sweep-procs.tcl
Tuesday 17 Aug 2021
11:54 am

gustafn

Notification request cleanup refactoring

One of the most expensive operations in large site is the cleanup for

notification_requests in situations, where the user has lost

permissions on an object, on which the user wanted to receive

notifications. This check was performed previously in

notification::sweep::cleanup_notifications via a permission check over

all notification requests, which can be very costly on large

sites. This change moves this cleanup into the actual notification

sending, where the permissions have to be sent anyhow.

Options
    • -18
    • +54
    ./sweep-procs.tcl
Saturday 06 Mar 2021
8:36 pm

gustafn

reduce public footprint

Options
    • -3
    • +3
    ./sweep-procs.tcl
  2. … 3 more files in changeset.
Monday 09 Nov 2020
6:38 pm

antoniop

Remove colon that gets confused as a bind variable

Options
    • -2
    • +2
    ./sweep-procs.tcl
Friday 06 Nov 2020
4:51 pm

antoniop

Solve a potential issue when one would cleanup "dynamic" notification requests: this was done directly on the table and could therefore leave dangling acs_objects around

- cleanup all acs_objects of type 'notification_request' that do not have a corresponding entry in the table (~35000 downstream)

- embed logic of delete_dynamic_requests query inside select_invalid_request_ids query, as there the deletion is done properly

Options
    • -6
    • +14
    ./sweep-procs.tcl
  2. … 3 more files in changeset.
Friday 15 Mar 2019
5:48 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -3
    • +28
    ./sweep-procs.tcl
  2. … 2 more files in changeset.