Activity OpenACS/openacs-4/packages/file-storage

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	66
Last Commit:	19:25
Commits this week:	0
Total Lines of Code (LoC):	1,025
Net change in LoC this week:	0

Commit Activity

last updated 2 hours ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

End Date:

Monday 02 Sep

2:54 pm

gustafn

bumped version number from development version to release version

- -11
- +11
./file-storage.info
- History
- Source
- Diff
./file-storage.info
… 93 more files in changeset.

11:40 am

gustafn

regenerated documentation

- -38
- +30
./www/doc/design.adp
- History
- Source
- Diff
./www/doc/design.adp
- -2
- +5
./www/doc/index.adp
- History
- Source
- Diff
./www/doc/index.adp
- -0
- +4
./www/doc/requirements.adp
- History
- Source
- Diff
./www/doc/requirements.adp
… 438 more files in changeset.

Friday 30 Aug

9:47 am

gustafn

improved spelling

- -2
- +2
./tcl/test/file-storage-procs.tcl
- History
- Source
- Diff
./tcl/test/file-storage-procs.tcl
… 15 more files in changeset.

Tuesday 27 Aug

4:27 pm

gustafn

silence expected errors during regression test

- -10
- +16
./tcl/test/file-storage-procs.tcl
- History
- Source
- Diff
./tcl/test/file-storage-procs.tcl

Tuesday 20 Aug

3:10 pm

gustafn

made regression test more robust

The test was failing, when the preferred language in the browser

was not "en". The test is now slightly better, but one should

use CSS classes (or data attributes) to pick the bulk actions

- -5
- +26
./tcl/test/webtest-procs.tcl
- History
- Source
- Diff
./tcl/test/webtest-procs.tcl

Thursday 01 Aug

10:03 am

gustafn

regenreated documentation (with non-finished release notes)

- -3
- +3
./www/doc/design.adp
- History
- Source
- Diff
./www/doc/design.adp
… 146 more files in changeset.

9:38 am

gustafn

fixed typoes in documentation

- -1
- +1
./www/doc/design.html
- History
- Source
- Diff
./www/doc/design.html
… 23 more files in changeset.

Wednesday 31 Jul

11:59 am

gustafn

improved spelling

- -4
- +4
./www/doc/design.adp
- History
- Source
- Diff
./www/doc/design.adp
… 29 more files in changeset.

Tuesday 30 Jul

3:45 pm

antoniop

Harden page contract

- -3
- +3
./www/copy.tcl
- History
- Source
- Diff
./www/copy.tcl

3:34 pm

antoniop

Harden page contract

- -2
- +2
./www/file-upload-confirm.tcl
- History
- Source
- Diff
./www/file-upload-confirm.tcl
… 2 more files in changeset.

Monday 22 Jul

4:00 pm

antoniop

Remove additional trapping of exception, which prevents the web agent to access the file-storage, if we had to mount it on the fly

- -30
- +30
./tcl/test/file-storage-procs.tcl
- History
- Source
- Diff
./tcl/test/file-storage-procs.tcl

Thursday 18 Jul

7:52 pm

gustafn

improved test coverage

- -2
- +5
./tcl/test/file-storage-procs.tcl
- History
- Source
- Diff
./tcl/test/file-storage-procs.tcl
… 1 more file in changeset.

Friday 31 May

3:57 pm

antoniop

Document more explicitly that we do not perform filesystem operations when deleting files via the fs:: api, but we rely on the content repository and its trigger+scheduled proc mechanism

- -3
- +18
./tcl/file-storage-procs.tcl
- History
- Source
- Diff
./tcl/file-storage-procs.tcl

Monday 26 Feb

4:05 pm

File-Storage used to generate downloaded archives in tgz format, to then switch to zip, more user-friendly, in particular outside the Linux world (See https://openacs.org/forums/message-view?message_id=557561). To ease the transition, a couple of parameters and relative API were introduced that would allow to choose the preferred command one should use. During this reform however, default parameter values in the tcl code became inconsistent with those in the info file. Furthermore, the chosen defaults were set as absolute paths to the executable, which is not friendly to non-linux environments, or other scenarios where the "typical" Linux filesystem structure cannot be assumed (e.g. containers, MacOS...).

The only usage of this parameters/api was in fact in the download-archive vuh. In upstream codebase, no package references this file, not even the file-storage itself. Upon review, one could see that the file would also allow to specify a custom download filename via the path, which could be considered questionable. It would also execute the command in a way that once again assumes some form of Linux environment (e.g. invoking bash).

Save for the ability to customize the archive format and the anti-feature of being able to manipulate the archive filename via the path, the script largely relplicates www/download-zip, in a better shape after a few reforms hinted by e.g. penetration tools.

Given the aformentioned considerations, I have decided to make download-archive a simple redirect to download-zip. Specifying the object_id via the path will keep working, while URLs out there expecting the name to change will not fail, but the name will not be modified. The archive format will from now on be assumed to be zip.