• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improved SQL query significantly by using "acs_permission.permission_p_recursive_array"

Before, a sample query used 300K buffers, now it is down to 2.6 buffers.

Under bad conditions, the old query used 2s or more.

  1. … 2 more files in changeset.
Cleanup the vestigial moderated_p flag

  1. … 9 more files in changeset.
Get rid of the intermediate "room-enter" page and enforce all of the relevant permission in place in the "chat" page, cleanup variables and update automated tests

  1. … 5 more files in changeset.
Allow to toggle chat active state from the chat list

  1. … 1 more file in changeset.
Chat reform:

- use consistently package_id to model belonging of a chat object to a particular package instead of the context_id

- set context_id to the package_id, as was already the case in practice, for permission checking

- make sure package_id exists and set it to the context_id in case it doesn't to handle legacy installations

  1. … 7 more files in changeset.
Fix typo

admin_p and user_p are actually never displayed, so it doesn't make sense to have them in the select clause. What makes sense is that we filter for those chats we can actually access

base_url is in fact just the package_url from the connection

base_url can be computed just once

Reduce divergency between oracle and postgres codebase and make the query less awkward

  1. … 2 more files in changeset.
Don't overquote URL