OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 11
Total Committers: 145
Last Commit: 09:40
Commits this week: 11
Total Lines of Code (LoC): 6,873,112
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 12 Mar 2021
8:07 pm

hectorr

Deal with 'search' input types, that are not in the 'form-control' class, in Bootstrap 3. See CSS comment for details.

Options
    • -0
    • +16
    /openacs-4/packages/openacs-bootstrap3-theme/www/resources/css/main.css
5:38 pm

hectorr

Whitespace changes

Options
    • -6
    • +6
    /openacs-4/packages/openacs-bootstrap3-theme/resources/widgets/search.adp
5:37 pm

hectorr

Use input type 'search' in search widget

Options
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap3-theme/resources/widgets/search.adp
4:29 pm

antoniop

Add basic include contract

Options
    • -0
    • +7
    /openacs-4/packages/xooauth/lib/authorize.tcl
2:26 pm

gustafn

make "util_close_html_tags" public since it is called from public pages

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
2:21 pm

gustafn

make "dt_get_info" public since it is used from other packages

Options
    • -2
    • +2
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
11:28 am

antoniop

Remove extra url decoding, ns_parsequery embeds it already

Options
    • -2
    • +4
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
11:24 am

antoniop

Remove extra decoding ns_parsequery provides it already

Options
    • -2
    • +0
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
11:23 am

antoniop

Revert usage of builtin commands, as we need a specific decoding for oauth, not the urldecoding ns_parsequery embeds

Options
    • -1
    • +3
    /openacs-4/packages/xooauth/tcl/oauth-client-procs.tcl
    • -2
    • +4
    /openacs-4/packages/xooauth/tcl/oauth-procs.tcl
11:22 am

antoniop

Aolserver/Naviserver builtin ns-parsequery already embeds URL decoding

Options
    • -1
    • +1
    /openacs-4/packages/xooauth/www/admin/lti-test.tcl
Thursday 11 Mar 2021
7:09 pm

hectorr

Add 'fs_create_folder_using_api' test case, covering the 'fs::get_root_folder', 'fs::new_folder', 'fs::get_folder', 'fs::folder_p', 'fs::delete_folder', 'fs::rename_folder' and 'fs_get_folder_name' procs

Options
    • -1
    • +69
    /openacs-4/packages/file-storage/tcl/test/file-storage-procs.tcl
6:17 pm

hectorr

Whitespace changes

Options
    • -2
    • +1
    /openacs-4/packages/acs-subsite/tcl/test/acs-subsite-procs.tcl
5:59 pm

hectorr

Fix typo

Options
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/widget-procs.tcl
5:42 pm

hectorr

Use the new 'url' input type widget. Bump version number for dependency

Options
    • -3
    • +3
    /openacs-4/packages/calendar/calendar.info
    • -2
    • +2
    /openacs-4/packages/calendar/www/cal-item-new.tcl
5:35 pm

hectorr

Use the new 'url' input type widget

Options
    • -3
    • +3
    /openacs-4/packages/acs-admin/www/auth/authority.tcl
    • -1
    • +1
    /openacs-4/packages/xooauth/www/admin/lti-test.tcl
4:30 pm

hectorr

Whitespace changes

Options
    • -5
    • +18
    /openacs-4/packages/openacs-bootstrap3-theme/resources/templates/packages/acs-subsite/lib/login.tcl
4:25 pm

hectorr

Use the new 'email' input type widget

Options
    • -3
    • +14
    /openacs-4/packages/openacs-bootstrap3-theme/resources/templates/packages/acs-subsite/lib/login.tcl
    • -2
    • +13
    /openacs-4/packages/acs-subsite/lib/login.tcl
3:56 pm

hectorr

Use the new 'email' input type widget

Options
    • -2
    • +4
    /openacs-4/packages/acs-subsite/www/register/recover-password.tcl
3:51 pm

hectorr

Whitespace changes

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/members/member-invite.tcl
    • -5
    • +1
    /openacs-4/packages/acs-subsite/www/register/recover-password.tcl
3:40 pm

hectorr

Use the new 'url' and 'email' input type widgets

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/lib/user-info.tcl
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/members/member-invite.tcl
3:26 pm

hectorr

Use the new 'url' and 'email' input type widgets

Options
    • -2
    • +3
    /openacs-4/packages/acs-authentication/acs-authentication.info
    • -3
    • +3
    /openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
3:24 pm

hectorr

Remove duplicated code

Options
    • -18
    • +1
    /openacs-4/packages/acs-templating/tcl/widget-procs.tcl
3:23 pm

hectorr

Add new ad_form input types

Options
    • -2
    • +2
    /openacs-4/packages/acs-templating/acs-templating.info
    • -6
    • +77
    /openacs-4/packages/acs-templating/tcl/widget-procs.tcl
2:22 pm

hectorr

Use the 'search' input type in the search widget

Options
    • -5
    • +5
    /openacs-4/packages/acs-templating/tcl/widget-procs.tcl
11:51 am

hectorr

Whitespace changes

Options
    • -21
    • +12
    /openacs-4/packages/calendar/www/cal-item-create-recurrence.tcl
11:48 am

hectorr

Use the new ad_form 'number' input field. Bump version number for dependency.

Options
    • -5
    • +5
    /openacs-4/packages/calendar/calendar.info
    • -3
    • +5
    /openacs-4/packages/calendar/www/cal-item-create-recurrence.tcl
    • -2
    • +2
    /openacs-4/packages/calendar/www/view-list-display.tcl
11:46 am

antoniop

Use naviserver api to parse URL variables

Options
    • -12
    • +5
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
    • -2
    • +1
    /openacs-4/packages/xooauth/www/admin/lti-test.tcl
11:28 am

hectorr

Whitespace changes, breaking overlong lines, and removal of old *SQL*

Options
    • -40
    • +89
    /openacs-4/packages/faq/www/admin/q-and-a-add-edit.tcl
11:14 am

antoniop

Use naviserver api to parse URL variables

Options
    • -7
    • +3
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
    • -3
    • +1
    /openacs-4/packages/xooauth/tcl/oauth-client-procs.tcl
    • -4
    • +2
    /openacs-4/packages/xooauth/tcl/oauth-procs.tcl
    • -3
    • +2
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
Wednesday 10 Mar 2021
4:18 pm

antoniop

Final phasing out of acs_named_objects

- remove table creation

- update documentation

- provide an optional upgrade script to delete the table and the object type (commented out by default, as people might have defined object subtypes downstream).

Context: this table and the related machinery were created at a time where acs_objects where not as mature as they are now and would not include the "title" information. To retrieve the object name, the only option was the stored procedure acs_object.name, which was not scalable.

From an excerpt of the Changelog file:

.....

2004-03-31 jeffd

......

* packages/categories/tcl/category-trees-procs-oracle.xql:

* packages/categories/tcl/category-trees-procs-postgresql.xql:

acs_named_objects superflous now that title is in

acs_objects. need to fix the rest of the occurances though

......

This tells us that the phasing out has already been decided back in 2004, but delayed. One technical reason, could be that the acs_named_objects table would also materialize the translation, while the title column would store sometimes a message key, that would need to be translated manually. This is helpful when e.g. sorting by name in sql. However, only the faq and categories package would seem to make any use of the table and only the faq package would seem to maintain its values... This would make some UIs in the categories package practically useless since a long time.

Options
    • -2
    • +2
    /openacs-4/packages/categories/categories.info
    • -35
    • +0
    /openacs-4/packages/categories/sql/oracle/categories-init.sql
    • -0
    • +12
    /openacs-4/packages/categories/sql/oracle/upgrade/upgrade-1.1.5d3-1.1.5d4.sql
    • -2
    • +0
    /openacs-4/packages/categories/sql/postgresql/categories-drop.sql
    • -37
    • +0
    /openacs-4/packages/categories/sql/postgresql/categories-init.sql
    • -0
    • +10
    /openacs-4/packages/categories/sql/postgresql/upgrade/upgrade-1.1.5d3-1.1.5d4.sql
    • -78
    • +6
    /openacs-4/packages/categories/www/doc/o.adp
    • -88
    • +10
    /openacs-4/packages/categories/www/doc/o.html