OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 18 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 29 Aug 2022
3:02 pm

gustafn

implemented ad_html_security_check based on ns_parsehtml

Options
    • -44
    • +144
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
3:00 pm

antoniop

Shorten idiom

Options
    • -11
    • +2
    /openacs-4/packages/acs-templating/tcl/util-procs.tcl
2:54 pm

antoniop

Test template::util::is_nil

Options
    • -1
    • +24
    /openacs-4/packages/acs-templating/tcl/test/util-procs.tcl
1:53 pm

gustafn

Use "ns_parsehtml" for speed and correctness when available

The new NaviServer built-in command "ns_parsehtml" is used on

several occasions in the code when available, namely in

- util_close_html_tags

- escaping disallowed HTML tags in ad_text_to_html

- util_close_html_tags

The command "util_close_html_tags" has a long history of troubles,

since it was implemented originally based on regular expressions. It

was reported in Jan 2009, that the function took on certain forums

entries 6 to 9 hours (e.g. /forums/message-view?message_id=357753) to

finish. Therefore, at this time a quick version based on tdom was

introduced, which reduced at that time the performance to 7.3

seconds. However, the tdom-based version tend to fail on invalid HTML,

so it could cover only a few cases. The new "ns_parsehtml" is more

robust and works very stable on openacs.org with the know problem

cases. Furthermore, this version is also significantly faster than the

tdom version.

Options
    • -33
    • +269
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
    • -6
    • +17
    /openacs-4/packages/acs-tcl/tcl/test/html-conversion-procs.tcl
1:02 pm

antoniop

Fix doc

Options
    • -1
    • +1
    /openacs-4/packages/acs-content-repository/www/doc/guide/publish.adp
1:00 pm

antoniop

Deprecate template::util::array_to_vars and template::util::vars_to_array: their functionality can be easily inlined by using the array command

Options
    • -1
    • +3
    /openacs-4/packages/acs-content-repository/tcl/filter-procs.tcl
    • -2
    • +1
    /openacs-4/packages/acs-content-repository/www/doc/guide/publish.adp
    • -3
    • +2
    /openacs-4/packages/acs-content-repository/www/doc/guide/publish.html
    • -3
    • +11
    /openacs-4/packages/acs-templating/tcl/util-procs.tcl
12:34 pm

gustafn

improve spelling

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/acs-db-00-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/apm-install-procs.tcl
    • -10
    • +69
    /openacs-4/packages/acs-tcl/tcl/test/html-conversion-procs.tcl
    • -7
    • +7
    /openacs-4/packages/acs-tcl/tcl/test/object-test-case-procs.tcl
11:51 am

antoniop

Use existing api to tell whether a formfield is disabled or not and to set/unset disabled on a field, handle the case of checkboxes and select fields, where the attribute should not be set whe it is false (e.g. disabled=0 == disabled)

This fixes upstream automated tests on xowiki and xowf

Options
    • -21
    • +31
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
    • -9
    • +9
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
11:47 am

antoniop

Fix typo

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/doc-check-procs.tcl
11:06 am

gustafn

fix bug in db_multirow_group_last_row_p

The bug showed up in bug-tracker usage of multirows,

where db_multirow_group_last_row_p was still expecting the

dict structure

Options
    • -3
    • +10
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
9:46 am

trenner

Give admins the possibility to deactivate pagination actions in the answer workflow of the inclass exam.

As default the pagination actions are shown in the answer workflow.

Options
    • -2
    • +2
    /openacs-4/packages/xowf/xowf.info
    • -0
    • +2
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -0
    • +2
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/xowf/lib/inclass-exam.wf
    • -0
    • +2
    /openacs-4/packages/xowf/resources/prototypes/select_question.form.page
    • -33
    • +35
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
Saturday 27 Aug 2022
10:35 pm

gustafn

use icanuse "ns_parsehtml" and new interface

Options
    • -5
    • +4
    /openacs-4/packages/acs-tcl/tcl/test/doc-check-procs.tcl
10:34 pm

gustafn

added icanuse rule for ns_parsehtml

Options
    • -0
    • +1
    /openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
10:30 pm

gustafn

Give people the chance to use OpenACS with WithDeprecatedCode set to 0

When OpenACS is configured with loading of deprecated procs

deactivated, files like deprecated-procs.tcl are not

loaded. Therefore, these files should only contain code, which was

deprecated at LEAST ONE RELEASE EARLIER, such that site admins have one

release time to fix calls to deprecated code.

This change reverts in part Antonio's commit from 26 Aug 2022 which

causes errors like the following on openacs.org:

Error in include template "/var/www/openacs.org/packages/news/lib/news":

invalid command name "ad_parameter_all_values_as_list"

Options
    • -4
    • +24
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
    • -22
    • +10
    /openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl
Friday 26 Aug 2022
8:26 pm

gustafn

fix documentation

Options
    • -2
    • +2
    /openacs-4/packages/xml-rpc/tcl/xml-rpc-procs.tcl
3:00 pm

antoniop

Deprecate ad_parameter_all_values_as_list: it does not provide much value and was also often use improperly

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-file-procs.tcl
    • -15
    • +1
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
    • -2
    • +21
    /openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl
    • -30
    • +9
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
    • -2
    • +0
    /openacs-4/packages/acs-tcl/tcl/test/html-conversion-procs.tcl
2:06 pm

antoniop

tmpfile page contract filter reform:

do not allow acs-subsite TmpDir parameter to define where the tmpfolder is located anymore. This MUST be the one configured in the server-wide configuration. Tmpfiles cannot be in a subfolder of the tmpfolder, they MUST be direct children instead. A tmpfile MUST exist beforehand and be owned, be readable and writable by the user running the nsd process. This complies with the definition of a tmpfile by AolServer/NaviServer when they are created to store content coming from a file upload.

Options
    • -5
    • +5
    /openacs-4/packages/acs-subsite/acs-subsite.info
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -36
    • +2
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
    • -24
    • +10
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
    • -28
    • +0
    /openacs-4/packages/acs-tcl/tcl/test/security-procs.tcl
Thursday 25 Aug 2022
6:01 pm

antoniop

Extend tmpfile filter to behave in the "old way" (default), or in strict mode e.g. tmpfile(strict), enforcing the behavior for tmpfile in Aolserver/Naviserver when a form is processed

Options
    • -12
    • +30
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
5:37 pm

antoniop

Reimplement ad_page_contract_filter_proc_tmpfile using security::safe_tmpfile_p

Some of the features implemented by this filter have been ported into the api, namely the possibility to fetch the valid temp folders from the subsite TmpDir parameter and the possibility to relax the check and allow also files deeper in the tmpfolder hierachy.

Notably, the hardcoded tmpfolders "/var/tmp" and "/tmp" have NOT been ported. One should configure these values via the many available options. security::safe_tmpfile_p is also more restrictive when a file exists, because it checks for ownership and read and write permissions on the file.

Options
    • -3
    • +42
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
    • -17
    • +8
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
    • -1
    • +30
    /openacs-4/packages/acs-tcl/tcl/test/security-procs.tcl
4:16 pm

antoniop

Comment WIP

Options
    • -6
    • +6
    /openacs-4/packages/acs-tcl/tcl/parameter-procs.tcl
3:12 pm

antoniop

Declare proc coverage

Options
    • -0
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/http-client-procs.tcl
    • -0
    • +1
    /openacs-4/packages/acs-templating/tcl/test/file-procs.tcl
3:09 pm

antoniop

Factor the payload building behavior in util::http::post into its own proc, so that it can be reused elsewhere

Options
    • -69
    • +170
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
2:45 pm

antoniop

Make also sure the tmpfile from the widget exists beforehand, when validating: we don't want users to "explore" our tmpdir with bogus values that just look sane

Options
    • -3
    • +3
    /openacs-4/packages/acs-templating/acs-templating.info
    • -1
    • +1
    /openacs-4/packages/acs-templating/tcl/file-procs.tcl
    • -11
    • +24
    /openacs-4/packages/acs-templating/tcl/test/data-procs.tcl
2:37 pm

antoniop

Add must_exist flag to enforce a safe tmpfile to already exist

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -4
    • +9
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
    • -1
    • +6
    /openacs-4/packages/acs-tcl/tcl/test/security-procs.tcl
1:44 pm

gustafn

Fixed bug in util_convert_line_breaks_to_html

The code deleted spaces around certain tags, while - according to the

documentation, only line breaks should be removed from there.

Extended regression test.

Options
    • -4
    • +5
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
    • -5
    • +14
    /openacs-4/packages/acs-tcl/tcl/test/html-conversion-procs.tcl
1:37 pm

antoniop

Improve doc

Options
    • -3
    • +3
    /openacs-4/packages/acs-templating/tcl/file-procs.tcl
1:34 pm

antoniop

Revert to previous template::widget::file behavior of accepting input in a form of a list of 3 elements (e.g. without a .tmpfile in the request), but introduce validation so that we enforce all widget values to be in the proper format and the files to be "safe"

Options
    • -3
    • +3
    /openacs-4/packages/acs-templating/acs-templating.info
    • -0
    • +1
    /openacs-4/packages/acs-templating/catalog/acs-templating.en_US.ISO-8859-1.xml
    • -42
    • +83
    /openacs-4/packages/acs-templating/tcl/file-procs.tcl
    • -7
    • +14
    /openacs-4/packages/acs-templating/tcl/test/data-procs.tcl
    • -0
    • +244
    /openacs-4/packages/acs-templating/tcl/test/file-procs.tcl
1:34 pm

antoniop

file file-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-templating/tcl/test/file-procs.tcl
1:29 pm

antoniop

Bring test closer to reality

Options
    • -6
    • +14
    /openacs-4/packages/file-storage/tcl/test/webtest-procs.tcl
1:25 pm

antoniop

Introduce security::safe_tmpfile_p checking whether a file belongs to the configured tmpfolder and respects other constraints

The plan is to use it to improve input validations

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -1
    • +54
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
    • -0
    • +45
    /openacs-4/packages/acs-tcl/tcl/test/security-procs.tcl