OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 14
Total Committers: 146
Last Commit: 25 Nov
Commits this week: 14
Total Lines of Code (LoC): 7,560,967
Net change in LoC this week: 146

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 26 Jun 2022
9:37 pm

gustafn

security::cookie_name: since this is used in acs-lang, it has to be public

Options
    • -13
    • +0
    /openacs-4/packages/acs-tcl/tcl/apm-procs-oracle.xql
    • -11
    • +0
    /openacs-4/packages/acs-tcl/tcl/apm-procs-postgresql.xql
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-procs.tcl
    • -3
    • +21
    /openacs-4/packages/acs-tcl/tcl/parameter-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
9:37 pm

gustafn

150px is not enough. In general, these setting should be performed via style files.

Options
    • -3
    • +3
    /openacs-4/packages/acs-subsite/lib/login.tcl
9:35 pm

gustafn

Fixed broken link in login and logout widgets

The problem were the links for the main subsite, since on the main subsite,

the resulting link is e.g. //register/logout, which is intpreted as

an URL without a schema (e.g. //openacs.org), leading the errors.

Options
    • -3
    • +3
    /openacs-4/packages/openacs-bootstrap5-theme/resources/widgets/login.tcl
9:32 pm

gustafn

removed onsolte comments

Options
    • -3
    • +2
    /openacs-4/packages/xotcl-core/tcl/cr-procs.tcl
9:31 pm

gustafn

added same-site lax for js-handling of cookies

Options
    • -1
    • +2
    /openacs-4/packages/cookie-consent/tcl/cookie-consent-procs.tcl
9:30 pm

gustafn

fix false positive of regression test

Options
    • -1
    • +1
    /openacs-4/packages/acs-templating/tcl/richtext-procs.tcl
9:29 pm

gustafn

fix warning (including some false positives) in regression test

Options
    • -0
    • +1
    /openacs-4/packages/xowiki/catalog/xowiki.de_DE.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/xowiki/catalog/xowiki.en_US.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/xowiki/catalog/xowiki.es_ES.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/xowiki/catalog/xowiki.it_IT.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/personal-notification-procs.tcl
    • -4
    • +4
    /openacs-4/packages/xowiki/tcl/test/api-test-procs.tcl
9:28 pm

gustafn

acs::test::user::delete: added flag -delete_created_acs_objects and fix regression test for file-storage

Options
    • -2
    • +2
    /openacs-4/packages/acs-automated-testing/acs-automated-testing.info
    • -3
    • +10
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
    • -1
    • +2
    /openacs-4/packages/acs-automated-testing/tcl/coverage-procs.tcl
    • -2
    • +14
    /openacs-4/packages/acs-automated-testing/www/admin/index.tcl
    • -3
    • +3
    /openacs-4/packages/file-storage/file-storage.info
    • -3
    • +4
    /openacs-4/packages/file-storage/tcl/test/file-storage-procs.tcl
5:19 pm

gustafn

Fixed calling info in call-graph, marked verbose test as "stress"

Options
    • -4
    • +7
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl
3:01 pm

gustafn

modernize adp file

Options
    • -1
    • +1
    /openacs-4/packages/survey/lib/portlet.adp
    • -1
    • +1
    /openacs-4/packages/survey/www/index.adp
    • -3
    • +2
    /openacs-4/packages/survey/www/admin/one-respondent.adp
    • -3
    • +2
    /openacs-4/packages/survey/www/admin/one.adp
    • -1
    • +1
    /openacs-4/packages/survey/www/admin/site-wide-survey.adp
    • -1
    • +1
    /openacs-4/packages/survey/www/admin/view-text-responses.adp
1:06 pm

gustafn

removed code factored out to the separate "captcha" package

Options
    • -2
    • +0
    /openacs-4/packages/acs-templating/catalog/acs-templating.de_DE.ISO-8859-1.xml
    • -2
    • +0
    /openacs-4/packages/acs-templating/catalog/acs-templating.en_US.ISO-8859-1.xml
    • -2
    • +0
    /openacs-4/packages/acs-templating/catalog/acs-templating.it_IT.ISO-8859-1.xml
    • -906
    • +0
    /openacs-4/packages/acs-templating/resources/fonts/LiberationSans-Regular.ttf
    • -2
    • +1
    /openacs-4/packages/acs-templating/sql/oracle/acs-templating-create.sql
    • -12
    • +0
    /openacs-4/packages/acs-templating/sql/oracle/captcha-create.sql
    • -13
    • +0
    /openacs-4/packages/acs-templating/sql/oracle/upgrade/upgrade-5.10.1d0-5.10.1d1.sql
    • -2
    • +1
    /openacs-4/packages/acs-templating/sql/postgresql/acs-templating-create.sql
    • -10
    • +0
    /openacs-4/packages/acs-templating/sql/postgresql/captcha-create.sql
    • -13
    • +0
    /openacs-4/packages/acs-templating/sql/postgresql/upgrade/upgrade-5.10.1d0-5.10.1d1.sql
    • -353
    • +0
    /openacs-4/packages/acs-templating/tcl/captcha-procs.tcl
    • -163
    • +0
    /openacs-4/packages/acs-templating/tcl/test/captcha-procs.tcl
1:05 pm

gustafn

Added the message catalog and the fonts to this package to keep things separated.

TODO: The message key "Please_enter_the_captcha" is not used on upstream code and could be deleted.

maybe, something from the downstram captcha code was not provide upstream.

Options
    • -2
    • +2
    /openacs-4/packages/captcha/captcha.info
    • -0
    • +5
    /openacs-4/packages/captcha/catalog/captcha.de_DE.ISO-8859-1.xml
    • -0
    • +5
    /openacs-4/packages/captcha/catalog/captcha.en_US.ISO-8859-1.xml
    • -0
    • +5
    /openacs-4/packages/captcha/catalog/captcha.it_IT.ISO-8859-1.xml
    • -0
    • +906
    /openacs-4/packages/captcha/resources/fonts/LiberationSans-Regular.ttf
    • -2
    • +2
    /openacs-4/packages/captcha/tcl/captcha-procs.tcl
    • -2
    • +1
    /openacs-4/packages/captcha/tcl/test/captcha-procs.tcl
1:05 pm

gustafn

file captcha.de_DE.ISO-8859-1.xml was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/captcha/catalog/captcha.de_DE.ISO-8859-1.xml
1:05 pm

gustafn

file LiberationSans-Regular.ttf was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/captcha/resources/fonts/LiberationSans-Regular.ttf
1:05 pm

gustafn

file captcha.it_IT.ISO-8859-1.xml was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/captcha/catalog/captcha.it_IT.ISO-8859-1.xml
1:05 pm

gustafn

file captcha.en_US.ISO-8859-1.xml was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/captcha/catalog/captcha.en_US.ISO-8859-1.xml
12:32 pm

gustafn

Factored out captcha package from acs-templating, since it introduces too many external dependencies

Furthermore, as it is, this does not work under macOS (and probably not on *BSD, or windows)

and breaks regression test.

Options
    • -0
    • +35
    /openacs-4/packages/captcha/captcha.info
    • -0
    • +12
    /openacs-4/packages/captcha/sql/oracle/captcha-create.sql
    • -0
    • +5
    /openacs-4/packages/captcha/sql/oracle/captcha-drop.sql
    • -0
    • +10
    /openacs-4/packages/captcha/sql/postgresql/captcha-create.sql
    • -0
    • +5
    /openacs-4/packages/captcha/sql/postgresql/captcha-drop.sql
    • -0
    • +362
    /openacs-4/packages/captcha/tcl/captcha-procs.tcl
    • -0
    • +163
    /openacs-4/packages/captcha/tcl/test/captcha-procs.tcl
12:32 pm

gustafn

file captcha.info was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/captcha/captcha.info
12:32 pm

gustafn

file captcha-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/captcha/tcl/captcha-procs.tcl
    • -0
    • +0
    /openacs-4/packages/captcha/tcl/test/captcha-procs.tcl
12:32 pm

gustafn

file captcha-drop.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/captcha/sql/oracle/captcha-drop.sql
    • -0
    • +0
    /openacs-4/packages/captcha/sql/postgresql/captcha-drop.sql
12:32 pm

gustafn

file captcha-create.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/captcha/sql/oracle/captcha-create.sql
    • -0
    • +0
    /openacs-4/packages/captcha/sql/postgresql/captcha-create.sql
Saturday 25 Jun 2022
2:06 pm

gustafn

remove deprecated call

Options
    • -2
    • +2
    /openacs-4/packages/caldav/tcl/caldav-procs.tcl
2:05 pm

gustafn

improve comments, such that is is clear what command to use instead

Options
    • -4
    • +4
    /openacs-4/packages/acs-templating/tcl/deprecated-procs.tcl
2:05 pm

gustafn

deactivate captcha test for the time being

Options
    • -0
    • +1
    /openacs-4/packages/acs-templating/tcl/test/captcha-procs.tcl
10:52 am

gustafn

we need the upgrade script, since the automatic aler just kicks in, when the constraint does not exist. Antonio was right.

Nevertheless, it would be a nice feature, if the ORM would handle this.

Options
    • -1
    • +14
    /openacs-4/packages/xowiki/tcl/upgrade/upgrade.tcl
10:25 am

gustafn

remove useless upgrade scripts (xotcl-core does this automatically on reloads)

Options
    • -32
    • +1
    /openacs-4/packages/xowiki/tcl/upgrade/upgrade.tcl
Friday 24 Jun 2022
5:02 pm

antoniop

Document and enforce expected behavior when Forms are deleted: this is forbidden and returns an error as long as they have instances

Options
    • -0
    • +139
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
2:55 pm

antoniop

Follow up of https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Agustafn%3A20220622174910

In the end we need the upgrade logic, as the ORM will kick in only if the column is just being created

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -1
    • +15
    /openacs-4/packages/xowiki/tcl/upgrade/upgrade.tcl
2:51 pm

antoniop

Do not attempt to load downstream-only workflows at startup

Downstream, the cod will stay as it is and maintained as a local modification

Options
    • -1
    • +0
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
11:16 am

gustafn

reduce verbosity

Options
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl