Activity OpenACS/

After https://cvs.openacs.org/changelog/OpenACS?cs=MAIN%3Adaveb%3A20080908165252, in template::list::write_csv we started looping through the list "elements", rather than the "display_elements". This prevents specifying different sets of columns to be returned depending on the "-formats" and "-selected_format" options in template::list::create. Many thanks to Oasi Software that customized this proc a long time ago, so that I could realize where the problem was.

- -2
- +2
/openacs-4/packages/acs-templating/tcl/list-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/list-procs.tcl

3:59 pm

antoniop

Fix blind spot when setting the return_url

- -9
- +10
/openacs-4/packages/news/www/item-create-3.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/item-create-3.tcl

3:41 pm

antoniop

Do not abort the script until we are done with e.g. notifications and such

- -5
- +4
/openacs-4/packages/news/www/item-create-3.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/item-create-3.tcl

3:29 pm

antoniop

Whitespace cleanup

- -4
- +4
/openacs-4/packages/news/www/item-create.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/item-create.tcl
- -13
- +13
/openacs-4/packages/news/www/preview.tcl
- History
- Source
- Diff
/openacs-4/packages/news/www/preview.tcl

3:27 pm

antoniop

Fix typo

- -2
- +2
/openacs-4/packages/news/tcl/news-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/news-procs.tcl

10:36 am

antoniop

Refactor query to go over the fs hierachy, rather than the permission one, add remarks

- -15
- +17
/openacs-4/packages/file-storage/tcl/file-storage-procs.tcl
- History
- Source
- Diff
/openacs-4/.../file-storage-procs.tcl

7:48 pm

antoniop

Recover logic went missing after refactoring (with some remarks)

- -2
- +33
/openacs-4/packages/file-storage/tcl/file-storage-procs.tcl
- History
- Source
- Diff
/openacs-4/.../file-storage-procs.tcl

7:17 pm

antoniop

Comment deprecated proc, which was before defined as private, because of a false positive in acs-api-browser.callgraph__bad_library_calls: the "Authenticate" operation in the spec of auth::authentication::create_contract is mistakenly interpreted as the deprecated proc

- -16
- +16
/openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
- History
- Source
- Diff
/openacs-4/.../authentication-procs.tcl

4:01 pm

antoniop

Make proc public, as was intended

- -2
- +2
/openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
- History
- Source
- Diff
/openacs-4/.../authentication-procs.tcl

9:02 am

gustafn

passing "-debug" flag explicitly to nsf::proc

- -3
- +8
/openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/00-proc-procs.tcl

8:59 am

gustafn

whitespace changes

- -9
- +8
/openacs-4/packages/acs-tcl/tcl/site-node-apm-integration-procs.tcl
- History
- Source
- Diff
/openacs-4/.../site-node-apm-integration-procs.tcl
- -2
- +3
/openacs-4/packages/acs-content-repository/tcl/content-item-procs.tcl
- History
- Source
- Diff
/openacs-4/.../content-item-procs.tcl
- -19
- +1
/openacs-4/packages/acs-content-repository/tcl/content-revision-procs.tcl
- History
- Source
- Diff
/openacs-4/.../content-revision-procs.tcl

10:25 pm

gustafn

fix last commit (many thanks to Thomas Renner)

- -2
- +3
/openacs-4/packages/xowf/lib/inclass-exam-answer.wf
- History
- Source
- Diff
/openacs-4/.../inclass-exam-answer.wf

10:15 pm

gustafn

made includelet "categories" folder aware (on can pass "parent" in form of a page-ref to the includelet)

refactored some of the code to increase reusability

- -30
- +1
/openacs-4/packages/xowiki/tcl/folder-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/folder-procs.tcl
- -9
- +62
/openacs-4/packages/xowiki/tcl/includelet-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../includelet-procs.tcl

10:11 pm

gustafn

make treeview more compact

- -4
- +3
/openacs-4/packages/xowiki/tcl/tree-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/tree-procs.tcl
- -0
- +7
/openacs-4/packages/xowiki/www/resources/xowiki-bootstrap3-specific.css
- History
- Source
- Diff
/openacs-4/.../xowiki-bootstrap3-specific.css

6:18 pm

antoniop

Deprecated trivial private ad_user_login wrapper, which is already a public api

- -7
- +11
/openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
- History
- Source
- Diff
/openacs-4/.../authentication-procs.tcl
- -2
- +2
/openacs-4/packages/acs-authentication/tcl/password-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../password-procs.tcl

5:52 pm

antoniop

Promote logics in auth::authentication::Authenticate to a public api, which unfortunately cannot be the same due to the inconsistent naming, hence we have to create a new alias

Rationale:

- the proc provides some value to the user by choosing the right contract implementation depending on the authority

- we found occurrences in other packages downstream, and as internally this proc is calling only public api, one could just duplicate the whole thing and be compliant with our standards, which is not an improvement IMO

- the proc was already tested and documented