• last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
return full result in reporting modes

avoid potential exceptions for empty submissions

avoid potential tilde substitution (many thanks to Markus Moser)

stick to varnames used on many other places for the same information

improve styling

    • -1
    • +1
    /openacs-4/packages/xowf/lib/inclass-exam.wf
Improve display of print-answers:

- provide API functions "get_duration" and "get_IPs" for ans

- added info box "runtime-data" in inclass-exam.wf about changed submissions

(number of revisions, duration, all IP addresses of the submission)

- added message keys for "nr_changes" and "duration"

- updated CSS to handle "runtime-data"

- bump version number to 5.10.0d16

    • -11
    • +20
    /openacs-4/packages/xowf/lib/inclass-exam.wf
New API method WorkflowPage.get_revision_sets

Collect information about the revisions of the current workflow

instance as a list of ns_sets.

    • -0
    • +20
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
reduce verbosity

add new API command for the connection context (e.g. xo:cc): eval_as_user {-user_id:integer cmd}

add "source_dependent" in case, some package extend e.g. the test_item class

perform per-user rendering for the exam protocol.

A more general solution will follow soon.

    • -7
    • +9
    /openacs-4/packages/xowf/lib/inclass-exam.wf
Redefine faq questions and answers as text, the same as downstream, then redefine all database function api so that argument types are taken from table definition

file upgrade-5.10.0d7-5.10.0d8.sql was initially added on branch oacs-5-10.

call table data formatter, when avaliable

provide pretty-print methods for tabular data views

Handle the case when one is trying to access a non-existing room

    • -2
    • +10
    /openacs-4/packages/chat/www/room-enter.tcl
Improve last change and document it properly.

Set outdated HTML attributes as depreacted.

    • -4
    • +28
    /openacs-4/packages/xowiki/tcl/link-procs.tcl
- make repeatable formfields better configurable (provde max number for repeated elements via parameter)

- improve robustness, when a form field does not provide a "correction" instance variable after "make_correct"

- imporve documentation

Remove href from the variables we inspect the item for in a file link:

this variable is most likely set, therefore embed_options will be non-empty and most links downstream will be rendered via <embed>

instead than a plain link.

Furthermore, it does appear as non standard according to e.g. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/embed and would probably conflict with the src attribute, which is always set.

support show_max for short_text answers

omit question title in inclass-exam

Keep returning 0 when no transcript is created, as the code expects

Uniform the quoting criteria when dealing with transcripts:

- transcripts are stored as they are, no quoting in the data we store (and therefore HTML should be avoided)

- transcripts are displayed quoted, therefore disabling any effect from HTML eventually present in the content

- bring the logics to build transcript content in the api to avoid duplication

- avoid sending the transcript content to transcript-new-2, as we can generate it server side

Note: storing transcripts as a pre-formatted chunk of text is probably not the best approach, as any changes to the formatting cannot be applied to pre-existing data without a delicate upgrade. This new approach will make <br> tags inside older transcripts visible...

    • -12
    • +10
    /openacs-4/packages/chat/lib/current-messages.adp
    • -28
    • +68
    /openacs-4/packages/chat/tcl/xotcl-chat-procs.tcl
Remove lefrover files

add editor hints, whitespace changes

whitespace changes

- Convert frequenty used functions from plpgsql

to strict and stable SQL functions, which allow

the PostgreSQL more optimizations

* acs_group__member_p/3

* site_node__url/1

- bump version number to 5.10.0d27

file upgrade-5.10.0d26-5.10.0d27.sql was initially added on branch oacs-5-10.

use SQL functions (instead of plpgsql) defined as stabe and strict for

* content_folder__is_folder

* content_folder__is_sub_folder, and

* content_folder__is_empty

... having as well more sane constructs returning boolean values

file upgrade-5.10.0d10-5.10.0d11.sql was initially added on branch oacs-5-10.

improve performance of content_folder__is_sub_folder