• last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Increase proc coverage

Deprecate fs::add_created_version

This api was nowhere used in upstream code, however, allowed to create a new file object revision by text content, different from fs::add_version, which would only allow to create a revision from a file.

As the two apis were otherwise identical, I have ported the behavior of fs::add_created_version info fs::add_version.

The new fs::add_version will also take many defaults for unspecified parameters from the existing content item.

Make service contract implementation private

Give priority to the information provided explicitly to the api (the forum_id) in order to determine the package id and fallback to the connection context only when this is not available

    • -12
    • +37
    /openacs-4/packages/forums/tcl/forums-procs.tcl
Provide package_id to the api explicitly

Cleanup unused variables

Cleanup reference to non-existent parameter

Test checking for attachments availability by providing explicit package_id

Do not require a connection context to determine whether attachments are enabled on a certain package and provide explicit available information instead

Harden page contract

Value checkers will let empty values pass through

E.g. for a query like "?popular=&summary=1", the checker won't complain for "popular" being empty. Make sure empty values are normalized to false.

    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
Harden page contract

Enforce data type of hidden fields, add missing parameters to the page contract

Make Service Contract implementation private

    • -3
    • +6
    /openacs-4/packages/faq/tcl/faq-procs.tcl
Fix bulk_mail::url using the site_node api

Complete coverage for the package

This test currently fails because a query was lost for bulk_mail::url

Deprecate bulk_mail::pretty_name, trivial wrapper to the parameter api, which won't do anything to ensure that the pretty_name we are retrieving actually comes from a bulk-mail instance

Deprecate bulk_mail::parameter, which implements a global parameter logic

For now, the occurrences have just been inlined (fixing also the inconsistent naming PrettyName vs pretty_name). A future reform might create a proper global parameter for this.

    • -2
    • +6
    /openacs-4/packages/dotlrn/www/spam.tcl
Complete coverage for the package

Fix syntax for proc coverage

Expect arbitrary arguments on inherited methods, detect instance variables that should be passed to the object creation in save_new

Test chat room creation

This test now fails because certain acs_object metadata are not taken from instance variables, but from the context

file chat-test-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/chat/tcl/test/chat-test-procs.tcl
Fix typo, make mailNickname required as per Microsoft specs (see https://learn.microsoft.com/en-us/graph/api/team-clone?view=graph-rest-1.0&tabs=http#request-body)

Many thanks to Sebastian Scheder

Deprecate template::form::export, superseded by export_vars

Test all the cornercases of this api as intended, without using ad_tmpnam

Make sure the cal item notification has at least 1 subscriber

increased value checking for paramter that might be influenced by user input

    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/import-procs.tcl
    • -7
    • +7
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Use a test admin user to run the ics test

Fix typo