OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 35
Total Committers: 146
Last Commit: 28 Dec
Commits this week: 35
Total Lines of Code (LoC): 7,561,384
Net change in LoC this week: 37

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 23 Feb 2021
4:49 pm

antoniop

Formatting changes

Options
    • -8
    • +6
    /openacs-4/packages/acs-messaging/tcl/acs-messaging-procs-oracle.xql
    • -5
    • +5
    /openacs-4/packages/acs-messaging/tcl/acs-messaging-procs-postgresql.xql
4:36 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -10
    • +0
    /openacs-4/packages/acs-messaging/tcl/acs-messaging-procs-oracle.xql
    • -6
    • +0
    /openacs-4/packages/acs-messaging/tcl/acs-messaging-procs-postgresql.xql
    • -2
    • +5
    /openacs-4/packages/acs-messaging/tcl/acs-messaging-procs.tcl
4:19 pm

antoniop

Whitespace cleanup

Options
    • -24
    • +24
    /openacs-4/packages/general-comments/tcl/general-comments-procs.tcl
4:08 pm

antoniop

Make api public as other packages might need to retrieve the portlet name

Options
    • -2
    • +3
    /openacs-4/packages/calendar-portlet/tcl/calendar-full-portlet-procs.tcl
    • -2
    • +3
    /openacs-4/packages/calendar-portlet/tcl/calendar-list-portlet-procs.tcl
    • -2
    • +3
    /openacs-4/packages/dotlrn-portlet/tcl/dotlrn-portlet-procs.tcl
3:42 pm

antoniop

Flush also the threaded cache whenever we flush the permission cache, so that one does not need to call this private api directly

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/acs-permissions-procs.tcl
2:16 pm

antoniop

Reinstate get_portal_id_not_cached as private, replace occurrences with public api

Options
    • -2
    • +2
    /openacs-4/packages/dotlrn/tcl/community-procs.tcl
    • -2
    • +2
    /openacs-4/packages/dotlrn-static/tcl/dotlrn-static-procs.tcl
2:08 pm

antoniop

Reinstate get_portal_id_not_cached as private, flush the cache before calling public api instead

Options
    • -1
    • +1
    /openacs-4/packages/dotlrn/tcl/dotlrn-procs.tcl
    • -3
    • +4
    /openacs-4/packages/dotlrn-calendar/tcl/dotlrn-calendar-procs.tcl
    • -3
    • +4
    /openacs-4/packages/dotlrn-forums/tcl/dotlrn-forums-procs.tcl
    • -3
    • +4
    /openacs-4/packages/dotlrn-fs/tcl/dotlrn-fs-procs.tcl
2:02 pm

antoniop

Fix api:

upstream dotlrn mounts dotlrn-forums at /dotlrn/forums/, but testcase dotlrn_forums__applet_portlet (dotlrn-forums) deletes such node and replaces it with a new one at /dotlrn/applets/forums/. As site_node::get_package_url does not get flushed, the api will expect to find the mounted instance at the old URL, which now resolves to the parent dotlrn instead! Fix this by not relying on the cache to retrieve the applet node id.

Options
    • -4
    • +9
    /openacs-4/packages/dotlrn-forums/tcl/dotlrn-forums-procs.tcl
11:38 am

gustafn

improve test coverage

Options
    • -3
    • +60
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-core-db-tutorial-procs.tcl
11:38 am

gustafn

small performance improvement

Options
    • -5
    • +5
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
11:14 am

antoniop

Provide a cached public api, reinstate uncached api as private, replace occurrences

Options
    • -2
    • +2
    /openacs-4/packages/dotlrn-homework/tcl/test/dotlrn-homework-procs.tcl
    • -3
    • +11
    /openacs-4/packages/new-portal/tcl/portal-procs.tcl
10:37 am

antoniop

Do not invoke service contract implementations directly, use the public interface

Options
    • -13
    • +18
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
10:35 am

antoniop

Replace deprecated api

Options
    • -3
    • +3
    /openacs-4/packages/feed-parser/tcl/feed-parser-procs.tcl
Monday 22 Feb 2021
8:00 pm

antoniop

- Rework acs-api-browser.callgraph__bad_calls automated test so that acs-service-contract calling contract implementation is considered OK

- Reinstate authentication service contracts as private

- Move test authority implementation to acs-authentication to remove intra-package dependency

acs-api-browser.callgraph__bad_call still fails because proc acs-tcl.install::xml::action::create-user calls private acs-authentication.auth::local::registration::Register... to be continued

Options
    • -1
    • +16
    /openacs-4/packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl
    • -6
    • +6
    /openacs-4/packages/acs-authentication/tcl/local-procs.tcl
    • -0
    • +133
    /openacs-4/packages/acs-authentication/tcl/test-authority-procs.tcl
    • -133
    • +0
    /openacs-4/packages/acs-automated-testing/tcl/authority-procs.tcl
8:00 pm

antoniop

file test-authority-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-authentication/tcl/test-authority-procs.tcl
7:26 pm

antoniop

Reinstate apis as public, as they hold the current definition of an all-day event

Options
    • -15
    • +9
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-2-procs.tcl
6:43 pm

gustafn

avoid setting of unneeded function, reduce access to nsvs

Options
    • -1
    • +6
    /openacs-4/packages/search/tcl/search-init.tcl
    • -3
    • +2
    /openacs-4/packages/search/tcl/search-procs.tcl
6:41 pm

gustafn

provide a flushing interface to apm_package_id cache to avoid the need to call the uncached code directly

Options
    • -2
    • +11
    /openacs-4/packages/acs-tcl/tcl/apm-procs.tcl
    • -8
    • +9
    /openacs-4/packages/search/tcl/search-init.tcl
6:13 pm

gustafn

whitespace changes: break overlong lines

Options
    • -150
    • +176
    /openacs-4/packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl
6:01 pm

antoniop

Reinstate proc as private, remove dependency to such proc in external package

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-procs.tcl
    • -4
    • +6
    /openacs-4/packages/search/tcl/search-init.tcl
    • -1
    • +2
    /openacs-4/packages/search/www/search.tcl
5:56 pm

gustafn

make clear from the name that db_qd_prepare_queryfile_content is intended to be used in different packages

Options
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -7
    • +6
    /openacs-4/packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/test/file-test-procs.tcl
5:30 pm

antoniop

Whitespace cleanup

Options
    • -13
    • +13
    /openacs-4/packages/acs-tcl/tcl/apm-xml-procs.tcl
5:27 pm

antoniop

Make api public, complies with acs-api-browser.graph__bad_calls automated test

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/content-procs.tcl
    • -2
    • +4
    /openacs-4/packages/rss-support/tcl/rss-generation-service-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-xml-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl
5:25 pm

antoniop

Skip deprecated api that is neutralized by the next upgrade, reinstate deprecated api just for upgrade purposes, complies with acs-api-browser.graph__bad_calls automated test

Options
    • -2
    • +4
    /openacs-4/packages/forums/tcl/forums-install-procs.tcl
    • -3
    • +5
    /openacs-4/packages/forums/tcl/forums-sc-procs.tcl
5:13 pm

antoniop

Whitespace cleanup

Options
    • -7
    • +7
    /openacs-4/packages/forums/tcl/forums-sc-procs.tcl
5:12 pm

antoniop

Make api deprecated, complies with acs-api-browser.graph__bad_calls automated test

Options
    • -3
    • +19
    /openacs-4/packages/acs-tcl/tcl/ad-functional-procs.tcl
5:08 pm

antoniop

Make api deprecated, complies with acs-api-browser.graph__bad_calls automated test

Options
    • -5
    • +25
    /openacs-4/packages/acs-tcl/tcl/ad-functional-procs.tcl
4:51 pm

antoniop

Make api public, complies with acs-api-browser.graph__bad_calls automated test

Options
    • -2
    • +3
    /openacs-4/packages/calendar-portlet/tcl/calendar-portlet-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl
    • -2
    • +2
    /openacs-4/packages/dotlrn/tcl/community-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-file-procs.tcl
4:35 pm

antoniop

Whitespace cleanup

Options
    • -7
    • +7
    /openacs-4/packages/dotlrn/tcl/dotlrn-procs.tcl
4:34 pm

antoniop

Make api public, complies with acs-api-browser.graph__bad_calls automated test

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
    • -1
    • +1
    /openacs-4/packages/dotlrn/tcl/dotlrn-procs.tcl