• last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Cleanup acs_CopyText and inline the only usage found in the codebase with a modern replacement

The function was using deprecated idioms, see https://developer.mozilla.org/en-US/docs/Web/API/document/execCommand, and "PrivilegeManager" and the "netscape" property, both long discontinued.

On modern browsers, under the correct conditions, the function can be reimplemented via a oneliner (see https://developer.mozilla.org/en-US/docs/Web/API/Clipboard)

provide link to nsstats on startup page on fresh installations (when available)

fixed vertical placement of login link

fix for containarized applications: don't use configured location unless host-name-map is in place

containeraized applications with the hostnode map will still have a problem, but these are

less frequent. For these, a solution is still pending.

Shorten idiom

Modernize idioms via optional chaining

Prefer string interpolation via template literals

Cleanup trivial acs_initHtmlArea and inline its only usages in the codebase

Cleanup trivial acs_initHtmlArea and inline its only usages in the codebase

clear diry editor buffer

Cleanup trivial api, nowadays replaceable with a simple oneliner and inline the only usage found upstream

Use modern javascript and browser features to simplify the code

Use a better idiom to revert changes on the object, that e.g. will handle the same arrays and variables

Use an idiom that does not assume the form field to be a direct child of the form, which may not be true depending on the theme

Inline usages of acs_rte* js utilities in unmaintained packages and remove it from core.js

acs_rte* is most likely broken anyway, as nobody seems to define updateRTEs function...

Inline usages of acs_rte* js utilities in unmaintained packages and remove it from core.js

acs_rte* is most likely broken anyway, as nobody seems to define updateRTEs function...

    • -1
    • +15
    /openacs-4/packages/dbm/www/lib/master.tcl
    • -0
    • +14
    /openacs-4/packages/imsld/lib/imsld-master.tcl
Factor richtext-or-file javascript outside of the core.js

This may or not be a step on the road to deprecating this widget, which still sports inline event handlers and is used only by unmaintained packages.

file richtext-or-file.js was initially added on branch oacs-5-10.

added support to install theme from install.xml

    • -1
    • +21
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
added bootstrap-icons to module list

removed duplicated line

updated and sorted module aliases

Replace explicit observer approach for lazy loading with modern HTML features

- images: use the loading attribute to request lazy loading (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img#loading)

- audio: use the preload attribute to indicate that only metadata are needed at load time and not the entire media (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/audio#preload)

Ensure we are still connected before we try to render the error to the user

For instance, the error may have beeen triggered by unexpected lack of connection, e.g. when we try to return content after a redirect has already been issued.

    • -4
    • +12
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
Avoid ambiguity depending on whether the submission is rendered on its

own to the user or to the teacher in feedback mode e.g. as part of the

exam protocol

Update automated test: we should not expect the title to be the same when the state becomes "done", as we strip the information not relevant for an ongoing exam

Extend test: edit a different component of repeated compound 3 to also test that old and new values are stored as expected

Do not display information relevant only for an ongoing exam when this has been submitted

Also exclude unchecked checkboxes, the same as radio buttons, from the dictb entries returned from reading the form

Fixes xowiki.create_form_with_form_instance automated test

Extend and fix xowiki.create_form_with_form_instance automated test with respect to checkbox behavior

- simple checkboxes (normal and repeated): as we do not specify a value for those, the default should be expected, not the last option

- checkboxes in repeated compound fields: upon triavial re-editing, the values should stay the same

This change exposes a bug in acs::test::xpath::get_form_values