OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 22
Total Committers: 146
Last Commit: 26 Nov
Commits this week: 22
Total Lines of Code (LoC): 7,560,945
Net change in LoC this week: 141

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 18 Jul 2018
3:36 pm

antoniop

Revision of the index page:

- pass template properties according to conventions

- streamline boolean expressions

- fix UI, show purge button and its explanation when the actual form is generated

- make sql portable and bring it inline

- better exploit api

Options
    • -36
    • +0
    /openacs-4/packages/news-aggregator/www/index-postgresql.xql
    • -8
    • +16
    /openacs-4/packages/news-aggregator/www/index.adp
    • -50
    • +43
    /openacs-4/packages/news-aggregator/www/index.tcl
    • -14
    • +0
    /openacs-4/packages/news-aggregator/www/index.xql
12:31 pm

antoniop

Use db_0or1row flag to return an array natively, repair news_aggregator::aggregator::as_xml as for some reason creating the xml processing instruction via tDOM is broken on tDOM 0.8.3

Options
    • -10
    • +0
    /openacs-4/packages/news-aggregator/tcl/aggregator-procs-postgresql.xql
    • -16
    • +22
    /openacs-4/packages/news-aggregator/tcl/aggregator-procs.tcl
11:18 am

antoniop

Whitespace cleanup

Options
    • -27
    • +27
    /openacs-4/packages/news-aggregator/tcl/aggregator-procs.tcl
11:15 am

antoniop

Fix boolean adp expression, pass properties according to adp guidelines

Options
    • -3
    • +4
    /openacs-4/packages/news-aggregator/www/subscriptions.adp
11:08 am

antoniop

Package rework and maintenance

- deprecate undocumented news_aggregator::source::get_identifier as no mention was found in upstream code (fixes automated tests)

- put all portable sql inline

- rework all sql idioms that could be made portable

- remove leftover sql statements

- simplify idioms

Options
    • -34
    • +1
    /openacs-4/packages/news-aggregator/tcl/source-procs-postgresql.xql
    • -19
    • +24
    /openacs-4/packages/news-aggregator/tcl/source-procs.tcl
    • -12
    • +0
    /openacs-4/packages/news-aggregator/tcl/source-procs.xql
Tuesday 17 Jul 2018
11:15 pm

gustafn

- use information from acs_testing in api-browser: provide link for

test cases.

- new function: api_add_to_proc_doc for updating apidoc information

from other packages

- bump version of acs-automated testing to 5.10.0d4 and

acs-api-browser to 5.10.0d2

- toc includelet:

* new flag: "-renderer" (default "")

specify an explicit renderer. This is an alternative to the

classic "rendering by style", where there style determines the renderer.

* new flag: "-include_in_foldertree" (default true)

it is now possible to avoid inclusion of all folder-tree element

in the standard folder tree. Default set for backwards

compatibility.

Options
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/acs-api-browser.info
    • -2
    • +45
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -7
    • +7
    /openacs-4/packages/acs-api-browser/www/proc-view.tcl
    • -30
    • +27
    /openacs-4/packages/acs-automated-testing/acs-automated-testing.info
    • -2
    • +4
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
    • -4
    • +3
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-apm-procs.tcl
11:04 pm

gustafn

remove dead code

Options
    • -2
    • +1
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
9:20 pm

hectorr

Remove unused image

Options
    • binary
    /openacs-4/packages/assessment/www/resources/pb-bg.gif
9:15 pm

hectorr

Reduce code duplication: delete 'assessment/lib/progress-bar.*', essentially the same as 'acs-tcl/lib/static-progress-bar'

Options
    • -1
    • +1
    /openacs-4/packages/assessment/lib/feedback.adp
    • -24
    • +0
    /openacs-4/packages/assessment/lib/progress-bar.adp
    • -55
    • +0
    /openacs-4/packages/assessment/lib/progress-bar.tcl
8:41 pm

gustafn

improve rowcount expressions

Options
    • -2
    • +2
    /openacs-4/packages/dotlrn/www/applets-chunk.adp
    • -1
    • +1
    /openacs-4/packages/dotlrn/www/communities-chunk.adp
    • -1
    • +1
    /openacs-4/packages/dotlrn/www/community-types-chunk.adp
    • -1
    • +1
    /openacs-4/packages/dotlrn/www/dotlrn-main-portlet.adp
    • -4
    • +4
    /openacs-4/packages/dotlrn/www/manage-memberships.adp
    • -1
    • +1
    /openacs-4/packages/dotlrn/www/member-add.adp
    • -1
    • +1
    /openacs-4/packages/dotlrn/www/members.adp
    • -2
    • +2
    /openacs-4/packages/dotlrn/www/site-map.adp
    • -1
    • +1
    /openacs-4/packages/dotlrn/www/weblog-control-panel.adp
    • -1
    • +1
    /openacs-4/packages/dotlrn/www/admin/admin-add.adp
    • -1
    • +1
    /openacs-4/packages/dotlrn/www/admin/archived-communities.adp
    • -1
    • +1
    /openacs-4/packages/dotlrn/www/admin/class.adp
    • -1
    • +1
    /openacs-4/packages/dotlrn/www/admin/classes-chunk.adp
    • -1
    • +1
    /openacs-4/packages/dotlrn/www/admin/clubs.adp
    • -1
    • +1
    /openacs-4/packages/dotlrn/www/admin/community-types.adp
  16. … 33 more files in changeset.
8:30 pm

gustafn

improve rowcount expressions

Options
    • -1
    • +1
    /openacs-4/packages/acs-admin/www/index.adp
    • -1
    • +1
    /openacs-4/packages/acs-admin/www/subsites.adp
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/install/install-2.adp
    • -1
    • +1
    /openacs-4/packages/acs-admin/www/install/install.adp
    • -4
    • +4
    /openacs-4/packages/acs-admin/www/users/complex-search.adp
    • -1
    • +1
    /openacs-4/packages/acs-admin/www/users/search.adp
    • -1
    • +1
    /openacs-4/packages/acs-api-browser/www/deprecated.adp
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/www/index.adp
    • -1
    • +1
    /openacs-4/packages/acs-api-browser/www/proc-browse.adp
    • -3
    • +3
    /openacs-4/packages/acs-api-browser/www/proc-search.adp
    • -1
    • +1
    /openacs-4/packages/acs-authentication/lib/search.adp
    • -1
    • +1
    /openacs-4/packages/acs-automated-testing/www/index.adp
    • -1
    • +1
    /openacs-4/packages/acs-automated-testing/www/server.adp
    • -1
    • +1
    /openacs-4/packages/acs-automated-testing/www/admin/testcase.adp
    • -1
    • +1
    /openacs-4/packages/acs-content-repository/www/doc/method.adp
  16. … 62 more files in changeset.
5:48 pm

antoniop

Rework of news_aggregator::source::update

- replace deprecated calls

- replace array idioms with dict idioms

- bring portable sql inline

This was tested against RSS feeds used downstream on a vanilla instance

Options
    • -26
    • +1
    /openacs-4/packages/news-aggregator/tcl/source-procs-postgresql.xql
    • -82
    • +82
    /openacs-4/packages/news-aggregator/tcl/source-procs.tcl
    • -12
    • +0
    /openacs-4/packages/news-aggregator/tcl/source-procs.xql
5:42 pm

antoniop

Change adp expression so news can be displayed

Options
    • -1
    • +1
    /openacs-4/packages/news-aggregator/www/index.adp
4:25 pm

antoniop

Add trivial tests for the other different kinds of space

Options
    • -0
    • +4
    /openacs-4/packages/acs-tcl/tcl/test/html-conversion-procs.tcl
4:20 pm

antoniop

Support also the other kinds of whitespace

Options
    • -2
    • +6
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
3:40 pm

hectorr

Removed 'setResultEncoding' tdom option, which has no effect in Tcl > 8.0, and is removed in tdom > 0.9.0.

See upstream commit: http://tdom.org/index.html/info/d729de4c396d71ff

From the old docs: http://tdom.org/index.html/artifact/2a79d8cf33feacf9

dom setResultEncoding ?encodingName?

This option is for backward compatibility with Tcl 8.0. If tDOM is build

with any newer Tcl version this option does not has any effect.

If encodingName is not given the current global result encoding is

returned. Otherwise the global result encoding is set to encodingName.

All character data, attribute values etc. will then be converted from

UTF-8, which is delivered from the Expat XML parser, to the given 8 bit

encoding at XML/DOM parse time. Valid values for encodingName are:

utf-8, ascii, cp1250, cp1251, cp1252, cp1253, cp1254, cp1255, cp1256,

cp437, cp850, en, iso8859-1, iso8859-2, iso8859-3, iso8859-4, iso8859-5,

iso8859-6, iso8859-7, iso8859-8, iso8859-9, koi8-r.

Options
    • -2
    • +0
    /openacs-4/packages/news-aggregator/tcl/aggregator-procs.tcl
3:32 pm

hectorr

Whitespace changes + add editor hints

Options
    • -6
    • +6
    /openacs-4/packages/acs-admin/lib/password-update.tcl
    • -12
    • +12
    /openacs-4/packages/acs-api-browser/www/proc-search.tcl
    • -298
    • +298
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
    • -6
    • +6
    /openacs-4/packages/acs-lang/lib/change-locale-bar.tcl
    • -122
    • +122
    /openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl
    • -2
    • +1
    /openacs-4/packages/acs-tcl/lib/static-progress-bar.tcl
    • -37
    • +37
    /openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl
    • -8
    • +1
    /openacs-4/packages/acs-templating/tcl/list-procs.tcl
    • -158
    • +154
    /openacs-4/packages/acs-templating/tcl/wizard-procs.tcl
    • -426
    • +422
    /openacs-4/packages/assessment/lib/assessment.tcl
    • -2
    • +1
    /openacs-4/packages/assessment/lib/progress-bar.tcl
    • -42
    • +40
    /openacs-4/packages/assessment/www/asm-admin/add-edit-check.tcl
    • -191
    • +193
    /openacs-4/packages/assessment/www/asm-admin/item-stats.tcl
    • -7
    • +7
    /openacs-4/packages/assessment/www/asm-admin/one-a.tcl
    • -15
    • +16
    /openacs-4/packages/assessment/www/asm-admin/section-select.tcl
  16. … 12 more files in changeset.
3:28 pm

antoniop

Almost complete rewrite of news_aggregator::source::new

- replace deprecated calls

- remove code duplication

- don't loop through response items, as nothing is done with that information

- replace array idioms with dict idioms

- let stored procedure figure out the object_id

Works on WU RSS URLs on a vanilla instance

Options
    • -7
    • +6
    /openacs-4/packages/news-aggregator/tcl/source-procs-postgresql.xql
    • -60
    • +44
    /openacs-4/packages/news-aggregator/tcl/source-procs.tcl
    • -8
    • +0
    /openacs-4/packages/news-aggregator/tcl/source-procs.xql
2:20 pm

antoniop

Update documentation, as no mention to tag closing is made in the code and reimplement procedure exploiting builting tcl idioms (passes automated tests)

Options
    • -22
    • +11
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
1:42 pm

hectorr

Remove superflous parentheses

Options
    • -1
    • +1
    /openacs-4/packages/acs-admin/lib/password-update.tcl
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/apm/version-i18n-process-2.tcl
    • -2
    • +5
    /openacs-4/packages/acs-api-browser/www/proc-search.tcl
    • -2
    • +2
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-lang/lib/change-locale-bar.tcl
    • -2
    • +2
    /openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/lib/static-progress-bar.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/list-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/wizard-procs.tcl
    • -1
    • +1
    /openacs-4/packages/assessment/lib/assessment.tcl
    • -1
    • +1
    /openacs-4/packages/assessment/lib/progress-bar.tcl
    • -1
    • +1
    /openacs-4/packages/assessment/www/asm-admin/add-edit-check.tcl
    • -4
    • +4
    /openacs-4/packages/assessment/www/asm-admin/item-stats.tcl
    • -2
    • +2
    /openacs-4/packages/assessment/www/asm-admin/one-a.tcl
  16. … 15 more files in changeset.
1:10 pm

hectorr

Whitespace changes

Options
    • -8
    • +8
    /openacs-4/packages/acs-subsite/lib/user-info.tcl
    • -5
    • +5
    /openacs-4/packages/acs-subsite/www/group-leave.tcl
1:09 pm

hectorr

Remove superflous parentheses

Options
    • -3
    • +3
    /openacs-4/packages/acs-subsite/lib/user-info.tcl
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/group-leave.tcl
8:51 am

antoniop

Remove commented leftover debugging statement, add comment about why we need to name the list by folder_id

Options
    • -3
    • +4
    /openacs-4/packages/file-storage/www/folder-chunk.tcl
Monday 16 Jul 2018
6:43 pm

antoniop

Put template::list name back as parametric, because this code might be included multiple times

Options
    • -1
    • +1
    /openacs-4/packages/file-storage/www/folder-chunk-oracle.xql
    • -1
    • +1
    /openacs-4/packages/file-storage/www/folder-chunk-postgresql.xql
    • -1
    • +1
    /openacs-4/packages/file-storage/www/folder-chunk.adp
    • -2
    • +4
    /openacs-4/packages/file-storage/www/folder-chunk.tcl
5:52 pm

antoniop

Redefine this page as ad_include_contract, therefore removing all hardcoded variable checks and exploit builtin checks, remove duplicated definitions and queries, streamline template::list definitions in a way its is readable and simpler to maintain

Options
    • -16
    • +6
    /openacs-4/packages/file-storage/www/folder-chunk-oracle.xql
    • -62
    • +7
    /openacs-4/packages/file-storage/www/folder-chunk-postgresql.xql
    • -1
    • +1
    /openacs-4/packages/file-storage/www/folder-chunk.adp
    • -104
    • +116
    /openacs-4/packages/file-storage/www/folder-chunk.tcl
5:37 pm

antoniop

Pass also orderby to the includelet

Options
    • -1
    • +1
    /openacs-4/packages/file-storage/www/index.adp
4:28 pm

gustafn

simplyfy expressions, remove useless file

Options
    • -2
    • +3
    /openacs-4/packages/acs-templating/tcl/form-procs.tcl
    • -1
    • +4
    /openacs-4/packages/assessment/lib/session-items.tcl
    • -43
    • +0
    /openacs-4/packages/assessment/www/feedback.tcl
    • -5
    • +8
    /openacs-4/packages/rss-support/tcl/rss-generation-procs.tcl
3:55 pm

antoniop

Trim whitespaces

Options
    • -12
    • +12
    /openacs-4/packages/file-storage/www/folder-chunk.tcl
3:55 pm

antoniop

Remove unnecessary parentheses and idioms, state query variables explicitly

Options
    • -9
    • +20
    /openacs-4/packages/file-storage/www/folder-chunk.tcl
9:44 am

gustafn

don't pass deprecated argumentent "-user_id" to fs::get_folder_contents_count

Options
    • -3
    • +3
    /openacs-4/packages/attachments/www/attach.tcl
    • -7
    • +4
    /openacs-4/packages/file-storage/www/index.tcl