OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 10
Total Committers: 146
Last Commit: 14 Nov
Commits this week: 10
Total Lines of Code (LoC): 7,560,821
Net change in LoC this week: 22

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 19 Jun 2018
5:09 pm

antoniop

Remove divergency between oracle and postgres codebase, rewrite proc to avoid duplication and give it a proper and correct documentation

Quoting commit that replaced db_list_of_lists with db_list, de facto hiding every additional column from results:

-------

Author: Peter Marklund <peter_marklund@fastmail.fm>

Date: Mon Nov 24 14:50:34 2003 +0000

changing the get_attachments procs to use db_list instead of db_list_of_lists and the PG query to only return the id

-------

Options
    • -23
    • +0
    /openacs-4/packages/attachments/tcl/attachments-procs-oracle.xql
    • -24
    • +0
    /openacs-4/packages/attachments/tcl/attachments-procs-postgresql.xql
    • -29
    • +50
    /openacs-4/packages/attachments/tcl/attachments-procs.tcl
4:10 pm

hectorr

Fix typo

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
3:54 pm

hectorr

Whitespace cleanup

Options
    • -39
    • +39
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
3:45 pm

hectorr

Whitespace changes

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/group-master.tcl
    • -5
    • +5
    /openacs-4/packages/ajaxhelper/www/doc/default-master.tcl
    • -29
    • +29
    /openacs-4/packages/general-comments/www/index.tcl
    • -2
    • +2
    /openacs-4/packages/new-portal/www/themes/kelp-theme/site-master-kelp.tcl
    • -1
    • +1
    /openacs-4/packages/notifications/www/manage.tcl
    • -3
    • +3
    /openacs-4/packages/openacs-bootstrap3-theme/resources/widgets/login.tcl
    • -5
    • +5
    /openacs-4/packages/openacs-default-theme/lib/plain-master.tcl
    • -121
    • +118
    /openacs-4/packages/theme-selva/tcl/selva-procs.tcl
    • -2
    • +2
    /openacs-4/packages/theme-selva/www/selva-site-master.tcl
    • -2
    • +2
    /openacs-4/packages/theme-selva/www/doc/selva-site-master.tcl
    • -17
    • +17
    /openacs-4/packages/theme-zen/lib/lrn-master.tcl
    • -49
    • +49
    /openacs-4/packages/theme-zen/tcl/navigation-procs.tcl
3:35 pm

hectorr

Prefer 'acs_user::get_element ...' to 'person::name ...', in cases when 'person' is a user, as it doesn't rely on util_memoize_cache.

Options
    • -1
    • +1
    /openacs-4/packages/acs-subsite/www/group-master.tcl
    • -1
    • +1
    /openacs-4/packages/acs-templating/resources/masters/plain-streaming-head.tcl
    • -2
    • +2
    /openacs-4/packages/ajaxhelper/www/doc/default-master.tcl
    • -2
    • +2
    /openacs-4/packages/general-comments/www/index.tcl
    • -1
    • +1
    /openacs-4/packages/new-portal/www/themes/kelp-theme/site-master-kelp.tcl
    • -1
    • +1
    /openacs-4/packages/notifications/www/manage.tcl
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap3-theme/resources/widgets/login.tcl
    • -2
    • +2
    /openacs-4/packages/openacs-default-theme/lib/plain-master.tcl
    • -1
    • +1
    /openacs-4/packages/openacs-default-theme/lib/plain-streaming-head.tcl
    • -2
    • +2
    /openacs-4/packages/theme-selva/tcl/selva-procs.tcl
    • -1
    • +1
    /openacs-4/packages/theme-selva/www/selva-site-master.tcl
    • -1
    • +1
    /openacs-4/packages/theme-selva/www/doc/selva-site-master.tcl
    • -2
    • +2
    /openacs-4/packages/theme-zen/lib/lrn-master.tcl
    • -2
    • +2
    /openacs-4/packages/theme-zen/tcl/navigation-procs.tcl
12:08 pm

gustafn

don't drop constraints, but fix it.

Options
    • -2
    • +2
    /openacs-4/packages/news/www/item-create-3.tcl
    • -2
    • +2
    /openacs-4/packages/news/www/preview.tcl
    • -2
    • +2
    /openacs-4/packages/news/www/admin/revision-add-3.tcl
11:51 am

antoniop

Similar to www/index page:

- remove divergency between oracle and postgres code

- improve localization

- add author column to UI as was probably meant to be (author was selected, but not used)

- use multirow builtin count instead of manually generated one

Options
    • -29
    • +0
    /openacs-4/packages/general-comments/www/admin/index-oracle.xql
    • -28
    • +0
    /openacs-4/packages/general-comments/www/admin/index-postgresql.xql
    • -11
    • +39
    /openacs-4/packages/general-comments/www/admin/index.tcl
11:35 am

antoniop

Remove divergency between oracle and postgres codebase

Options
    • -28
    • +0
    /openacs-4/packages/general-comments/www/admin/delete-oracle.xql
    • -26
    • +0
    /openacs-4/packages/general-comments/www/admin/delete-postgresql.xql
    • -10
    • +10
    /openacs-4/packages/general-comments/www/admin/delete.tcl
11:28 am

antoniop

Reduce divergency between oracle and postgres codebase plus some small optimization

Options
    • -25
    • +0
    /openacs-4/packages/news-portlet/www/news-portlet-oracle.xql
    • -24
    • +0
    /openacs-4/packages/news-portlet/www/news-portlet-postgresql.xql
    • -9
    • +32
    /openacs-4/packages/news-portlet/www/news-portlet.tcl
11:21 am

antoniop

Port downstream fix from Thomas Renner

Options
    • -2
    • +2
    /openacs-4/packages/news/www/preview.tcl
10:45 am

gustafn

fix for issue #3348

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/apm-procs.tcl
9:58 am

antoniop

Remove leftover xql and prefer acs_user::get api, as doesn't rely on util_memoize cache

Options
    • -28
    • +0
    /openacs-4/packages/general-comments/www/delete-oracle.xql
    • -26
    • +0
    /openacs-4/packages/general-comments/www/delete-postgresql.xql
    • -9
    • +8
    /openacs-4/packages/general-comments/www/delete.tcl
9:48 am

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -26
    • +0
    /openacs-4/packages/assessment/lib/comments-chunk-oracle.xql
    • -26
    • +0
    /openacs-4/packages/assessment/lib/comments-chunk-postgresql.xql
    • -2
    • +19
    /openacs-4/packages/assessment/lib/comments-chunk.tcl
Monday 18 Jun 2018
5:40 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -6
    • +0
    /openacs-4/packages/categories/tcl/categories-procs-oracle.xql
    • -7
    • +0
    /openacs-4/packages/categories/tcl/categories-procs-postgresql.xql
    • -3
    • +2
    /openacs-4/packages/categories/tcl/categories-procs.tcl
5:36 pm

antoniop

Remove divergency between oracle and postgres codebase

Options
    • -24
    • +0
    /openacs-4/packages/faq-portlet/www/faq-portlet-oracle.xql
    • -24
    • +0
    /openacs-4/packages/faq-portlet/www/faq-portlet-postgresql.xql
    • -2
    • +17
    /openacs-4/packages/faq-portlet/www/faq-portlet.tcl
5:03 pm

antoniop

Remove unnecessary join, as users are always persons and unnecessary stored procedure in order_by as we compute this in the column already

Options
    • -4
    • +3
    /openacs-4/packages/notifications/www/manage-postgresql.xql
4:39 pm

antoniop

Remove divergency between oracle and postgres, bring all sql inline

Options
    • -17
    • +0
    /openacs-4/packages/notifications/www/request-change-frequency-oracle.xql
    • -17
    • +0
    /openacs-4/packages/notifications/www/request-change-frequency-postgresql.xql
    • -3
    • +13
    /openacs-4/packages/notifications/www/request-change-frequency.tcl
    • -16
    • +0
    /openacs-4/packages/notifications/www/request-change-frequency.xql
4:35 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -13
    • +0
    /openacs-4/packages/chat/www/user-unban-oracle.xql
    • -11
    • +0
    /openacs-4/packages/chat/www/user-unban-postgresql.xql
    • -3
    • +2
    /openacs-4/packages/chat/www/user-unban.tcl
4:30 pm

antoniop

Moderator is really a generic party and not always a user

Options
    • -3
    • +2
    /openacs-4/packages/chat/www/moderator-revoke.tcl
4:25 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -13
    • +0
    /openacs-4/packages/chat/www/moderator-revoke-oracle.xql
    • -11
    • +0
    /openacs-4/packages/chat/www/moderator-revoke-postgresql.xql
    • -4
    • +3
    /openacs-4/packages/chat/www/moderator-revoke.tcl
4:22 pm

antoniop

Disambiguate table reference in subquery

Options
    • -13
    • +13
    /openacs-4/packages/forums/tcl/messages-procs-oracle.xql
    • -13
    • +13
    /openacs-4/packages/forums/tcl/messages-procs-postgresql.xql
3:21 pm

antoniop

Further replace stored procedure with already-available table column

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/admin/site-map/mount-postgresql.xql
3:17 pm

antoniop

Replace unnecessary stored procedures and casts

Options
    • -10
    • +12
    /openacs-4/packages/acs-subsite/www/admin/site-map/unmounted-postgresql.xql
2:46 pm

antoniop

Avoid unnecessary stored procedures and casts

Options
    • -13
    • +12
    /openacs-4/packages/acs-subsite/www/admin/site-map/mount-postgresql.xql
1:50 pm

antoniop

Remove leftover xql files

Options
    • -23
    • +0
    /openacs-4/packages/acs-admin/www/users/modify-admin-privileges-oracle.xql
    • -23
    • +0
    /openacs-4/packages/acs-admin/www/users/modify-admin-privileges-postgresql.xql
9:28 am

gustafn

fix example in documentation and small code cleanup

Options
    • -2
    • +2
    /openacs-4/packages/acs-core-docs/www/files/tutorial/myfirstpackage-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-core-docs/www/xml/developers-guide/tutorial-debug.xml
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/register/recover-password.tcl
    • -2
    • +4
    /openacs-4/packages/acs-templating/tcl/form-procs.tcl
    • -2
    • +4
    /openacs-4/packages/acs-templating/www/scripts/xinha/attach-file.tcl
12:03 am

hectorr

Avoid unnecesary existence checks

Options
    • -1
    • +1
    /openacs-4/packages/acs-subsite/www/permissions/perm-include.tcl
Sunday 17 Jun 2018
9:57 pm

hectorr

Whitespace changes

Options
    • -34
    • +32
    /openacs-4/packages/rss-support/tcl/rss-support-procs.tcl
9:54 pm

hectorr

Avoid unnecesary existence checks

Options
    • -2
    • +2
    /openacs-4/packages/rss-support/tcl/rss-support-procs.tcl
9:30 pm

hectorr

Whitespace changes

Options
    • -13
    • +13
    /openacs-4/packages/acs-automated-testing/tcl/tclwebtest-procs.tcl