OpenACS / openacs-4 / packages / xowiki / tcl

xowiki-form-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 8
Last Commit: 26 Apr
Commits this week: 0
Total Lines of Code (LoC): 876
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 23 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 16 Feb
11:31 am

gustafn

Fixed unreviewed commit, which might lead to hard-to-spot errors

The last change assumed that "nls_language" can be hard-wired to

contain most 5 characters. While this not backed by the OpenACS data

model, the standard (RFC 5646) explicitly states that there is no

upper limit on the size of language tags. The tree letter language

codes have been standard since 2001 (RFC 4646).

The change accepts now all defined locales. When the specified locale

is not enabled, it provides a log notice, when the locale is not

defined at all, it provides a warning and falls back to "en_US".

Options
    • -2
    • +17
    ./xowiki-form-procs.tcl
  2. … 3 more files in changeset.
Wednesday 14 Feb
1:54 pm

antoniop

Validate as a token also the default coming from _nls_language, ensure the resulting language key is at most 5 chars long (many thanks to Markus Moser for this)

Options
    • -3
    • +5
    ./xowiki-form-procs.tcl
Tuesday 30 Jan
6:17 pm

gustafn

fix typo

Options
    • -2
    • +2
    ./xowiki-form-procs.tcl
Thursday 25 Jan
12:44 pm

antoniop

Cleanup commented code

Options
    • -11
    • +1
    ./xowiki-form-procs.tcl
Tuesday 09 May 2023
8:45 am

trenner

fix typo

Options
    • -3
    • +3
    ./xowiki-form-procs.tcl
Wednesday 19 Apr 2023
7:31 pm

gustafn

improved parameter checking

Options
    • -5
    • +5
    ./xowiki-form-procs.tcl
  2. … 3 more files in changeset.
Monday 27 Feb 2023
7:48 pm

gustafn

Use signed value for form_parameter "__object_name"

Bumped version number to 5.10.1d40

Options
    • -2
    • +2
    ./xowiki-form-procs.tcl
  2. … 3 more files in changeset.
Saturday 24 Dec 2022
5:21 pm

gustafn

disallow names, which look like a language prefix followed by an empty name

Empty names are not allowed.

The error message is just always the same for wiki pages, so

this is not perfect.

Options
    • -1
    • +8
    ./xowiki-form-procs.tcl
Thursday 15 Dec 2022
8:30 pm

gustafn

improved checking of parameter values, which might be influenced via query parameters

Options
    • -3
    • +3
    ./xowiki-form-procs.tcl
  2. … 6 more files in changeset.
Monday 05 Sep 2022
5:07 pm

antoniop

Small improvements:

- use "string is space" instead of trimming the string and checking if empty, at least 2x faster on development, wherever we don't need the trimmed value

- modernize leftover foreach trick with lassign

Options
    • -2
    • +4
    ./xowiki-form-procs.tcl
  2. … 6 more files in changeset.
4:10 pm

antoniop

Fall back to en_US also when a value for nls_language is there, but empty

Options
    • -2
    • +5
    ./xowiki-form-procs.tcl
Wednesday 13 Jul 2022
12:41 pm

gustafn

for orthogonaly, remove "-html" flag from dom parse to avoid a potential top-level <html> element

Options
    • -3
    • +3
    ./xowiki-form-procs.tcl
  2. … 4 more files in changeset.
Friday 15 Apr 2022
7:28 pm

gustafn

fix typo

Options
    • -2
    • +2
    ./xowiki-form-procs.tcl
Thursday 14 Apr 2022
12:14 pm

gustafn

We differentiate now between the classical name validation error and

the name-too-long error. Message keys had to be extended.

Version number bumped to 5.10.1d27

Options
    • -3
    • +5
    ./xowiki-form-procs.tcl
  2. … 7 more files in changeset.
Friday 04 Mar 2022
11:53 am

gustafn

handle cases in name-validation/normalization, where the language comes from _nls_language rather than nls_language

Many thanks to Markus Moser for analyzing and identifying the problem.

Options
    • -3
    • +21
    ./xowiki-form-procs.tcl
Wednesday 26 Jan 2022
12:01 am

gustafn

fix default value for nls_language

Options
    • -3
    • +3
    ./xowiki-form-procs.tcl
Monday 27 Dec 2021
6:03 pm

gustafn

support renaming of autonamed entries

previously, it was not possible to rename autonamed entries via edit form.

now this is allowed, and item name validation is more robust, support

functions return meaningful error in unexpected situations.

Options
    • -11
    • +19
    ./xowiki-form-procs.tcl
  2. … 1 more file in changeset.
Tuesday 27 Jul 2021
2:09 pm

gustafn

fix creating/editing of xowiki::Forms

This change essentially reverts the change of July 2, which broke

the feature to specify "editor=none". This is important for the

"form" form-field entry, which requires a FORM tag, that is

usually removed by actual version of the ckeditor.

Options
    • -2
    • +2
    ./xowiki-form-procs.tcl
  2. … 1 more file in changeset.
Friday 02 Jul 2021
6:33 pm

antoniop

In order to make the "editor=" formfield spec option have any effect, one should catch the value from the spec early, before the formfield is reclassed and initialized

This also exposes that the editor=none value is not valid (detected by xowiki and xowf automated tests). For this to be valid one should define it as a richtext subclass.

Options
    • -2
    • +2
    ./xowiki-form-procs.tcl
  2. … 1 more file in changeset.
Sunday 14 Feb 2021
10:16 pm

gustafn

use ad_proc -private

Options
    • -3
    • +3
    ./xowiki-form-procs.tcl
Monday 01 Feb 2021
11:41 am

gustafn

make end of resub options explicit

Options
    • -4
    • +4
    ./xowiki-form-procs.tcl
  2. … 12 more files in changeset.
Monday 18 Jan 2021
3:01 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./xowiki-form-procs.tcl
  2. … 4 more files in changeset.
Friday 18 Dec 2020
3:37 pm

gustafn

fix propagation of validate results in old-style (ad_form-based) forms. One should really switch to FormPages soon.

Options
    • -8
    • +14
    ./xowiki-form-procs.tcl
  2. … 1 more file in changeset.
Wednesday 19 Aug 2020
6:53 pm

antoniop

Make ::xowiki::Package default_locale react to changes in the connection locale by caching only when the parameter use_connection_locale is not set, use ::xowiki::Package default_locale result instead of always the connection locale to determine nls_language for new Pages and FormPages, so that default language for a particular xowiki instance is decided by use_connection_locale parameter

Options
    • -2
    • +3
    ./xowiki-form-procs.tcl
  2. … 2 more files in changeset.
Monday 13 Jul 2020
2:02 pm

gustafn

introduced "ad_file" as a means to avoid unexpected tilde substitution in file names

Options
    • -3
    • +3
    ./xowiki-form-procs.tcl
  2. … 50 more files in changeset.
Wednesday 01 Jul 2020
9:31 pm

gustafn

improve spelling

Options
    • -6
    • +6
    ./xowiki-form-procs.tcl
  2. … 19 more files in changeset.
Monday 07 Oct 2019
9:47 pm

gustafn

fix bug: never update references in the search renderer

before, it was possible that the search renderer added some

unsresolved references, although these were already fixed.

This was caused by the asynchrnous search queue, which

might have inserted such values.

The interface of Page.render was extended to be able to

specify, that the references should be always updated in the DB,

or just when unresolved references are encountered, or

never.

Options
    • -3
    • +2
    ./xowiki-form-procs.tcl
  2. … 3 more files in changeset.
Saturday 05 Oct 2019
3:24 pm

gustafn

improve comma settings

see: https://onlinewritingtraining.com.au/however-therefore-furthermore/

Options
    • -2
    • +2
    ./xowiki-form-procs.tcl
  2. … 4 more files in changeset.
Tuesday 01 Oct 2019
9:54 pm

gustafn

improve input validaton on query variables

Options
    • -2
    • +2
    ./xowiki-form-procs.tcl
  2. … 7 more files in changeset.
Monday 30 Sep 2019
9:27 am

gustafn

improving comments, variable names, and indentation

Options
    • -3
    • +3
    ./xowiki-form-procs.tcl
  2. … 2 more files in changeset.