OpenACS / openacs-4 / packages / xotcl-core

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 26 Apr
Commits this week: 0
Total Lines of Code (LoC): 14,003
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 24 May 2023
11:28 am

gustafn

improve listing of properties of NX classes

Options
    • -7
    • +1
    ./01-debug-procs.tcl
Thursday 20 Apr 2023
5:04 pm

antoniop

Test external command dependencies

Options
    • -0
    • +15
    ./test/xotcl-test-procs.tcl
  2. … 1 more file in changeset.
Wednesday 19 Apr 2023
7:19 pm

gustafn

Undo part of the recent cache-deactivation for attribute definitions

When all calls for "db_attribute_defined" are performed without

caching, this results in a huge amount of additional SQL queries,

since these tests are performed during blueprint definition as well

during every blueprint reload of every db attribute. On a small site

with just 6 connection threads (2 monitor, 2 default, 2 slow), this

results during startup with 969 additional SQL queries, a reload of

xowiki causes an additional 1063 of such queries. When a site defines

much more connection threads ((the LEARN site has e.g. 85 connection

threads defined), these DB attribute testing operations will result in

10K+ of mostly useless SQL queries. As a consequence of this, the

startup of the server will become slower, reloads will become slower

etc., which is bad especially for large sites.

The new implementation seems to fix the original problem case (running

xotcl_core_tutorial_4 multiple times). If there is still a problem

with installing xolp [2] this problem should be analyzed and fixed

probably there. If necessary, a proper bug report would be appreciated

to reduce guessing work.

[1] https://fisheye.openacs.org/changelog/OpenACS/?cs=oacs-5-10%3Aantoniop%3A20230310183055

[2] https://fisheye.openacs.org/changelog/OpenACS/?cs=oacs-5-10%3Aantoniop%3A20230317160241

Options
    • -10
    • +29
    ./05-db-procs.tcl
6:57 pm

gustafn

Use the usual idiom for checking if the connection is active

... why in the first place was this change necessary? Who calls this

in which way this www-*method without a connection?

Options
    • -3
    • +5
    ./01-debug-procs.tcl
Tuesday 28 Mar 2023
3:34 pm

antoniop

Don't run the spiel when we are not connected

Options
    • -7
    • +9
    ./01-debug-procs.tcl
Friday 17 Mar 2023
5:02 pm

antoniop

As it turns out, even caching only by request has consequences e.g. when one installs xolp from scratch

Disabl caching and prepare the statement instead

Options
    • -4
    • +10
    ./05-db-procs.tcl
Friday 10 Mar 2023
7:30 pm

antoniop

Improve robustness when a class is created/deleted multiple times (e.g. by repeating xotcl-core.xotcl_core_tutorial_4 automated test)

Options
    • -35
    • +8
    ./05-db-procs.tcl
Tuesday 07 Mar 2023
10:48 am

gustafn

Factor out Package->process_init_parameter into package-custom-procs

This change makes it easier to provide instance specific customization.

In general, these package-custom-procs could also be kept in other

packages.

Options
    • -9
    • +18
    ./06-package-procs.tcl
  2. … 4 more files in changeset.
Monday 27 Feb 2023
7:40 pm

gustafn

Use signed value for form_parameter "__object_name"

Options
    • -3
    • +5
    ./generic-procs.tcl
7:39 pm

gustafn

Added support for form_parameter specs with value checkers

Options
    • -8
    • +30
    ./context-procs.tcl
7:33 pm

gustafn

Added nsf value checker "signed"

This value checker tests, whether the provided value was signed with

::security::parameter::signed. If so, and when it was called with

"signed,convert", it returns the value which was signed.

Bumped version number to 5.10.1d16

Options
    • -0
    • +19
    ./01-debug-procs.tcl
  2. … 1 more file in changeset.
Wednesday 15 Feb 2023
5:35 pm

gustafn

improve warning message (for legavy applications)

Options
    • -6
    • +8
    ./cr-procs.tcl
Wednesday 08 Feb 2023
8:15 pm

gustafn

improve value checking to improve error messages

Options
    • -6
    • +6
    ./policy-procs.tcl
8:04 pm

gustafn

imporved log message

Options
    • -2
    • +2
    ./05-db-procs.tcl
8:04 pm

gustafn

reduce verbosity

Options
    • -1
    • +1
    ./01-debug-procs.tcl
Wednesday 01 Feb 2023
2:40 pm

antoniop

Use an idiom without expr to fill up the multirow after the body execution

Options
    • -2
    • +4
    ./05-db-procs.tcl
2:39 pm

antoniop

Test the behavior when the multirow contains values in the form "\d+\.": this shows a bug caused by the value retrieval going through an expr, which will "normalize" the value to "\d+\.0"

Options
    • -0
    • +21
    ./test/xotcl-test-procs.tcl
Thursday 26 Jan 2023
3:25 pm

antoniop

Performance improvements:

- add with_headers flag to ::xo::dc list_of_lists behaving like the db_list_of_lists counterpart

- use ::xo::dc list_of_lists as internal for ::xo::dc foreach and ::xo::dc multirow to reduce the need for ns_sets

Options
    • -78
    • +77
    ./05-db-procs.tcl
1:31 pm

antoniop

Collect all query results before executing the code to avoid the out-of-pools bug

Options
    • -1
    • +6
    ./05-db-procs.tcl
1:30 pm

antoniop

Implement a test making sure ::xo::dc "loop code-executing" api is not subject to the "out of pools" bug

Options
    • -0
    • +31
    ./test/xotcl-test-procs.tcl
11:53 am

antoniop

-prepare flag must not be supplied when not available

Options
    • -3
    • +4
    ./05-db-procs.tcl
11:47 am

antoniop

Fix regression: the reimplementation of ::xo::dc foreach reintroduced the old "out of pools bug"

The fix makes again use of the ns_set api to free the handle before the code is executed

Options
    • -25
    • +17
    ./05-db-procs.tcl
Monday 23 Jan 2023
10:23 am

antoniop

Remove hack and prefer to document limitation in the automated test

Options
    • -17
    • +1
    ./05-db-procs.tcl
    • -19
    • +35
    ./test/xotcl-test-procs.tcl
Friday 20 Jan 2023
1:15 pm

antoniop

Fix typo and include again the hack for strings with colon char in the fallback implementation of ns_pg_prepare

Fixes xotcl-core.test_prepared_statements automated test

Options
    • -3
    • +21
    ./05-db-procs.tcl
Thursday 19 Jan 2023
7:10 pm

gustafn

improved spelling

Options
    • -3
    • +3
    ./05-db-procs.tcl
6:53 pm

gustafn

use the built-in bindvars parser (when available) for prepared statements

Options
    • -30
    • +34
    ./05-db-procs.tcl
Tuesday 17 Jan 2023
10:54 am

antoniop

Do not extend the existing multirow, we only enforce that this call will have the same columns

Options
    • -8
    • +2
    ./05-db-procs.tcl
10:53 am

antoniop

Test that appending to an existing multirow from the db works as expected: when the columns defined via query and extend are the same, this should succeed

Options
    • -0
    • +39
    ./test/xotcl-test-procs.tcl
Monday 16 Jan 2023
6:27 pm

antoniop

Don't collide with multirows created by other tests

Options
    • -5
    • +5
    ./test/xotcl-test-procs.tcl
5:23 pm

antoniop

Do not enforce that body is a list

Options
    • -2
    • +2
    ./05-db-procs.tcl