• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Apply filters also to new images coming from the websocket

Make the border indicating the status of an artifact's review slightly bigger

Implement buttons to set all artifacts for a user as ok or not ok

    • -0
    • +4
    ./catalog/proctoring-support.de_DE.ISO-8859-1.xml
    • -0
    • +4
    ./catalog/proctoring-support.en_US.ISO-8859-1.xml
    • -0
    • +4
    ./catalog/proctoring-support.it_IT.ISO-8859-1.xml
file review-all.tcl was initially added on branch oacs-5-10.

Use only ok and flagged as color schemes, so that results can be investigated also while review is in progress

Handle the case where only one type of artifacts is collected

Replace private with public api

Basic test of the proctoring upload endpoint

    • -0
    • +92
    ./tcl/test/proctoring-test-procs.tcl
Switch to a select widget to keep a more predictable vertical size in case of many time presets

Notify new revisions on a proctoring artifact on the object's websocket, in a way that the users list, already designed to refresh in case on messages, will display new information when the revision is proceeding

Fix typos

Generate the fullscreen preview element in javascript and make it a child of the body, so that it can expand to the full page also when the include itself would be rendered in a smaller container

Implement a pre-selection filter for timeframes, which can be extended using downstream specific logics

    • -0
    • +7
    ./catalog/proctoring-support.de_DE.ISO-8859-1.xml
    • -0
    • +2
    ./catalog/proctoring-support.en_US.ISO-8859-1.xml
    • -0
    • +2
    ./catalog/proctoring-support.it_IT.ISO-8859-1.xml
    • -0
    • +21
    ./tcl/proctoring-callback-procs.tcl
Various changes on the proctoring artifacts users list:

- display some statistics on the collected artifacts for each user: count, number of reviewed, number of flagged, plus a colored progress bar indicating the review status, orange when in progress, red when completed with flags and green when everything is ok

- switched to a template::list to avoid too much handcrafting

- removed the red delete button from the top of the page, redundant, since we have the bulk actions on the list

- refined the behavior of the bulk-action delete button: it will be disabled when nothing is selected

- now we always trigger a reload when new artifacts are received for this object, but we cap it to 60 seconds

    • -0
    • +5
    ./catalog/proctoring-support.de_DE.ISO-8859-1.xml
    • -0
    • +5
    ./catalog/proctoring-support.en_US.ISO-8859-1.xml
    • -0
    • +5
    ./catalog/proctoring-support.it_IT.ISO-8859-1.xml
Store the string "false", not the boolean false

Use a full join so that in case of (normally minimal) unalignment between camera and desktop, we still display every artifact

Fix expression

Allow to filters also by timestamp, start or end

Provide an own translation for "All" that considers the specific item (e.g. for gendering)

    • -0
    • +1
    ./catalog/proctoring-support.de_DE.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/proctoring-support.en_US.ISO-8859-1.xml
    • -1
    • +2
    ./catalog/proctoring-support.it_IT.ISO-8859-1.xml
Changes after review with downstream stakeholders:

- switch "Confirm OK" and "Flag" buttons

- put the two buttons after the comment section

Bonus change: mark unflagged artifacts with comments with a green border

Normalize the way the flag is represented in the JSON

Use a trash can icon, instead of all that yellow

Fix expression again

The flag coming from the ajax endpoint is an actual boolean

Make the position for the fullscreen preview sticky, and ensure the fullscreen element is positioned as the first body child, so it is put on top and can get as big as possible

Improve keyboard usability: focus the comment textarea when the modal opens and focus back on the comment button when the modal closes

Account for the scrollbar when enlarging the image

Enlarge images to fullscreen when one clicks on them

Don't set height explicitly

Fix filtering condition, improve doc