• last updated 17 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- use numeric comparison operator for truth value comparisons

- flatten nested "lindex" structures

  1. … 1 more file in changeset.
fixes for download-zip:

- require login for zip-downloads (keep away spiders)

- return "not found" on if ids are no acs-objects

- clean temp-files on errors

- fix bracing

- new style string expressions

- brace expressions to allow for tcl compilation

- use "in" or not in (ni) operator instead of lsearch

- bump version number

  1. … 9 more files in changeset.
- use standard "not found" message instead of deprecated calls

- fix incorrect message key names

- use property "doc(title)" throughout oacs-5-8 instead of "title" to get rid of warnings in error.log of the form:

Warning: /forums/message-view has no doc(title) set.

Using doc(title) is required in blank-master.tcl but was used so far only in a few packages

  1. … 323 more files in changeset.
- add default value

- replace deprecated "export_url_vars" by "export_vars -url"

- fix bracing in "export_vars -form"

  1. … 119 more files in changeset.
- modernize tcl

  1. … 4 more files in changeset.
- replace deprecated "ad_parameter" by "parameter::get"

  1. … 7 more files in changeset.
- relplace deprecated "item::get_live_revision" by "content::item::get_live_revision"

  1. … 1 more file in changeset.
- replace deprecated "ad_parameter" by "parameter::get"

  1. … 1 more file in changeset.
- replace deprecated "ad_require_permission" by "permission::require_permission"

  1. … 59 more files in changeset.
- replace deprecated ad_permission_p with permission::permission_p

  1. … 28 more files in changeset.
- added victor's patch to omit deprecated messages of "ns_info tcllib". Background: naviserver supports multiple (virtual) servers, which might have different tcllibs. Therefore, the preferred command to query this was moved to "ns_server ?-server s? tcllib" and "ns_info tcllib" was deprecated. From the OpenACS point of view, one wants to locate the actual library. Since the variable does not change, it is fine to store it in a per-thread variable which can be efficiently accessed.

  1. … 21 more files in changeset.
Using acs_permission__permission_p for checking persmissions instead of querying view acs_object_party_privilege_map (for PG >= 8.4).

  1. … 1 more file in changeset.
- replace deprecated command "ns_unlink" with native tcl command "file delete"

  1. … 7 more files in changeset.
- the (deprecated) function ad_parameter was called with wrong arguments, "-package_id" was treated as parameter for non-positional argument "package_key" ("ad_parameter GeneralCommentsP -package_id [ad_conn package_id]"). Changed to "parameter::get"

- the (deprecated) function ad_parameter was called with wrong arguments, "-package_id" was treated as parameter for non-positional argument "package_key" ("ad_parameter BehaveLikeFilesystemP -package_id [ad_conn package_id]"). Changed to "parameter::get"

Encode files URL properly (would fail if the filename had a plus sign, sharp one etc in it)

Untabify and indent

HTML cleanup

Indent

Retrieve the title of the file to be renamed instead of the filename

use content::extlink instead of the deprecated content_extlink:: api, add content::extlink::edit function

  1. … 9 more files in changeset.
Check permissions before internal-redirecting to the template for that content type

Check permission before internal-redirecting to default template for that content type

- fix for bug #3156

1. Merge 2.4.1 to HEAD other than assessment, imsld, lorsm, and views.

2. Bump version numbers to 2.5.0d1.

  1. … 373 more files in changeset.