• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- modernize Tcl (use byte-compiled comparisons, don't use numeric comparisons for string expressions, brace expressions)

n ----------------------------------------------------------------------

  1. … 79 more files in changeset.
- correct work-in-progress version numbering to *a1

  1. … 28 more files in changeset.
- bump version numbers due to branching

  1. … 28 more files in changeset.
- bump version numbers

  1. … 28 more files in changeset.
Provide a more useful error message when something fails in the transaction

- replace deprecated ns_sendmail by acs_mail_lite::send;

- assessment stores tcl-code in the db. someone with assessement knowledge should take care about updating this code!

- needs to be tested

    • -1
    • +1
    ./sql/oracle/assessment-actions-insert.sql
    • -2
    • +2
    ./sql/oracle/assessment-actions-package-create.sql
    • -0
    • +101
    ./sql/postgresql/upgrade/upgrade-0.23d3-0.23d4.sql
- use "lassign" instead of "util_unlist"

- replace deprecated "ad_get_user_id" by "ad_conn user_id"

- replace deprecated "ad_require_permission" by "permission::require_permission"

- replace deprecated "ad_permission_p" by "permission::permission_p"

- use "lassign" instead of "foreach ... break" idiom

    • -2
    • +2
    ./www/asm-admin/item-add-mc-choices.tcl
  1. … 5 more files in changeset.
- added victor's patch to omit deprecated messages of "ns_info tcllib". Background: naviserver supports multiple (virtual) servers, which might have different tcllibs. Therefore, the preferred command to query this was moved to "ns_server ?-server s? tcllib" and "ns_info tcllib" was deprecated. From the OpenACS point of view, one wants to locate the actual library. Since the variable does not change, it is fine to store it in a per-thread variable which can be efficiently accessed.

  1. … 20 more files in changeset.
Using dollar-quoting ( partly ) in order to make the package installable on pg 9.2.

Add missing query

Fix dave's fix :)

Add missing query for question choices stored in CR filesystem

Fix the name of a variable that is used inside a message

    • -1
    • +1
    ./catalog/assessment.es_ES.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/assessment.es_GT.ISO-8859-1.xml
Fix the name of a variable that is used inside a message

    • -1
    • +1
    ./catalog/assessment.es_ES.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/assessment.es_GT.ISO-8859-1.xml
Merged oacs-5-5 branch of .LRN packages to HEAD.

    • -2
    • +2
    ./sql/oracle/assessment-collected-data-create.sql
  1. … 85 more files in changeset.
Changed a query to use cr_revisions directly rather than as_item_choice's

select view, because (ahem) assessment doesn't actually create type metadata

for its types so the view is never created.

    • -2
    • +2
    ./sql/oracle/assessment-collected-data-create.sql
Fix dependencies and their version

  1. … 14 more files in changeset.
Removed drop statement of two triggers that actually wouldn't exist in previous version.

    • -2
    • +2
    ./sql/postgresql/upgrade/upgrade-0.23d1-0.23d2.sql
Points has changed to float

    • -2
    • +2
    ./sql/oracle/assessment-collected-data-create.sql
Add views dependency

Change the order of the line added in the previous commit for a new question type, new question types should be added at the end to avoid changing the order of the current question types because in item-add.adp the types are displayed using the indexes

Show only results for users member of the current community

    • -2
    • +4
    ./www/asm-admin/results-users-oracle.xql
    • -11
    • +10
    ./www/asm-admin/results-users.tcl
Indentation

    • -57
    • +85
    ./www/asm-admin/results-users.tcl
HTML cleanup

HTML cleanup

add missing keys and ES translation

    • -0
    • +1
    ./catalog/assessment.en_US.ISO-8859-1.xml
    • -0
    • +2
    ./catalog/assessment.es_ES.ISO-8859-1.xml
Remove extra tag

Fix typo

Answer of type "text" (long text -> clob_answer) were not displayed. Fix query and list template to make them show up.

    • -9
    • +4
    ./www/asm-admin/view-item-responses.tcl
Remove extra log messages