OpenACS / openacs-4 / packages / acs-tcl / tcl

request-processor-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 2
Total Committers: 25
Last Commit: 31 May
Commits this week: 2
Total Lines of Code (LoC): 1,901
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 21 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 16 Oct 2013
9:49 pm

gustafn

- use $::acs::rootdir rather than [acs_root_dir] or [get_server_root]

Options
    • -3
    • +3
    ./request-processor-procs.tcl
  2. … 14 more files in changeset.
1:18 pm

gustafn

- revert escaped change for the time being

Options
    • -43
    • +0
    ./request-processor-procs.tcl
1:08 pm

gustafn

- use "... eq {} " instead of "template::util::is_nil" where it is clear that the variable exists

Options
    • -1
    • +44
    ./request-processor-procs.tcl
  2. … 1 more file in changeset.
Saturday 12 Oct 2013
3:55 pm

gustafn

- flatten nested "lindex" structures

- merge multiple "lappend" operations

- use "lassign" instead of multiple "lindex" operations

- improve performance util_convert_line_breaks_to_html by reducing

number of regsub operations and more precise regular expressions

- use numeric comparison operator for truth value comparisons

- use "lassign" instead of multiple "lindex" operations

- reduce number of remaining "string equal" operations

Options
    • -3
    • +3
    ./request-processor-procs.tcl
  2. … 13 more files in changeset.
Monday 07 Oct 2013
6:55 pm

gustafn

- make ad_return deprecated; maybe this function was useful for ancient versions of tcl, but as it is, it does not make sense (see comment in code)

Options
    • -2
    • +8
    ./request-processor-procs.tcl
  2. … 1 more file in changeset.
6:42 pm

gustafn

- simplify various wierd ways to set the variable ::template::parse_level

Options
    • -2
    • +2
    ./request-processor-procs.tcl
  2. … 5 more files in changeset.
Sunday 06 Oct 2013
2:36 pm

gustafn

- use "lassign" instead of "foreach" idiom

- use namespace prefix instead of "global" statement

- use compiled string expressions

- use "in" expression instead of "lsearch -exact"

Options
    • -16
    • +15
    ./request-processor-procs.tcl
  2. … 1 more file in changeset.
Thursday 03 Oct 2013
12:55 am

gustafn

- don't use backslash in multiline expressions

- make long expressions more uniform and more readable

- use "in" or not in (ni) operator instead of lsearch

- brace expressions to allow for tcl compilation

- bump version number

Options
    • -24
    • +30
    ./request-processor-procs.tcl
  2. … 23 more files in changeset.
Monday 30 Sep 2013
11:39 am

gustafn

- brace namespace eval

- don't abbreviate subcommands

Options
    • -5
    • +5
    ./request-processor-procs.tcl
Sunday 29 Sep 2013
10:24 pm

gustafn

- use tcl 8.5 extended index format for "string range"

- modernize tcl

Options
    • -3
    • +3
    ./request-processor-procs.tcl
  2. … 6 more files in changeset.
2:03 pm

gustafn

- use "lassign" instead of "util_unlist"

Options
    • -3
    • +3
    ./request-processor-procs.tcl
  2. … 19 more files in changeset.
Saturday 28 Sep 2013
7:55 pm

gustafn

- break overlong lines

Options
    • -2
    • +9
    ./request-processor-procs.tcl
Friday 27 Sep 2013
6:00 pm

gustafn

- get rid of deprecated call to ad_footer

Options
    • -4
    • +3
    ./request-processor-procs.tcl
Thursday 19 Sep 2013
12:13 pm

gustafn

- fix for bug in request processor that leads to Errors of the form: "failed to redirect '404': exceeded recursion limit of 3" in the error.log

Options
    • -7
    • +13
    ./request-processor-procs.tcl
Friday 13 Sep 2013
11:59 am

gustafn

- include always vuh in ExtensionPrecedence to preserve documented sematics

Options
    • -3
    • +4
    ./request-processor-procs.tcl
11:40 am

gustafn

- fix bug and potential security hole: before this patch, OpenACS was trying to serve files with arbitrary extensions (i.e. not included in the kernel parameter ExtensionPrecedence) in case the requested file was not found. This is quite dangerous and breaks e.g. the listing of openacs.org/repository (which is a directory), since the directory is moved every night into openacs.org/repository.bak. With the given logic, it tries to server the .bak directory as a file (which does of course not work). That blind logic is not inecessary, and is actually a potential attack vector.

Options
    • -5
    • +16
    ./request-processor-procs.tcl
Tuesday 03 Sep 2013
10:07 am

gustafn

- set "ad_conn peeraddr" to the value of "X-Forwarded-For" only in ReverseProxyMode

Options
    • -11
    • +13
    ./request-processor-procs.tcl
  2. … 1 more file in changeset.
Tuesday 27 Aug 2013
12:52 pm

gustafn

- get rid of empty_string_p

Options
    • -3
    • +3
    ./request-processor-procs.tcl
  2. … 20 more files in changeset.
Friday 12 Apr 2013
6:12 pm

gustafn

- added victor's patch to omit deprecated messages of "ns_info tcllib". Background: naviserver supports multiple (virtual) servers, which might have different tcllibs. Therefore, the preferred command to query this was moved to "ns_server ?-server s? tcllib" and "ns_info tcllib" was deprecated. From the OpenACS point of view, one wants to locate the actual library. Since the variable does not change, it is fine to store it in a per-thread variable which can be efficiently accessed.

Options
    • -2
    • +2
    ./request-processor-procs.tcl
  2. … 21 more files in changeset.
Monday 08 Apr 2013
5:50 pm

gustafn

Performance improvements for rp_filter and parameter:

- improve performance of rp_filter (which is run on every

non-resources request) significantly (often a factor of 2)

- improve scalability by reducing number of required mutex locks

(e.g. for secret token handling)

Options
    • -53
    • +45
    ./request-processor-procs.tcl
  2. … 8 more files in changeset.
Friday 29 Mar 2013
3:41 pm

gustafn

- use a single file operation in the most common case

Options
    • -7
    • +10
    ./request-processor-procs.tcl
3:05 pm

gustafn

- cleanup and minor performance improvements

Options
    • -8
    • +7
    ./request-processor-procs.tcl
  2. … 1 more file in changeset.
Wednesday 20 Feb 2013
2:34 pm

victorg

A better version of previous commit: refetching site node info just when really needed and better wording on comments. Patch by Gustaf Neumann.

Options
    • -8
    • +12
    ./request-processor-procs.tcl
11:41 am

victorg

Previous attempt to fix problem of exceeding recursion limit affected the looking up of vuh files. Instead we re-calculate the extra_url ( done as in rp_filter ) before going through the whole process that figures out which file to serve.

Options
    • -7
    • +8
    ./request-processor-procs.tcl
Thursday 20 Dec 2012
4:47 pm

gustafn

- don't use regexp when not needed (match is so much faster).

- provide context info for naviserver writer threads

- reset "extra_url", needed for internal redirects on errors.

Options
    • -5
    • +16
    ./request-processor-procs.tcl
  2. … 1 more file in changeset.
Friday 05 Oct 2012
11:33 pm

gustafn

- guard rename-commands to improve robustness for reloading in newer tcl versions

Options
    • -12
    • +14
    ./request-processor-procs.tcl
Sunday 15 May 2011
6:43 pm

ryang

Fix RestrictErrorsToAdminsP parameter behaviour, which previously did nothing.

Options
    • -5
    • +9
    ./request-processor-procs.tcl
Wednesday 16 Feb 2011
8:03 pm

daveb

Add require_login to admin filter. This was exposed as an issue when someone accidentally granted admin to the public. No administrator action ever needs to be performed when not logged in.

Options
    • -2
    • +5
    ./request-processor-procs.tcl
Sunday 17 Oct 2010
11:06 pm

donb

Merged oacs-5-6 to HEAD. HEAD now installs and passes all core tests. There

may still be some lingering problems due to my screwing up the oacs-5-6

branch earlier, I'll be looking into this later.

Options
    • -1
    • +7
    ./request-processor-procs.tcl
  2. … 214 more files in changeset.
Wednesday 12 May 2010
1:38 am

donb

Force references to an embedded package's admin or sitewide-admin pages to

be referenced (relative to the embedding package's mount point) as

admin/package-key or sitewide-admin/package-key. This nicely arranges

all admin URLs in a composite package under ${mount-point}/admin, which

among other things will cause the request processor to do the expected

permission check. Backdoor access to the admin pages via URLs like

${mount-point}/package-key/admin or ${mount-point}/package-key/sitewide-admin

is blocked, as the request processor won't do the expected permissions check

for URLs of that form.,

Options
    • -1
    • +7
    ./request-processor-procs.tcl
  2. … 1 more file in changeset.