OpenACS / openacs-4 / packages

acs-lang

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 41
Last Commit: 29 Jul
Commits this week: 0
Total Lines of Code (LoC): 20,564
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 12 Sep 2022
5:43 pm

antoniop

Document public api

Options
    • -1
    • +3
    ./tcl/lang-message-procs.tcl
  2. … 1 more file in changeset.
Tuesday 06 Sep 2022
11:44 am

antoniop

Deprecate export_ns_set_vars and extend export_vars to be able to export also a custom ns_set, which was the real added value provided by this api

Options
    • -2
    • +2
    ./www/admin/message-list.tcl
  2. … 11 more files in changeset.
Monday 05 Sep 2022
5:07 pm

antoniop

Small improvements:

- use "string is space" instead of trimming the string and checking if empty, at least 2x faster on development, wherever we don't need the trimmed value

- modernize leftover foreach trick with lassign

Options
    • -2
    • +2
    ./tcl/lang-message-procs.tcl
  2. … 6 more files in changeset.
Monday 29 Aug 2022
4:17 pm

antoniop

Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

Options
    • -2
    • +2
    ./tcl/lang-catalog-procs.tcl
    • -3
    • +3
    ./tcl/lang-message-procs.tcl
    • -2
    • +2
    ./www/admin/locale-delete.tcl
    • -2
    • +2
    ./www/admin/message-delete.tcl
    • -1
    • +1
    ./www/admin/message-undelete.tcl
    • -1
    • +1
    ./www/admin/message-unregister.tcl
  7. … 28 more files in changeset.
Tuesday 23 Aug 2022
8:44 pm

gustafn

Properly escape "<" and ">" in api-doc documentation.

Since all documentation is rendered via HTML, the characters

"<" and ">" have to be HTML-quoted, otherwise strange things

(omission, unintended renderings) might occur.

E.g. the sentence

Define an interface between a page and an

ADP <include> similar to the page_contract.

was rendered as

Define an interface between a page and an

ADP similar to the page_contract.

which is incorrect.

Options
    • -7
    • +7
    ./tcl/lang-util-procs.tcl
  2. … 13 more files in changeset.
Friday 19 Aug 2022
4:23 pm

antoniop

Return 0 when looking up the existance of a message key in an unsupported locale instead of failing, test the behavior

Options
    • -2
    • +6
    ./tcl/lang-message-procs.tcl
    • -0
    • +56
    ./tcl/test/acs-lang-localization-procs.tcl
3:15 pm

antoniop

Improve test precision: take into account packages defined as <install... in the info file, as e.g. dotlrn does

Options
    • -6
    • +42
    ./tcl/test/acs-lang-test-procs.tcl
Thursday 18 Aug 2022
4:58 pm

antoniop

Fallback here as well to en_US when no supported locale is found

Options
    • -1
    • +11
    ./tcl/locale-procs.tcl
Wednesday 17 Aug 2022
1:32 pm

antoniop

info files do not contain message keys

Options
    • -1
    • +1
    ./tcl/test/acs-lang-test-procs.tcl
Friday 15 Jul 2022
2:50 pm

antoniop

Reimplement the message-list UI using the template::list

Options
    • -81
    • +1
    ./www/admin/message-list.adp
    • -4
    • +100
    ./www/admin/message-list.tcl
1:37 pm

antoniop

Reimplement package-list UI using the template::list

Options
    • -57
    • +1
    ./www/admin/package-list.adp
    • -1
    • +66
    ./www/admin/package-list.tcl
10:36 am

antoniop

Reimplement the main admin locale UI using the template::list

Options
    • -86
    • +1
    ./www/admin/index.adp
    • -1
    • +100
    ./www/admin/index.tcl
Sunday 26 Jun 2022
9:38 pm

gustafn

use cookie namespace also for stored locales

Options
    • -3
    • +3
    ./acs-lang.info
    • -4
    • +6
    ./tcl/locale-procs.tcl
Thursday 07 Apr 2022
2:53 pm

gustafn

Make use of uniform styling based on adp:icon

Options
    • -2
    • +2
    ./acs-lang.info
    • -2
    • +2
    ./lib/messages-to-translate.tcl
    • -6
    • +17
    ./www/admin/index.adp
    • -1
    • +1
    ./www/admin/message-conflicts.tcl
    • -2
    • +6
    ./www/admin/message-list.adp
    • -1
    • +3
    ./www/admin/message-search.adp
    • -1
    • +3
    ./www/admin/package-list.adp
  8. … 14 more files in changeset.
Monday 28 Feb 2022
6:41 pm

antoniop

Constrain the language we return for the connection to the ones we support: could happen on system that have supposted a language in the past and still have users set it as their preferred language

Options
    • -4
    • +4
    ./tcl/locale-procs.tcl
Tuesday 15 Feb 2022
10:01 pm

gustafn

Fixes for Oracle 19c: (temporary?) fix for message catalogs

This change fixes the problem that after a fresh installation, all (!)

messages keys are empty. I am not sure what the source of the problem

is, why this has supposedly worked some years before, and whether

there are undesired side-effects of this change. Without this change,

the openacs installation leads to fully broken state.

Options
    • -1
    • +1
    ./tcl/lang-message-procs-oracle.xql
5:51 pm

gustafn

improved error message

Options
    • -2
    • +3
    ./tcl/localization-procs.tcl
5:50 pm

gustafn

Fixes for Oracle 19c boolean types in query

This fixes the following bug for Oracle:

: SQL:

: select locale

: from ad_locales l

: where language = :language

: and enabled_p

: !>>>!and (default_p or not exists (select 1 from ad_locales

: where language = :language

: and locale <> l.locale))

:

Options
    • -5
    • +6
    ./tcl/lang-util-procs.tcl
Saturday 12 Feb 2022
9:11 pm

gustafn

improving Oracle upgrade scripts

Oracle has no "ALTER TABLE ADD COLUMN ...."

Oracle has no "ALTER TABLE ADD COLUMN if exists .."

Options
    • -3
    • +17
    ./sql/oracle/upgrade/upgrade-5.10.0d11-5.10.0d12.sql
  2. … 8 more files in changeset.
Thursday 10 Feb 2022
10:33 pm

gustafn

fixes for Oracle 19c

Options
    • -7
    • +8
    ./sql/oracle/message-catalog.sql
  2. … 5 more files in changeset.
Tuesday 01 Feb 2022
2:23 pm

antoniop

Reduce need for xql

Options
    • -6
    • +4
    ./tcl/lang-message-procs.tcl
    • -12
    • +0
    ./tcl/lang-message-procs.xql
2:17 pm

antoniop

Cleanup hacks addressing #2011927 bug in Oracle: this has been supposedly addressed in version 9i, already EOL

See http://oracle-docs.dartmouth.edu/dba-docs/patchset_9.2.0.4.htm

Options
    • -19
    • +5
    ./tcl/lang-message-procs.tcl
    • -16
    • +0
    ./tcl/lang-message-procs.xql
Monday 31 Jan 2022
5:33 pm

antoniop

Fix acs-lang.test_message_register automated test:

when checking if a message should be created or updated, do not trust the nsv, which won't be there for messages that have been soft-deleted and go to the db instead. When a message is soft deleted, cleanup the nsv cache.

Options
    • -4
    • +14
    ./tcl/lang-message-procs.tcl
5:25 pm

antoniop

Expose a bug in the message key registration:

when a message key is soft-deleted and the server is restarted, upon re-registration the nsv that signals its presence won't be found and an insertion will be attempted. However, as the db entry is there, a primary key constraint will be triggered.

Options
    • -1
    • +35
    ./tcl/test/acs-lang-message-procs.tcl
Tuesday 14 Dec 2021
11:04 am

antoniop

Stick to packages that are enabled

Options
    • -4
    • +6
    ./tcl/test/acs-lang-test-procs.tcl
  2. … 1 more file in changeset.
10:51 am

antoniop

Use the intended table to get packages that are known to the system

Options
    • -1
    • +1
    ./tcl/test/acs-lang-test-procs.tcl
  2. … 1 more file in changeset.
Monday 13 Dec 2021
2:35 pm

antoniop

Add comment

Options
    • -0
    • +3
    ./tcl/test/acs-lang-test-procs.tcl
2:26 pm

antoniop

Make api to retrieve the dependencies of a package public, as we use it in a test in another package, swith to the api that will retrieve the cached value instead of re-computing the result

Options
    • -1
    • +1
    ./tcl/test/acs-lang-test-procs.tcl
  2. … 1 more file in changeset.
Friday 10 Dec 2021
4:03 pm

antoniop

New test to check that message keys are used consistently with package dependencies

this can only be enforced as a warning because it is possible to have constructs such as "if installed, then use message key" that would be tricky to detect

Options
    • -0
    • +84
    ./tcl/test/acs-lang-test-procs.tcl
Friday 26 Nov 2021
2:10 pm

antoniop

Reuse computation of lang::conn::locale when invoked again in the same request

This reduces stress on the util_memoize cache for those installation that invoke this api often.

Options
    • -4
    • +26
    ./tcl/locale-procs.tcl