• last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Moved table building and column adding code from content repository to

kernel, so all objects can benefit. Part of the acs object management package

work.

    • -159
    • +493
    ./postgresql/acs-metadata-create.sql
    • -309
    • +5
    ./postgresql/upgrade/upgrade-5.7.0d3-5.7.0d4.sql
  1. … 4 more files in changeset.
Upgrade scripts for changes on object metadata creation (adding automatic

table and column creation to base objects as well as CR object, object views,

etc).

    • -0
    • +936
    ./postgresql/upgrade/upgrade-5.7.0d3-5.7.0d4.sql
  1. … 3 more files in changeset.
On my previous commit I added a not null constraint for name column on site_nodes, the problem is that main site node on oracle has a NULL name ( given the fact that empty strings are managed as NULL on Oracle ) therefore doesnt make sense to have such constraint.

- Avoiding usage of coalesce function on site_nodes table columns in WHERE clause, this was leading to usage of sequencial scans which can be expensive when having a huge amount of site_nodes. Instead we go for isolation of the case when requestion a node with a null parent ( this would be the main site node ) and we use the = operator so the planner goes for a index scan.

- Adding not null constraint to site_nodes(name)

    • -0
    • +9
    ./oracle/upgrade/upgrade-5.7.0d2-5.7.0d3.sql
    • -0
    • +82
    ./postgresql/upgrade/upgrade-5.7.0d2-5.7.0d3.sql
  1. … 1 more file in changeset.
apm_parameter__get_value bug missed by merge apparently.

Merged oacs-5-6 to HEAD. HEAD now installs and passes all core tests. There

may still be some lingering problems due to my screwing up the oacs-5-6

branch earlier, I'll be looking into this later.

    • -0
    • +19
    ./postgresql/upgrade/upgrade-5.6.0b1-5.6.0b2.sql
    • -1
    • +28
    ./postgresql/upgrade/upgrade-5.6.0d1-5.6.0d2.sql
  1. … 207 more files in changeset.
Changes for supporting postgresql 9.0:

- Avoiding usage of SQL reserved keywords on plpsql functions (plpsql lexer and parser were reworked).

- Fixing all those places on which FROM clause was automatically added by PG ( PG Config add_missing_from parameter was removed for this release of PG ).

Many thanks to Tracy Adams and Jeff Lu for providing first version of the patches.

    • -0
    • +103
    ./postgresql/upgrade/upgrade-5.7.0d1-5.7.0d2.sql
  1. … 15 more files in changeset.
file upgrade-5.6.0b2-5.6.0b3.sql was initially added on branch oacs-5-6.

    • -0
    • +0
    ./postgresql/upgrade/upgrade-5.6.0b2-5.6.0b3.sql
Bumped to beta 3 so I could put in this important upgrade script, fixing

a problem with using package_instantiate_object to instantiate a base

(acs_object) object. Never done in core or .lrn code apparently because typically

you instantiate subtypes, but it is important to get right.

  1. … 26 more files in changeset.
Somebody hosed this (probably me). Never caught because no one creates a

base object directly, just subtypes of acs_object with their own (correct)

definition of a new() function.

I somehow managed to avoid commiting the "is_child" addition to apm-create

and also the upgrade script.

- complete change to acs_objects_package_idx for new creates (see http://fisheye.openacs.org/changelog/OpenACS/?cs=oacs-5-6%3Agustafn%3A20100509112929)

Needed to drop bio_mime_type attribute values, too ... this is removed

as it was never actually used so no need to copy it into the persons

table.

Had to remove the drop/create of cc_users because some obscure views make

use of it. No existing code expects cc_users to contain "bio" anyway, so

recreating the view was a matter of tidiness, not need. Drop ... cascade

would work but would break ecommerce and dotlrn-ecommerce, and likely some

other packages, so this seems the lesser of two evils.

    • -14
    • +5
    ./postgresql/upgrade/upgrade-5.6.0b1-5.6.0b2.sql
    • -14
    • +0
    ./postgresql/upgrade/upgrade-5.6.0d1-5.6.0d2.sql
Fixed up some "bio" related upgrade stuff, including protection against

trying to upgrade sites that had already applied the upgrade against 5.5

(that script didn't make it into the repository however).

    • -1
    • +27
    ./postgresql/upgrade/upgrade-5.6.0b1-5.6.0b2.sql
    • -1
    • +33
    ./postgresql/upgrade/upgrade-5.6.0d1-5.6.0d2.sql
- create index for acs_objects on package_ids and drop old one (as discussed in OCT)

- bump version number to trigger run of upgrade scripts for testing

  1. … 1 more file in changeset.
file upgrade-5.6.0b1-5.6.0b2.sql was initially added on branch oacs-5-6.

    • -0
    • +0
    ./oracle/upgrade/upgrade-5.6.0b1-5.6.0b2.sql
    • -0
    • +0
    ./postgresql/upgrade/upgrade-5.6.0b1-5.6.0b2.sql
Making global/instance changes work with Oracle

  1. … 1 more file in changeset.
More code dealing with instance and global parameter semantics. I finally

have a reasonable model of inheritance and semantics implemented, not

perfect from a language-theoretic point of view, but works well without

having to rewrite every bit of parameter-handling code in acs-core.

    • -0
    • +249
    ./oracle/upgrade/upgrade-5.6.0d7-5.6.0d8.sql
    • -0
    • +26
    ./postgresql/upgrade/upgrade-5.6.0d7-5.6.0d8.sql
  1. … 5 more files in changeset.
Oracle now passes the first set of global parameter tests. More to follow

for both PG and Oracle.

Victor had made an upgrade script for version d4, and committed it before

I got around to adding and committing mine. So now my tcl upgrade commits

and my datamodel ones aren't synchronized :( But they're dev versions so

no harm should result.

    • -0
    • +262
    ./postgresql/upgrade/upgrade-5.6.0d6-5.6.0d7.sql
If I'd known global parameters would be such a PITA, would I have TIP'd to

do them?

Turns out we must make a parameter value when a parameter is registered, else

all sorts of stuff dies. This is for PG. Oracle will come soon.

A bunch of stuff related to global/instance parameters.

Added 'embeds' to allowable dependencies.

Restored the data links upgrade script I'd accidently overwritten earlier.

1. added "bio" attribute to user rather than person (initial install was fine)

2. only make package instance parameter values for instance scope params

Orace stuff for global parameters.

    • -0
    • +657
    ./oracle/upgrade/upgrade-5.6.0d6-5.6.0d7.sql
  1. … 1 more file in changeset.
Added scope attribute to apm_parameters.

1. Changed trigger functions from "opaque" to "trigger" to get rid of the

warnings during initial install (only for acs-kernel, there are a lot

elsewhere!)

2. Added "embeds" for postgresql and partially for oracle.

3. Added global parameters for postgresql and partially for oracle.

(oracle will be forthcoming shortly)

    • -4
    • +4
    ./postgresql/acs-permissions-create.sql
    • -2
    • +2
    ./postgresql/acs-relationships-create.sql
    • -3
    • +3
    ./postgresql/rel-constraints-create.sql
    • -0
    • +28
    ./postgresql/upgrade/upgrade-5.6.0d5-5.6.0d6.sql
  1. … 17 more files in changeset.
Accidently added this to the 5.5 branch rather than HEAD earlier (but it

does no harm there so will leave it there).

    • -329
    • +12
    ./oracle/upgrade/upgrade-5.6.0d4-5.6.0d5.sql
    • -0
    • +334
    ./oracle/upgrade/upgrade-5.6.0d5-5.6.0d6.sql