• last updated 22 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improve robustness of file operations against names starting with a "-"

  1. … 8 more files in changeset.
Ease debugging

- modernize tcl

- remove unneeded braces

- copy the body of ad_get_tcl_call_stack from acs-tcl/tcl/utilities-procs to achive consistent behavior, when acs-bootstrap installer is reloaded.

bootstrap installer:

- added csp policy to the files upgradeable via apm

- bumped version number to 5.9.1d5

  1. … 3 more files in changeset.
- truncate overlong lines in ad_get_tcl_call_stack

  1. … 1 more file in changeset.
- add missing doc string

- add "protection" element instread of public_p or private_p

  1. … 1 more file in changeset.
- Use global variables to reduce lock contention on busy sites:

* $::acs::default_database replaces [nsv_get db_default_database .]

* $::acs::known_database_types replaces [nsv_get ad_known_database_types .]

- Cache db_driverkey per-thread (variable ::acs::db_driverkey($dbn))

to reduce high number of locks

  1. … 3 more files in changeset.
- improve linebreak

- keep error message

- add editor hints to keep spaces/tabs in the furture more consistent

  1. … 752 more files in changeset.
- optional performance boost for site-nodes:

the site-node code contains an optional performance booster,

that speeds up site-node operations froma factor of 2 to

several thousand times. The performance boost ist just

available for the time being for PostgreSQL, XOTcl2 and

NaviServer and is only activated, when these componentes

are available.

- bump version numbers

  1. … 4 more files in changeset.

ad_proc reform:

- use nsf::proc for defining ad_procs, when nsf::proc is available

- nsf::proc is part of the environment of XOTcl2 and provides

an efficient, C-implemented argument parser that can replace

the scripted *__arg_parser of OpenACS.

- The benefits are performance and reduced memory consumption.

* Simple functions (where the calling overhead was a large

part of the execution times can become several times faster

(e.g. db_name is 3x faster, cookie handling is 2x faster),

for functions with much db-activities the percentage will

be less.

* The memory consumption (RSS) of a site like OpenACS.org

is reduced by about 15%.

NEW (with nsf::proc)

::ad_get_cookie x: 10.93 microseconds per iteration

::ad_get_cookie ad_session_id: 21.95 microseconds per iteration

::dt_systime: 24.89 microseconds per iteration

::db_name: 8.70 microseconds per iteration

::db_string dbqd.null.g "select version() from dual": 316.66 microseconds per iteration

::ad_convert_to_html "hello world": 102.29 microseconds per iteration

OLD (without nsf::proc)

::ad_get_cookie x: 19.42 microseconds per iteration

::ad_get_cookie ad_session_id: 30.10 microseconds per iteration

::dt_systime: 27.55 microseconds per iteration

::db_name: 32.28 microseconds per iteration

::db_string dbqd.null.g "select version() from dual": 366.69 microseconds per iteration

::ad_convert_to_html "hello world": 160.51 microseconds per iteration

======================================================================

proc mtime cmd {set c 5000

set t [time [list time $cmd $c]];

regexp {^(-?[0-9]+) +} $t _ mS1;

set ms [expr {$mS1*1.0/$c}];

return "[format %6.2f $ms] microseconds per iteration"

}

set tests {

{::ad_get_cookie x} {::ad_get_cookie ad_session_id} {::dt_systime}

{::db_name} {::db_string dbqd.null.g "select version() from dual"}

{::ad_convert_to_html "hello world"}

}

foreach t $tests {append ::_ $t ": " [mtime $t] \n}

set ::_

======================================================================

  1. … 7 more files in changeset.
- allow upgrade of blank-master.{tcl,adp} via install-from-repository. This files should be free of site-specific customizations

  1. … 3 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

    • -25
    • +41
    ./40-db-query-dispatcher-procs.tcl
  1. … 2544 more files in changeset.
- fix invalid @param declaration for API browser

  1. … 5 more files in changeset.
- fix spelling of @param

  1. … 1 more file in changeset.
- move deprecated proc_doc to depreacted utilities file

  1. … 1 more file in changeset.
- document apm_bootstrap_upgrade

- improve error reporting during bootstrap loader: list dependency order in a human oriented manner, report more errors from sourcing files http://openacs.org/forums/message-view?message_id=4172245

  1. … 1 more file in changeset.
- allow error propagation also from bootstrap loader

- white space change: replace tabs by spaces

    • -11
    • +18
    ./40-db-query-dispatcher-procs.tcl
  1. … 2 more files in changeset.
- add error reporting to package reloader (many thanks to Andrew Helsley, see: http://openacs.org/forums/message-view?message_id=4166397)

  1. … 3 more files in changeset.
- change 'util_memoize "..."' into 'util_memoize [list ...]' as pointe out by Frank for security reason and correctness

  1. … 6 more files in changeset.
- get rid of old-style parameter passing

  1. … 1 more file in changeset.
- add a warning about loading old-style argument lists for ad_proc

- allow to upgrade basic startup files (openacs-4/tcl/*tcl)

to be upgraded via "install from repository" by adding

and after-upgrade callback to bootstrap-installer and

copying the files from there.

- move initialization of nsv_arrays for apm to -init file in acs-tcl

(as suggested by Peter Marklund, but never implemented)

- use double colon prefix rather than "global" statement

to denote global variables

- bump version number to 5.8.1d3

  1. … 3 more files in changeset.
- use $::acs::rootdir rather than [acs_root_dir] or [get_server_root]

  1. … 13 more files in changeset.
- use lock-free ::acs::rootdir variable instead of nsv variable