• last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
acs-content-repository:

- new public function "cr_cleanup_orphaned_files" to clean up orphaned

files incrementally based on cr-file creation log

- added "cr_cleanup_orphaned_files" to "cr_delete_scheduled_files"

to perform cleanup automatically

- new function to handle cr-file creation log, which is used to

removed orphaned files (created by aborted transactions)

- the function "cr_check_orphaned_files" can still be used

for cleaning up orphaned files from times before the

cr-file creation log was in place (that is from the birth of

OpenACS until now).

acs-tcl:

- new function "ad_mutex_eval" for safely executing

tcl commands under a mutex lock

Added check for trailing slash on cr folder, required for find command to work properly.

- use external command "find" instead of tcllib package fileutil for speed and better filtering

- add index for much quicker reverse lookup file names in the content repository

file upgrade-5.8.1d5-5.8.1d6.sql was initially added on branch oacs-5-8.

file acs-content-repository-procs-postgresql.xql was initially added on branch oacs-5-8.

- cr_check_orphaned_files: new helper proc to locate (or delete) orphaned files in the content repository (see also bug #2619)

- fix a security hole open since ages: every unregistered user could send mails anonymously to arbitray adressees. This was used for spamming at openacs.org.

    • -1
    • +4
    /openacs-4/packages/forums/www/message-email.tcl
- get rid of old-style parameter passing

- get rid of old-style parameter passing

    • -69
    • +108
    /openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl
- get rid of old-style parameter passing

    • -23
    • +66
    /openacs-4/packages/acs-tcl/tcl/widgets-procs.tcl
- get rid of old-style parameter passing

    • -18
    • +31
    /openacs-4/packages/acs-tcl/tcl/apm-procs.tcl
- add a warning about loading old-style argument lists for ad_proc

- get rid of old-style parameter passing

- make cache viewer more robust against funny characters

- FormPage edit: don't hard-code redirect-method, use __form_redirect_method instead

- replace calls to deprecated "ns_sendmail" to calls to "acs_mail_lite::send"

    • -1
    • +1
    /openacs-4/packages/cards/www/student_card.tcl
    • -1
    • +1
    /openacs-4/packages/cards/www/student_notes.tcl
- replace calls to deprecated "ns_sendmail" to calls to "acs_mail_lite::send"

- replace calls to deprecated "ns_sendmail" to calls to "acs_mail_lite::send"

- replace deprecated ns_sendmail by acs_mail_lite::send;

- assessment stores tcl-code in the db. someone with assessement knowledge should take care about updating this code!

- needs to be tested

- stop renaming predefined AOLserver/NaviServer command ns_sendmai (for the time migration phase, simply overwrite it)

- replace calls to deprecated "ns_sendmail" to calls to "acs_mail_lite::send"

- don't rise "internal server errors" (500) for invalid urls

- use tcl-compilable string comparisons

    • -4
    • +4
    /openacs-4/packages/forums/www/message-post.tcl
- don't return hard SQL error on invalid input of forum_id or parent_id

    • -4
    • +14
    /openacs-4/packages/forums/www/message-post.tcl
- don't return an "internal server error" on expected condition (user_id gone)

- improve indenting

- fix old bug occuring e.g. in payment demo, where form_properties(sec_fieldset) are undefined

- fix typo (old bug, many thanks to Michael Aram for spotting this)

    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
add xowiki::File content to the search index:

- extend xowiki method search_render to return "mime" and "text" fields

- xowiki::File->search-render calls now ::search::convert::binary_to_text

to convert file content to index words (when available)

- use dict instead of associative array in ::xowiki::datasource

    • -3
    • +21
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
- added argument "-passing_style" to search::content_filter

to make explicit whether data contains content or a file name.

Previously, text/* meant automatically passing-style string,

leading to missing results when plain files were added

to the content repository

- added filter for text/plain

- fixed filter for text/html

- further clean up

    • -16
    • +58
    /openacs-4/packages/search/tcl/search-procs.tcl