OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 21 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 27 Jan 2023
2:14 pm

antoniop

Reinstate lost comment

Options
    • -1
    • +2
    /openacs-4/packages/calendar/www/cal-item-new.tcl
2:12 pm

antoniop

Use modern date and time form input types so that the time values validated by the contract are the same used by the UI and no different values can be supplied to the form via the pseudo-fields for e.g. year, day and so on...

Options
    • -8
    • +4
    /openacs-4/packages/calendar/www/cal-item-new.adp
    • -81
    • +27
    /openacs-4/packages/calendar/www/cal-item-new.tcl
12:59 pm

gernst

Improve validation

Options
    • -1
    • +3
    /openacs-4/packages/file-storage/www/file-add.tcl
    • -1
    • +2
    /openacs-4/packages/file-storage/www/file-edit.tcl
Thursday 26 Jan 2023
5:30 pm

antoniop

Cleanup leftover, fix typos

Options
    • -5
    • +2
    /openacs-4/packages/acs-lang/tcl/test/acs-lang-localization-procs.tcl
5:24 pm

antoniop

lc_time_tz_convert reform:

- enforce that only dates in the ISO format "%Y-%m-%d %H:%M:%S" are accepted

- apply clock api normalization to seemingly out of range time_values, as per https://www.tcl.tk/man/tcl/TclCmd/clock.html#M25

- return the empty string every time input is invalid or a conversion cannot be determined

- return a value, as ISO date, only when conversion is successful

- prefer the clock api to perform the conversion, but fall back to the ref-timezones datamodel when the timezone is not supported by Tcl

Options
    • -15
    • +0
    /openacs-4/packages/acs-lang/tcl/localization-procs-oracle.xql
    • -12
    • +0
    /openacs-4/packages/acs-lang/tcl/localization-procs-postgresql.xql
    • -11
    • +73
    /openacs-4/packages/acs-lang/tcl/localization-procs.tcl
5:20 pm

antoniop

Introduce a thorough test of the lc_time_tz_convert api checking:

- dates in the distant past

- dates in the distant future

- daylight saving for different times of the year across the two timezones

- historical circumstances (e.g. Pre-timezones US)

- Invalid input

The test shows that the current api does not behave consistently in certain circumstances:

- the same time_value is sometimes returned with invalid input

- the empty string is sometimes returned with valid input

- for dates where the ref-timezones package does not provide information, no result is returned

Options
    • -0
    • +118
    /openacs-4/packages/acs-lang/tcl/test/acs-lang-localization-procs.tcl
3:25 pm

antoniop

Performance improvements:

- add with_headers flag to ::xo::dc list_of_lists behaving like the db_list_of_lists counterpart

- use ::xo::dc list_of_lists as internal for ::xo::dc foreach and ::xo::dc multirow to reduce the need for ns_sets

Options
    • -78
    • +77
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
1:31 pm

antoniop

Collect all query results before executing the code to avoid the out-of-pools bug

Options
    • -1
    • +6
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
1:30 pm

antoniop

Implement a test making sure ::xo::dc "loop code-executing" api is not subject to the "out of pools" bug

Options
    • -0
    • +31
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
11:53 am

antoniop

-prepare flag must not be supplied when not available

Options
    • -3
    • +4
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
11:47 am

antoniop

Fix regression: the reimplementation of ::xo::dc foreach reintroduced the old "out of pools bug"

The fix makes again use of the ns_set api to free the handle before the code is executed

Options
    • -25
    • +17
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
Wednesday 25 Jan 2023
5:51 pm

trenner

set return_url via ::xo::cc to avoid "connection socket is detached" error

Options
    • -1
    • +1
    /openacs-4/packages/xowf/lib/inclass-exam-answer.wf
Tuesday 24 Jan 2023
5:32 pm

gustafn

Adding one more safety belt for potential DOS attacks

For cases, where request blocking is activated (returning 429 status

code for repeated requests), one more check was added: When such a

block happens more than 15 times in a minute on the same URL from the

same user, more requests for the same URL and user will be blocked

until the minute is over. The user seese the message "This web server

is only open for interactive usage".

Background: While request blocking works well for interactive users,

it might not be sufficient for web clients running wild. Normally,

after a 429, the user can reload the page to receive the content of a

page. This leads to a sequence of requests of interleaved 200 and 429

status codes, which might be ignored by a bot (or ad DOS attack). When

the requested page is slow, this can bring a server to its knees.

When request blocking is deactivated, this change has no effect.

Options
    • -4
    • +30
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
5:04 pm

antoniop

Do not abort after the redirect, or the rest of the workflow logic after this action won't fire

Fixes xowf.create_test_items automated test

Options
    • -1
    • +0
    /openacs-4/packages/xowf/lib/inclass-exam-answer.wf
5:00 pm

antoniop

Test issuing the action "logout" to submit an inclass-exam, both with and without a return_url

Options
    • -2
    • +41
    /openacs-4/packages/xowf/tcl/test/test-item-procs.tcl
1:02 pm

antoniop

Shorten idiom

Options
    • -6
    • +4
    /openacs-4/packages/calendar/www/cal-item-new.tcl
12:49 pm

antoniop

Modernize and tighten page contract

Options
    • -17
    • +6
    /openacs-4/packages/calendar/www/cal-item-new.tcl
12:28 pm

antoniop

Protect against malicious inputs, where the value won't be a list

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
Monday 23 Jan 2023
10:23 am

antoniop

Remove hack and prefer to document limitation in the automated test

Options
    • -17
    • +1
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
    • -19
    • +35
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
Friday 20 Jan 2023
1:15 pm

antoniop

Fix typo and include again the hack for strings with colon char in the fallback implementation of ns_pg_prepare

Fixes xotcl-core.test_prepared_statements automated test

Options
    • -3
    • +21
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
8:53 am

trenner

document public api question_statistics_block

Options
    • -0
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
Thursday 19 Jan 2023
7:10 pm

gustafn

improved spelling

Options
    • -3
    • +3
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
6:53 pm

gustafn

use the built-in bindvars parser (when available) for prepared statements

Options
    • -30
    • +34
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
Wednesday 18 Jan 2023
10:51 am

trenner

harden policy

Options
    • -0
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
Tuesday 17 Jan 2023
4:14 pm

antoniop

Handle the case of user misconfiguration, where no item type is selected for a pool question: the resulting filter clause would be invalid in this case

Options
    • -1
    • +10
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
12:15 pm

trenner

split up question_info_block method

Options
    • -0
    • +10
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
11:24 am

antoniop

Update api

Options
    • -5
    • +5
    /openacs-4/packages/xowiki-portlet/tcl/xowiki-admin-portlet-procs.tcl
    • -5
    • +5
    /openacs-4/packages/xowiki-portlet/tcl/xowiki-portlet-procs.tcl
    • -6
    • +7
    /openacs-4/packages/xowiki-portlet/www/xowiki-admin-portlet.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/lib/portlets/weblog-mini-calendar.tcl
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/dotlrn-portal-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/www/admin/index.tcl
    • -3
    • +3
    /openacs-4/packages/xowiki/www/admin/portal-element-add.tcl
    • -1
    • +1
    /openacs-4/packages/xowiki/www/ckeditor-images/thumb-view.tcl
10:54 am

antoniop

Do not extend the existing multirow, we only enforce that this call will have the same columns

Options
    • -8
    • +2
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
10:53 am

antoniop

Test that appending to an existing multirow from the db works as expected: when the columns defined via query and extend are the same, this should succeed

Options
    • -0
    • +39
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
Monday 16 Jan 2023
6:27 pm

antoniop

Don't collide with multirows created by other tests

Options
    • -5
    • +5
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl