OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 10
Total Committers: 146
Last Commit: 14 Nov
Commits this week: 10
Total Lines of Code (LoC): 7,560,821
Net change in LoC this week: 22

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 09 Jan 2023
4:15 pm

antoniop

Strip the possible validation constraint after the first colon character when building the cache key for a parameter, so that the value is stored correctly regardless of the format used to query the parameter

Fixes xowiki.xowiki_test_cases automated test

Options
    • -1
    • +7
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
11:53 am

antoniop

Improve the approach with strings containing colons in prepared SQL statements:

we first normalize all strings with a safe placeholder, substitute the variables, then put the strings back in place.

Options
    • -2
    • +19
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
11:52 am

antoniop

Extend test for prepared statements containing strings with colon characters, exposing that the latest commit won't address all cases

Options
    • -0
    • +13
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
Thursday 05 Jan 2023
5:54 pm

antoniop

Make test more consistent

Options
    • -1
    • +1
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
5:50 pm

antoniop

Improve the regexp detecting variables in a prepared statement, so that a prepared variable must not be preceded by a semicolon (as before), but also by any character allowed for a variable name

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
5:49 pm

antoniop

Introduce a test exposing that when a statement is prepared on SQL containing colons, this sould fail because they would be interpreted as variables

Options
    • -0
    • +10
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
Wednesday 04 Jan 2023
5:33 pm

antoniop

Reduce logging as we do downstream

Options
    • -2
    • +3
    /openacs-4/packages/acs-service-contract/tcl/acs-service-contract-procs.tcl
1:21 pm

antoniop

Refactor the query in the folder-chunk page so that on postgres one can enforce permissions in bulk, rather than for each file

Options
    • -0
    • +47
    /openacs-4/packages/file-storage/www/folder-chunk-postgresql.xql
    • -31
    • +2
    /openacs-4/packages/file-storage/www/folder-chunk.tcl
    • -3
    • +31
    /openacs-4/packages/file-storage/www/folder-chunk.xql
12:34 pm

antoniop

Allow to prepare a statement with no parameters (See https://www.postgresql.org/docs/11/sql-prepare.html)

Options
    • -3
    • +11
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
12:32 pm

antoniop

Basic test of the prepared statements feature on ::xo::dc api

Options
    • -0
    • +69
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
Tuesday 03 Jan 2023
11:56 am

antoniop

Fix typo

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
11:37 am

antoniop

Prefer xo::dc api

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Monday 02 Jan 2023
6:46 pm

antoniop

Fix typo

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
4:26 pm

antoniop

Reuse the canvas objects throughout the proctoring

Options
    • -1
    • +5
    /openacs-4/packages/proctoring-support/www/resources/proctoring.js
Thursday 29 Dec 2022
3:17 pm

gustafn

make naming more consistent

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/cluster-procs.tcl
3:14 pm

gustafn

differentiate between sent and received intra-server messages

Options
    • -3
    • +4
    /openacs-4/packages/acs-tcl/tcl/cluster-procs.tcl
2:02 pm

gustafn

added multiple delivery methods to intra-server talk

Here is some background information for my experiments with the delivery methods.

For this experiment, I compared 5 different means for this kind of

communications

- ns_http over HTTP (the standard setup, which is used in OpenACS 5.10)

- ns_http over HTTPS

- ns_conn over HTTP using persistent connections

- ns_conn over HTTPS using persistent connections

- ns_udp using UDP

 

I tested the is in 2-node cluster to make measurements simple consisting

of the canonical server and one node listening on the following protocols/ports:

- http://127.0.0.1:8101

- https://127.0.0.1:8444

- udp://127.0.0.1:8101

The first test sends per call 1000 intra-server commands from the canonical server

to the 2nd node over the various delivery methods:

set times 1000

lappend _ ns_http-[time {::acs::CS_127.0.0.1_8101 message set x ns_http} $times]

lappend _ ns_https-[time {::acs::CS_127.0.0.1_8444 message set x ns_https} $times]

lappend _ ns_connchan-http-[time {::acs::CS_127.0.0.1_8101 message -delivery connchan set x ns_http} $times]

lappend _ ns_connchan-https-[time {::acs::CS_127.0.0.1_8444 message -delivery connchan set x ns_https} $times]

lappend _ ns_udp-[time {::acs::CS_127.0.0.1_8101 message -delivery udp set x udp} $times]

join $_ \n

This leads to the following results:

ns_http 564.027083 microseconds per iteration

ns_https 1483.478916 microseconds per iteration

ns_connchan-http 147.688541 microseconds per iteration

ns_connchan-https 68.480875 microseconds per iteration

ns_udp 198.343416 microseconds per iteration

Since the commands are sent in sequence, the variant with the

persistent HTTP connection is the fastest, although this is Tcl

implemented. The slowest is the version with HTTPS via ns_http without

persistent connections. We see a factor of 20 in terms of performance.

When using ns_udp with the "-noreply" option, we have would have

a "fire and forget" solution, which might be ok when the packet loss

rate is low. That would lead to 54 microseconds.

Clearly, the numbers for persistent connections look the best, but it has

as well some disadvantages compared to other solutions:

- the server has to keep a socket open to every node (but no

connection thread)

- the keepalive setting of the server must set sufficiently long to

gain advantage of persistent connections (e.g. 5 sec keepalive,

heart beat frequency of 1s)

- Since the whole communication goes over a single connection, it is

necessary to serialize the requests to avoid that multiple

connection threads write concurrently to the same connection and

interfere with each other

- It is probably necessary to have a separate thread handling the

outgoing intra-server talk (implementing cmd queuing,

async-handling, heart-beat, etc.). Since this has to be a Tcl-thread

it will use up some memory (similar to a connection thread).

- This intra-server talk thread requires queuing and event handling we

have so far just in xotcl-core, so when implemented, it will require

the xotcl-core package (maybe this can be put later to acs-core).

As a second experiment, I've implemented a simple heart-beat service

inside the request monitor that checks the liveliness of the nodes

every second. So, in contrary to the back to back commands of the

first experiment, these are single calls. Here are some random

values for the 5 delivery methods:

[27/Dec/2022:20:29:34.171376][::throttle] Notice: -cluster: http://127.0.0.1:8101 set x ns_http sent total 2.907ms

[27/Dec/2022:20:29:34.182241][::throttle] Notice: -cluster: https://127.0.0.1:8444 set x ns_https sent total 10.798ms

[27/Dec/2022:20:29:34.183475][::throttle] Notice: -cluster: http://127.0.0.1:8101 set x ns_connchan sent total 1.161m

[27/Dec/2022:20:29:34.183657][::throttle] Notice: -cluster: https://127.0.0.1:8444 set x https-connchan sent total 0.086ms

[27/Dec/2022:20:29:34.188564][::throttle] Notice: -cluster: udp://127.0.0.1:8101 set x udp sent total 4.861ms

[27/Dec/2022:20:30:25.494080][::throttle] Notice: -cluster: http://127.0.0.1:8101 set x ns_http sent total 2.049ms

[27/Dec/2022:20:30:25.516306][::throttle] Notice: -cluster: https://127.0.0.1:8444 set x ns_https sent total 21.903ms

[27/Dec/2022:20:30:25.517239][::throttle] Notice: -cluster: http://127.0.0.1:8101 set x ns_connchan sent total 0.814ms

[27/Dec/2022:20:30:25.522957][::throttle] Notice: -cluster: https://127.0.0.1:8444 set x https-connchan sent total 0.33ms

[27/Dec/2022:20:30:25.534274][::throttle] Notice: -cluster: udp://127.0.0.1:8101 set x udp sent total 11.099ms

[27/Dec/2022:20:31:54.993455][::throttle] Notice: -cluster: http://127.0.0.1:8101 set x ns_http sent total 2.431ms

[27/Dec/2022:20:31:55.003036][::throttle] Notice: -cluster: https://127.0.0.1:8444 set x ns_https sent total 9.499ms

[27/Dec/2022:20:31:55.010100][::throttle] Notice: -cluster: http://127.0.0.1:8101 set x ns_connchan sent total 6.981ms

[27/Dec/2022:20:31:55.010585][::throttle] Notice: -cluster: https://127.0.0.1:8444 set x https-connchan sent total 0.322ms

[27/Dec/2022:20:31:55.017764][::throttle] Notice: -cluster: udp://127.0.0.1:8101 set x udp sent total 7.13ms

We see in essence the same pattern. The approach with the persistent

connections looks here the best as well. It is not clear to me, why

HTTPS over connchan is the best, but the communication seems ok. Maybe

some buffering/nagle algorithm is responsible for this. We see as well

that the round-trip takes typically single to double-digit

milliseconds. So when a single HTTP request to nsd triggers multiple

cache-flush operations to multiple nodes, this will take some

time. When e.g., the request issues 5 cash-flush operations, which are

sent to 5 nodes, and every request with take 1ms, the cache flushing

will make the original request about 25ms slower. This might also be

an argument for a separate thread doing these operations

asynchronously.

Options
    • -1
    • +12
    /openacs-4/packages/acs-tcl/tcl/cluster-init.tcl
    • -30
    • +230
    /openacs-4/packages/acs-tcl/tcl/cluster-procs.tcl
1:54 pm

gustafn

improved clusterwide operations

Options
    • -5
    • +26
    /openacs-4/packages/acs-tcl/tcl/acs-cache-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/memoize-procs-naviserver.tcl
    • -6
    • +30
    /openacs-4/packages/acs-tcl/tcl/memoize-procs.tcl
1:52 pm

gustafn

improved support for cluster-wide operations

Options
    • -4
    • +14
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
    • -9
    • +9
    /openacs-4/packages/acs-templating/tcl/query-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
1:05 pm

gustafn

added cluster-awareness

NOTE: one should use here the acs-cluster infrastructure instead to

achieve better scalability and easier cache maintenance

Options
    • -11
    • +11
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
Wednesday 28 Dec 2022
10:25 am

gustafn

update comments

Options
    • -5
    • +5
    /openacs-4/packages/acs-tcl/tcl/exception-procs.tcl
Saturday 24 Dec 2022
5:33 pm

gustafn

provide for FormPages a differentiated error message

This treats in particular the case of a language prefix followed by

an empty name.

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -0
    • +1
    /openacs-4/packages/xowiki/catalog/xowiki.de_DE.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/xowiki/catalog/xowiki.en_US.ISO-8859-1.xml
    • -2
    • +10
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
5:21 pm

gustafn

disallow names, which look like a language prefix followed by an empty name

Empty names are not allowed.

The error message is just always the same for wiki pages, so

this is not perfect.

Options
    • -1
    • +8
    /openacs-4/packages/xowiki/tcl/xowiki-form-procs.tcl
Thursday 22 Dec 2022
5:12 am

gustafn

added space between icon and the info text

Options
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/resources/forms/form-horizontal.adp
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/resources/forms/standard.adp
3:51 am

gustafn

improve strictness of tests

Options
    • -2
    • +2
    /openacs-4/packages/acs-bootstrap-installer/installer/index.tcl
    • -3
    • +3
    /openacs-4/packages/acs-templating/tcl/date-procs.tcl
    • -2
    • +2
    /openacs-4/packages/assessment/lib/section-links.tcl
    • -2
    • +2
    /openacs-4/packages/caldav/tcl/caldav-interface-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/last-requests.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/running.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/whos-online.tcl
    • -3
    • +5
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
3:39 am

gustafn

improve robustness

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/doc-check-procs.tcl
3:36 am

gustafn

whitespace change

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl
Tuesday 20 Dec 2022
4:20 pm

antoniop

Follow Chrome suggestion and apply the willReadFrequently option to the canvas context

See https://html.spec.whatwg.org/multipage/canvas.html#concept-canvas-will-read-frequently

Options
    • -1
    • +2
    /openacs-4/packages/proctoring-support/www/resources/proctoring.js
Thursday 15 Dec 2022
8:30 pm

gustafn

improved checking of parameter values, which might be influenced via query parameters

Options
    • -4
    • +4
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
    • -5
    • +5
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
    • -4
    • +4
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/weblog-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-form-procs.tcl
    • -6
    • +6
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
    • -7
    • +7
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
8:28 pm

gustafn

Added improved support for viewing and downloading of exam results

When results are available, "Points and Grades" can be used.

Results are available,

- for autocorrected questions, when the exam protocol was rendered, or

- for all types of questions, when lecturers have added manual gradings/comments.

Depending on whether a grading scheme was defined for the exam,

it is possible to view/download grades and grade statistics, or to these

just with points. It is also possible to get the total results per student

(including grades) or results per question.

The results are available

- in tabular form, with the ability to sort on the columns,

- as charts, and

- as csv-files (for loading into spreadsheets).

The version number was bumped to 5.10.1d50

Options
    • -2
    • +2
    /openacs-4/packages/xowf/xowf.info
    • -0
    • +8
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -1
    • +9
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
    • -63
    • +159
    /openacs-4/packages/xowf/lib/inclass-exam.wf
    • -7
    • +7
    /openacs-4/packages/xowf/tcl/grading-procs.tcl
    • -36
    • +227
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl