OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 21 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 13 Jan 2020
5:31 pm

antoniop

Prefer api to retrieve csp nonce, as it performs useful existance checks

Options
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/paginator-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-templating/tcl/richtext-procs.tcl
    • -6
    • +6
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
    • -4
    • +4
    /openacs-4/packages/xowiki/tcl/link-procs.tcl
5:21 pm

antoniop

Prefer api to retrieve csp nonce, as it performs useful existance checks

Options
    • -7
    • +7
    /openacs-4/packages/acs-admin/www/install/install-3.tcl
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/apm/package-add.tcl
    • -3
    • +3
    /openacs-4/packages/acs-admin/www/apm/version-edit.tcl
    • -4
    • +4
    /openacs-4/packages/acs-admin/www/apm/packages-install-4.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/richtext-or-file-procs.tcl
4:12 pm

antoniop

Trim trailing ? to normalize -base URL, if variables are there to be exported, the question mark will be added properly

Options
    • -1
    • +2
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
4:07 pm

antoniop

Introduce two new export_vars tests exposing that, when base URL ends with a ?, result is not what the user should expect

Options
    • -0
    • +8
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
Thursday 09 Jan 2020
7:39 pm

antoniop

Port "The Secret XoWiki Tests" to acs-automated-testing

A level of abstraction for test operations was already put in place, which was sufficient to plug to aa_* api

Options
    • -0
    • +1492
    /openacs-4/packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl
7:39 pm

antoniop

file xowiki-admin-tests-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl
5:01 pm

antoniop

Relax the test by enforcing the locale from the system, rather than that from the client context

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/navigation-procs.tcl
4:43 pm

antoniop

Satisfy acs-tcl.postman_echo test case for curl http client implementation:

as with curl we always spool the body of requests into a file, we need to convert to the proper encoding even when this is already that of the system

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
4:40 pm

antoniop

Improve test results visibility

Options
    • -3
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/http-client-procs.tcl
3:08 pm

antoniop

Fix util_http_json_encoding automated test:

- fix typo

- make sure file is spooled when sampling GET request by setting max body size to 0

Options
    • -4
    • +4
    /openacs-4/packages/acs-tcl/tcl/test/http-client-procs.tcl
12:07 pm

mischa

Fix typo in example in comment

Options
    • -2
    • +2
    /openacs-4/packages/cookie-consent/tcl/cookie-consent-procs.tcl
12:06 pm

mischa

Fix typo in package key

Options
    • -2
    • +2
    /openacs-4/packages/cookie-consent/tcl/cookie-consent-procs.tcl
Wednesday 08 Jan 2020
7:24 pm

antoniop

Port leftover after-instantiate callback to the "new standard" so that it can comply with OpenACS naming convention

Options
    • -7
    • +9
    /openacs-4/packages/dotlrn-homework/dotlrn-homework.info
    • -1
    • +16
    /openacs-4/packages/dotlrn-homework/tcl/apm-callback-procs.tcl
    • -1
    • +7
    /openacs-4/packages/dotlrn-homework/tcl/dotlrn-homework-procs.tcl
6:53 pm

antoniop

Add doc for public procs

Options
    • -0
    • +4
    /openacs-4/packages/chat-portlet/tcl/chat-admin-portlet-procs.tcl
    • -0
    • +4
    /openacs-4/packages/chat-portlet/tcl/chat-portlet-procs.tcl
6:48 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -21
    • +0
    /openacs-4/packages/acs-subsite/tcl/attribute-procs-oracle.xql
    • -31
    • +0
    /openacs-4/packages/acs-subsite/tcl/attribute-procs-postgresql.xql
    • -7
    • +34
    /openacs-4/packages/acs-subsite/tcl/attribute-procs.tcl
6:24 pm

antoniop

Whitespace cleanup

Options
    • -13
    • +13
    /openacs-4/packages/acs-tcl/tcl/security-procs-oracle.xql
    • -12
    • +12
    /openacs-4/packages/acs-tcl/tcl/security-procs-postgresql.xql
    • -18
    • +18
    /openacs-4/packages/acs-tcl/tcl/security-procs.xql
2:47 pm

antoniop

Qualify 'callback' proc in the global namespace, lest it might conflict with 'subsite::callback'

Options
    • -3
    • +2
    /openacs-4/packages/acs-subsite/tcl/subsite-procs.tcl
2:25 pm

antoniop

Use portable sql idioms

Options
    • -1
    • +1
    /openacs-4/packages/search/tcl/search-procs.xql
1:05 pm

antoniop

Whitespace cleanup

Options
    • -36
    • +36
    /openacs-4/packages/acs-tcl/tcl/apm-procs-oracle.xql
    • -25
    • +25
    /openacs-4/packages/acs-tcl/tcl/apm-procs-postgresql.xql
    • -60
    • +60
    /openacs-4/packages/acs-tcl/tcl/apm-procs.xql
12:55 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -53
    • +0
    /openacs-4/packages/new-portal/tcl/portal-procs-oracle.xql
    • -53
    • +0
    /openacs-4/packages/new-portal/tcl/portal-procs-postgresql.xql
    • -0
    • +53
    /openacs-4/packages/new-portal/tcl/portal-procs.xql
12:28 pm

antoniop

Reintroduce :num_count variable in postgres query, as for oracle counterpart (for postgres, 15 was hardcoded)

Notes:

- :num_count comes from a parameter, defaulting to 100, instead of 15

- postgres 9.5 introduced table sampling, similar to what oracle does (but with different syntax)

- this postgres query would be portable, except for random()... maybe the random value could come from tcl...

Options
    • -2
    • +3
    /openacs-4/packages/acs-tcl/tcl/security-procs-postgresql.xql
Tuesday 07 Jan 2020
5:54 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -19
    • +0
    /openacs-4/packages/acs-subsite/www/admin/group-types/one-oracle.xql
    • -20
    • +0
    /openacs-4/packages/acs-subsite/www/admin/group-types/one-postgresql.xql
    • -2
    • +24
    /openacs-4/packages/acs-subsite/www/admin/group-types/one.tcl
5:03 pm

antoniop

Whitespace cleanup

Options
    • -12
    • +12
    /openacs-4/packages/acs-lang/tcl/localization-procs-oracle.xql
    • -10
    • +9
    /openacs-4/packages/acs-lang/tcl/localization-procs-postgresql.xql
4:53 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -20
    • +0
    /openacs-4/packages/acs-admin/www/users/member-state-change-oracle.xql
    • -18
    • +0
    /openacs-4/packages/acs-admin/www/users/member-state-change-postgresql.xql
    • -8
    • +6
    /openacs-4/packages/acs-admin/www/users/member-state-change.tcl
2:28 pm

antoniop

Use fully-qualified api names

Options
    • -2
    • +2
    /openacs-4/packages/forums/tcl/messages-procs.tcl
2:26 pm

antoniop

Indentation changes

Options
    • -7
    • +6
    /openacs-4/packages/forums/tcl/messages-procs.tcl
1:27 pm

antoniop

Deprecate obsolete api

Options
    • -2
    • +9
    /openacs-4/packages/forums/tcl/messages-procs.tcl
1:20 pm

antoniop

No need to explicitly delete reading info, as both oracle and postgres define the reference constraint as on delete cascade

Options
    • -9
    • +1
    /openacs-4/packages/forums/tcl/messages-procs.tcl
1:16 pm

antoniop

Use fully-qualified api names

Options
    • -3
    • +3
    /openacs-4/packages/forums/tcl/messages-procs.tcl
1:12 pm

antoniop

Use fully-qualified api names, assume message is there (something went very wrong otherwise)

Options
    • -4
    • +5
    /openacs-4/packages/forums/tcl/messages-procs.tcl